You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/09 13:59:20 UTC

[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #13096: ARROW-16501: [Docs][C++][R] Migrate to Matomo from Google Analytics

jorisvandenbossche commented on code in PR #13096:
URL: https://github.com/apache/arrow/pull/13096#discussion_r868046790


##########
docs/source/_templates/layout.html:
##########
@@ -1,5 +1,26 @@
 {% extends "pydata_sphinx_theme/layout.html" %}
 
+{# Use Matomo #}
+{% block extrahead %}
+<!-- Matomo -->

Review Comment:
   This might need a `{{ super() }}` to keep not replace the full content of the `extrahead` block of the parent theme, but to only append the matomo script?
   
   (the extrahead block still seems to have some useful things (eg favicons) apart from the google analytics)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org