You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/07/08 15:23:38 UTC
[GitHub] brooklyn-server pull request #241: catalog-classes.bom: adds brooklyn-test-f...
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/241
catalog-classes.bom: adds brooklyn-test-framework entities
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server karaf-catalog-classes-includes-test-cases
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/241.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #241
----
commit 01014afefc804ae828baad40580eccde3849e401
Author: Aled Sage <al...@gmail.com>
Date: 2016-07-08T13:57:29Z
catalog-classes.bom: adds brooklyn-test-framework entities
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #241: catalog-classes.bom: adds brooklyn-test-f...
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/241#discussion_r70271606
--- Diff: karaf/init/src/main/resources/catalog-classes.bom ---
@@ -505,3 +505,36 @@ brooklyn.catalog:
type: org.apache.brooklyn.entity.cm.ansible.AnsibleEntity
name: AnsibleEntity
description: Software managed by Ansible CM
+
+ - brooklyn.libraries:
+ - name: org.apache.brooklyn.brooklyn-test-framework
+ version: "0.10.0.SNAPSHOT" # BROOKLYN_VERSION
+ itemType: entity
+ items:
+ - id: org.apache.brooklyn.test.framework.TestSshCommand
+ item:
+ type: org.apache.brooklyn.test.framework.TestSshCommand
+ - id: org.apache.brooklyn.test.framework.SimpleShellCommandTest
--- End diff --
I suppose this is needed even though it's been renamed as TestSshCommand, because the old and now deprecated class exists? Or would it not be ok to leave it out here, and let TestSshCommand be the only one available in the catalog?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #241: catalog-classes.bom: adds brooklyn-test-f...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/241#discussion_r70421064
--- Diff: karaf/init/src/main/resources/catalog-classes.bom ---
@@ -505,3 +505,36 @@ brooklyn.catalog:
type: org.apache.brooklyn.entity.cm.ansible.AnsibleEntity
name: AnsibleEntity
description: Software managed by Ansible CM
+
+ - brooklyn.libraries:
+ - name: org.apache.brooklyn.brooklyn-test-framework
+ version: "0.10.0.SNAPSHOT" # BROOKLYN_VERSION
+ itemType: entity
+ items:
+ - id: org.apache.brooklyn.test.framework.TestSshCommand
+ item:
+ type: org.apache.brooklyn.test.framework.TestSshCommand
+ - id: org.apache.brooklyn.test.framework.SimpleShellCommandTest
--- End diff --
Good question. That depends on what backwards compatibility we want. I think we want to minimise the amount of breakage when someone is upgrading so probably include it. But we want to hide it so folk aren't offered it.
We have a `CatalogItem.setDeprecated`. We should probably change our yaml parser to accept `deprecated: true`, and to set that on the catalog item. But not in this PR. See https://issues.apache.org/jira/browse/BROOKLYN-315
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #241: catalog-classes.bom: adds brooklyn-test-framewor...
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/241
One question, but LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #241: catalog-classes.bom: adds brooklyn-test-f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/241
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---