[GitHub] [pulsar] merlimat commented on a change in pull request #3750: Negative acks in C++ client

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #3750: Negative acks in C++ client
URL: https://github.com/apache/pulsar/pull/3750#discussion_r263103180
 
 

 ##########
 File path: pulsar-client-cpp/tests/BasicEndToEndTest.cc
 ##########
 @@ -99,7 +100,7 @@ static void sendCallBackWithDelay(Result r, const Message& msg, std::string pref
 
 class EncKeyReader : public CryptoKeyReader {
    private:
-    void readFile(std::string fileName, std::string& fileContents) const {
+    void readFile(std::string fileName, std::string &fileContents) const {
 
 Review comment:
   This is existing code and it was just one space reformatted by `make format`. 
   In any case the functional change should be done in a different PR. Given this is for test, I'm not particular concerned about a string copy when loading the key file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services