You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/22 19:34:34 UTC

[GitHub] [pulsar-helm-chart] sijie commented on a change in pull request #236: To address the function role vs clusterrole issue

sijie commented on a change in pull request #236:
URL: https://github.com/apache/pulsar-helm-chart/pull/236#discussion_r812291367



##########
File path: charts/pulsar/values.yaml
##########
@@ -776,6 +776,11 @@ broker:
 ##
 functions:
   component: functions-worker
+  ## Pulsar: Functions Worker ClusterRole or Role
+  ## templates/broker-rbac.yaml
+  # Default is false which deploys functions with ClusterRole and ClusterRoleBinding at the cluster level
+  # Set to true to deploy functions with Role and RoleBinding inside the specified namespace
+  limit_to_namespace: false

Review comment:
       @bsheltonihs can you make this setting to be `functions.rbac.limit_to_namespace`? it is probably better to be scoped under `functions.rbac` so people understand that it is a `rbac` related setting.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org