You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/09/11 07:47:24 UTC

[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #190: [YUNIKORN-410] Pod state change may cause incorrect update on SchedulerNode#occupied

codecov[bot] commented on pull request #190:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/190#issuecomment-690934990


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/190?src=pr&el=h1) Report
   > Merging [#190](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/190?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/d093b0d550e4aff685fdd42ed166db0ec77d27dd?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/190/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/190?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #190      +/-   ##
   ==========================================
   - Coverage   58.94%   58.94%   -0.01%     
   ==========================================
     Files          33       33              
     Lines        3303     3305       +2     
   ==========================================
   + Hits         1947     1948       +1     
   - Misses       1285     1286       +1     
     Partials       71       71              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/190?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/cache/node\_coordinator.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/190/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL25vZGVfY29vcmRpbmF0b3IuZ28=) | `65.62% <100.00%> (+1.10%)` | :arrow_up: |
   | [pkg/shim/scheduler\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/190/diff?src=pr&el=tree#diff-cGtnL3NoaW0vc2NoZWR1bGVyX21vY2suZ28=) | `85.00% <0.00%> (-0.84%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/190?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/190?src=pr&el=footer). Last update [d093b0d...cd65189](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org