You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/06/29 09:30:07 UTC
[GitHub] flink pull request #4221: [FLINK-7037] Remove scala suffic from flink-exampl...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4221
[FLINK-7037] Remove scala suffic from flink-examples module
This PR removes the scala version suffix from the flink-examples module.
The suffix prevented building single modules that rely on any example module. This does not cause issues when building flink completely as we traverse the modules from the parent, allowing the scala version to be resolved for all modules.
When building a single module in order to resolve the scala version we have to traverse from the target module towards the parent, which isn't possible since the scala version isn't resolved.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7037
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4221.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4221
----
commit 6aadbc9237ae65313e73259021d6654115bc5461
Author: zentol <ch...@apache.org>
Date: 2017-06-29T09:26:32Z
[FLINK-7037] Remove scala suffic from flink-examples module
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4221: [FLINK-7037] Remove scala suffic from flink-examples modu...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4221
+1. Test failure is unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4221: [FLINK-7037] Remove scala suffic from flink-examples modu...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4221
@greghogan fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4221: [FLINK-7037] Remove scala suffic from flink-examples modu...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4221
@aljoscha Because it is the only parent module that has a scala suffix. All other modules with a scala suffix don't have children.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4221: [FLINK-7037] Remove scala suffic from flink-examples modu...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4221
Thanks! That makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4221: [FLINK-7037] Remove scala suffic from flink-exampl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4221
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4221: [FLINK-7037] Remove scala suffic from flink-examples modu...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4221
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4221: [FLINK-7037] Remove scala suffic from flink-exampl...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4221#discussion_r125350366
--- Diff: flink-examples/flink-examples-table/pom.xml ---
@@ -24,7 +24,7 @@ under the License.
<parent>
<groupId>org.apache.flink</groupId>
- <artifactId>flink-examples_${scala.binary.version}</artifactId>
+ <artifactId>flink-examples}</artifactId>
--- End diff --
Leftover `}`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4221: [FLINK-7037] Remove scala suffic from flink-examples modu...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4221
@zentol why was this only a problem for the example module?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---