You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "DieterDP-ng (via GitHub)" <gi...@apache.org> on 2024/12/02 18:01:51 UTC

Re: [PR] HBASE-28882 Backup restores are broken if the backup has moved locations [hbase]

DieterDP-ng commented on code in PR #6294:
URL: https://github.com/apache/hbase/pull/6294#discussion_r1866343538


##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupMergeJob.java:
##########
@@ -228,13 +228,15 @@ protected void copyMetaData(FileSystem fs, Path tmpBackupDir, Path backupDirPath
       if (
         fileName.indexOf(FSTableDescriptors.TABLEINFO_DIR) > 0
           || fileName.indexOf(HRegionFileSystem.REGION_INFO_FILE) > 0
+          || fileName.indexOf(BackupManifest.MANIFEST_FILE_NAME) > 0

Review Comment:
   While I agree with this change, I can't find what was changed that previously put the manifest in the correct location. Just curious.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org