[GitHub] [spark] viirya commented on a change in pull request #24581: [SPARK-27675][SQL] do not use MutableColumnarRow in ColumnarBatch

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #24581: [SPARK-27675][SQL] do not use MutableColumnarRow in ColumnarBatch
URL: https://github.com/apache/spark/pull/24581#discussion_r282950192
 
 

 ##########
 File path: sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarBatch.java
 ##########
 @@ -108,6 +111,170 @@ public InternalRow getRow(int rowId) {
 
   public ColumnarBatch(ColumnVector[] columns) {
     this.columns = columns;
-    this.row = new MutableColumnarRow(columns);
+    this.row = new ColumnarBatchRow(columns);
   }
 }
+
+/**
+ * An internal class, which wraps an array of {@link ColumnVector} and provides a row view.
+ */
+class ColumnarBatchRow extends InternalRow {
 
 Review comment:
   Make it `final class` like `ColumnarRow` and `MutableColumnarRow`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org