[GitHub] [zeppelin] alexott commented on a change in pull request #3717: [ZEPPELIN-4717]. Support savepoint for insert statement and non-sql paragraph

[GitBox <gi...@apache.org>]

alexott commented on a change in pull request #3717: [ZEPPELIN-4717]. Support savepoint for insert statement and non-sql paragraph
URL: https://github.com/apache/zeppelin/pull/3717#discussion_r410867134
 
 

 ##########
 File path: flink/src/main/java/org/apache/zeppelin/flink/FlinkSqlInterrpeter.java
 ##########
 @@ -504,24 +499,20 @@ public void callSet(String key, String value, InterpreterContext context) throws
       throw new IOException(key + " is not a valid table/sql config, please check link: " +
               "https://ci.apache.org/projects/flink/flink-docs-release-1.10/dev/table/config.html");
     }
-    currentConfigOptions.put(key, value);
+    paragraphTableConfigMap.get(context.getParagraphId()).put(key, value);
   }
 
-  private void callInsertInto(String sql,
+  public void callInsertInto(String sql,
                               InterpreterContext context) throws IOException {
      if (!isBatch()) {
        context.getLocalProperties().put("flink.streaming.insert_into", "true");
      }
      try {
        lock.lock();
-       if (context.getLocalProperties().containsKey("parallelism")) {
-         this.tbenv.getConfig().getConfiguration()
-                 .set(ExecutionConfigOptions.TABLE_EXEC_RESOURCE_DEFAULT_PARALLELISM,
-                         Integer.parseInt(context.getLocalProperties().get("parallelism")));
-       }
 
        // set table config from set statement until now.
-       for (Map.Entry<String, String> entry : currentConfigOptions.entrySet()) {
+       Map<String, String> paragraphTableConfig = paragraphTableConfigMap.get(context.getParagraphId());
 
 Review comment:
   same here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services