You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/20 07:28:39 UTC
[GitHub] [pulsar] Technoboy- opened a new pull request #11386: [Discuss] Cherry-picking #11310 Fix npe when unloading persistent partitioned topic in branch-2.7.
Technoboy- opened a new pull request #11386:
URL: https://github.com/apache/pulsar/pull/11386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #11386: [Discuss] Cherry-picking #11310 Fix npe when unloading persistent partitioned topic in branch-2.7.
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #11386:
URL: https://github.com/apache/pulsar/pull/11386#discussion_r672885794
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1548,9 +1548,9 @@ public void checkTopicNsOwnership(final String topic) throws BrokerServiceExcept
List<CompletableFuture<Void>> closeFutures = Lists.newArrayList();
topics.forEach((name, topicFuture) -> {
TopicName topicName = TopicName.get(name);
- if (serviceUnit.includes(topicName)) {
+ if (getTopicReference(name).isPresent() && serviceUnit.includes(topicName)) {
Review comment:
in the linked PR there was a comment to move `getTopicReference(name).isPresent()` as last operator
probably it is the case to fix it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #11386: [Discuss] Cherry-picking #11310 Fix npe when unloading persistent partitioned topic in branch-2.7.
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #11386:
URL: https://github.com/apache/pulsar/pull/11386#discussion_r672885794
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1548,9 +1548,9 @@ public void checkTopicNsOwnership(final String topic) throws BrokerServiceExcept
List<CompletableFuture<Void>> closeFutures = Lists.newArrayList();
topics.forEach((name, topicFuture) -> {
TopicName topicName = TopicName.get(name);
- if (serviceUnit.includes(topicName)) {
+ if (getTopicReference(name).isPresent() && serviceUnit.includes(topicName)) {
Review comment:
in the linked PR there was a comment to move `getTopicReference(name).isPresent()` as last operator
probably it is the case to fix it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #11386: [Discuss] Cherry-picking #11310 Fix npe when unloading persistent partitioned topic in branch-2.7.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #11386:
URL: https://github.com/apache/pulsar/pull/11386#discussion_r673018058
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1548,9 +1548,9 @@ public void checkTopicNsOwnership(final String topic) throws BrokerServiceExcept
List<CompletableFuture<Void>> closeFutures = Lists.newArrayList();
topics.forEach((name, topicFuture) -> {
TopicName topicName = TopicName.get(name);
- if (serviceUnit.includes(topicName)) {
+ if (getTopicReference(name).isPresent() && serviceUnit.includes(topicName)) {
Review comment:
@Technoboy- Please check the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #11386: [Discuss] Cherry-picking #11310 Fix npe when unloading persistent partitioned topic in branch-2.7.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #11386:
URL: https://github.com/apache/pulsar/pull/11386#discussion_r673018058
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1548,9 +1548,9 @@ public void checkTopicNsOwnership(final String topic) throws BrokerServiceExcept
List<CompletableFuture<Void>> closeFutures = Lists.newArrayList();
topics.forEach((name, topicFuture) -> {
TopicName topicName = TopicName.get(name);
- if (serviceUnit.includes(topicName)) {
+ if (getTopicReference(name).isPresent() && serviceUnit.includes(topicName)) {
Review comment:
@Technoboy- Please check the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a change in pull request #11386: [Discuss] Cherry-picking #11310 Fix npe when unloading persistent partitioned topic in branch-2.7.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #11386:
URL: https://github.com/apache/pulsar/pull/11386#discussion_r673066608
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1548,9 +1548,9 @@ public void checkTopicNsOwnership(final String topic) throws BrokerServiceExcept
List<CompletableFuture<Void>> closeFutures = Lists.newArrayList();
topics.forEach((name, topicFuture) -> {
TopicName topicName = TopicName.get(name);
- if (serviceUnit.includes(topicName)) {
+ if (getTopicReference(name).isPresent() && serviceUnit.includes(topicName)) {
Review comment:
Yes, I see, thanks.
@eolivelli @codelipenghui .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #11386: [Discuss] Cherry-picking #11310 Fix npe when unloading persistent partitioned topic in branch-2.7.
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #11386:
URL: https://github.com/apache/pulsar/pull/11386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #11386: [Discuss] Cherry-picking #11310 Fix npe when unloading persistent partitioned topic in branch-2.7.
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #11386:
URL: https://github.com/apache/pulsar/pull/11386#discussion_r672885794
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1548,9 +1548,9 @@ public void checkTopicNsOwnership(final String topic) throws BrokerServiceExcept
List<CompletableFuture<Void>> closeFutures = Lists.newArrayList();
topics.forEach((name, topicFuture) -> {
TopicName topicName = TopicName.get(name);
- if (serviceUnit.includes(topicName)) {
+ if (getTopicReference(name).isPresent() && serviceUnit.includes(topicName)) {
Review comment:
in the linked PR there was a comment to move `getTopicReference(name).isPresent()` as last operator
probably it is the case to fix it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org