You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/07/05 13:59:06 UTC
[GitHub] [cordova-osx] bpresles opened a new pull request #105: (osx) Fix #104: Make Cordova OSX build successfully on AppleSilicon target.
bpresles opened a new pull request #105:
URL: https://github.com/apache/cordova-osx/pull/105
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
macOS ARM64 (AppleSilicon).
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Build failed when targeting AppleSilicon because of using old prototype for objc_msgSend.
### Description
<!-- Describe your changes in detail -->
Closes #104
- Added "arm64" as valid architecture
- Changed calls to objc_msgSend() to use new cast based prototype.
### Testing
<!-- Please describe in detail how you tested your changes. -->
- Built the library on XCode 12 with support for Universal Binaries and AppleSilicon
- Tested the universal binary build of the library on a Cordova OS X project
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-osx] brodybits commented on pull request #105: (osx) Make Cordova OSX build successfully on AppleSilicon target.
Posted by GitBox <gi...@apache.org>.
brodybits commented on pull request #105:
URL: https://github.com/apache/cordova-osx/pull/105#issuecomment-788199103
I highly recommend that you followup on Slack and on the dev mailing list, please follow links from the footer of cordova.io or cordova.apache.org, and try again if you don't hear anything. Unfortunately the maintainers have been pretty overloaded over the past couple years.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-osx] NiklasMerz merged pull request #105: (osx) Make Cordova OSX build successfully on AppleSilicon target.
Posted by GitBox <gi...@apache.org>.
NiklasMerz merged pull request #105:
URL: https://github.com/apache/cordova-osx/pull/105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-osx] motla commented on pull request #105: (osx) Make Cordova OSX build successfully on AppleSilicon target.
Posted by GitBox <gi...@apache.org>.
motla commented on pull request #105:
URL: https://github.com/apache/cordova-osx/pull/105#issuecomment-756963261
@erisu could you please merge this one then make a release?
otherwise it is blocking compilation fail for every dev using the updated XCode....
thanks
```
cordova platform add https://github.com/bpresles/cordova-osx.git#AppleSilicon
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-osx] motla commented on pull request #105: (osx) Make Cordova OSX build successfully on AppleSilicon target.
Posted by GitBox <gi...@apache.org>.
motla commented on pull request #105:
URL: https://github.com/apache/cordova-osx/pull/105#issuecomment-756963261
@erisu could you please merge this one then make a release?
otherwise it is blocking compilation fail for every dev using the updated XCode....
thanks
```
cordova platform add https://github.com/bpresles/cordova-osx.git#AppleSilicon
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-osx] fortuna commented on pull request #105: (osx) Make Cordova OSX build successfully on AppleSilicon target.
Posted by GitBox <gi...@apache.org>.
fortuna commented on pull request #105:
URL: https://github.com/apache/cordova-osx/pull/105#issuecomment-1026472792
@bpresles are you able to merge the PR? It's been approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org