[GitHub] [druid] jihoonson commented on pull request #10308: Move tools for indexing to TaskToolbox instead of injecting them in constructor

[GitBox <gi...@apache.org>]

jihoonson commented on pull request #10308:
URL: https://github.com/apache/druid/pull/10308#issuecomment-679272060


   ```
   411 L | B(0/2)          if (toolbox.getAppenderatorsManager().shouldTaskMakeNodeAnnouncements()) {
   
   898 L                     toolbox.getChatHandlerProvider().unregister(task.getId());
   
   900 L | B(0/2)            if (toolbox.getAppenderatorsManager().shouldTaskMakeNodeAnnouncements()) {
   ```
   
   The coverage check bot complains about these lines, but [there is no change in them](https://github.com/apache/druid/pull/10308/files#diff-2512ef23844750284130758031054081R411-R900). I think it's a good idea to test node announcement in streaming ingestion with both middleManagers and Indexers, but seems better to do in a separate PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org