[jira] [Commented] (NIFI-5792) NiFi should keep the created versioned flow information in case snapshot creation failure

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676155#comment-16676155 ] 

ASF GitHub Bot commented on NIFI-5792:
--------------------------------------

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/3134

    NIFI-5792: Remember created versioned flow information

    - Before this fix, NiFi loses information about created versioned flow in case of subsequent snapshot creation failure, and NiFi API returned an error response
    - This commit makes:
      - The created versioned Flow information is stored even if subsequent snapshot creation fails
      - NiFi API to return a successful 200 response in that case, but return versioned flow status as SYNC_FAILURE with an explanation. NiFi UI shows a popup error dialog with the explanation.
      - Versioned flow status will be LOCALLY_MODIFIED if the latest version is 0.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi nifi-5792

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/3134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3134
    
----
commit 2eb5f2c42f0cbc6a793cd91b1e821c4acdd10d47
Author: Koji Kawamura <ij...@...>
Date:   2018-11-06T05:08:23Z

    NIFI-5792: Remember created versioned flow information
    
    - Before this fix, NiFi loses information about created versioned flow in case of subsequent snapshot creation failure, and NiFi API returned an error response
    - This commit makes:
      - The created versioned Flow information is stored even if subsequent snapshot creation fails
      - NiFi API to return a successful 200 response in that case, but return versioned flow status as SYNC_FAILURE with an explanation. NiFi UI shows a popup error dialog with the explanation.
      - Versioned flow status will be LOCALLY_MODIFIED if the latest version is 0.

----


> NiFi should keep the created versioned flow information in case snapshot creation failure
> -----------------------------------------------------------------------------------------
>
>                 Key: NIFI-5792
>                 URL: https://issues.apache.org/jira/browse/NIFI-5792
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: SDLC
>    Affects Versions: 1.5.0
>            Reporter: Koji Kawamura
>            Assignee: Koji Kawamura
>            Priority: Major
>
> When a user attempts to start version control for a ProcessGroup, NiFi makes two NiFi Registry API requests, one for creating a new Flow, and the other is creating a new snapshot in the registry.
> If NiFi Registry returns error for the 2nd request for some reason (e.g. Git repository is used and its local repo is in a dirty state, having uncommitted files), NiFi loses the information about the created versioned Flow, that is returned by the 1st response.
> After that happens, if a user retries starting version control for the same ProcessGroup, NiFi sends the 1st request again, to create the Flow in NiFi Registry. Then NiFi Registry returns error response because a Flow with the same name already exists in the bucket.
> NiFi should remember the created versioned Flow information in case snapshot creation failure, so that the snapshot can be committed later when the NiFi Registry side issue gets addressed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)