You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by vs...@apache.org on 2008/02/22 01:30:20 UTC

svn commit: r630055 - /maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/UpdatePluginRegistryMojo.java

Author: vsiveton
Date: Thu Feb 21 16:30:17 2008
New Revision: 630055

URL: http://svn.apache.org/viewvc?rev=630055&view=rev
Log:
o accessed directly to TrackableBase 

Modified:
    maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/UpdatePluginRegistryMojo.java

Modified: maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/UpdatePluginRegistryMojo.java
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/UpdatePluginRegistryMojo.java?rev=630055&r1=630054&r2=630055&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/UpdatePluginRegistryMojo.java (original)
+++ maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/UpdatePluginRegistryMojo.java Thu Feb 21 16:30:17 2008
@@ -27,6 +27,7 @@
 import org.apache.maven.plugin.registry.Plugin;
 import org.apache.maven.plugin.registry.PluginRegistry;
 import org.apache.maven.plugin.registry.PluginRegistryUtils;
+import org.apache.maven.plugin.registry.TrackableBase;
 import org.apache.maven.plugin.registry.io.xpp3.PluginRegistryXpp3Writer;
 import org.codehaus.plexus.util.IOUtil;
 import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
@@ -42,11 +43,11 @@
  *
  * @goal updateRegistry
  * @phase install
+ * @version $Id$
  */
 public class UpdatePluginRegistryMojo
     extends AbstractMojo
 {
-
     /**
      * Indicates whether the plugin-registry.xml is used by Maven or not
      * to manage plugin versions.
@@ -124,7 +125,7 @@
         // if we can find the plugin, but we've gotten here, the useVersion must be missing; fill it in.
         if ( plugin != null )
         {
-            if ( PluginRegistry.GLOBAL_LEVEL.equals( plugin.getSourceLevel() ) )
+            if ( TrackableBase.GLOBAL_LEVEL.equals( plugin.getSourceLevel() ) )
             {
                 // do nothing. We don't rewrite the globals, under any circumstances.
                 getLog().warn( "Cannot update registered version for plugin {" + groupId + ":" + artifactId +



Re: svn commit: r630055 - /maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/UpdatePluginRegistryMojo.java

Posted by Jason van Zyl <ja...@maven.org>.
No one uses this anymore and I turned off the registry a long time  
ago. I think before the 2.0.4 release. Not sure if this is needed at  
all anymore.

Moving toward requiring versions and no auto-update will render this  
moot as well.

On 21-Feb-08, at 4:30 PM, vsiveton@apache.org wrote:

> Author: vsiveton
> Date: Thu Feb 21 16:30:17 2008
> New Revision: 630055
>
> URL: http://svn.apache.org/viewvc?rev=630055&view=rev
> Log:
> o accessed directly to TrackableBase
>
> Modified:
>    maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/ 
> apache/maven/plugin/plugin/UpdatePluginRegistryMojo.java
>
> Modified: maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/ 
> org/apache/maven/plugin/plugin/UpdatePluginRegistryMojo.java
> URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/UpdatePluginRegistryMojo.java?rev=630055&r1=630054&r2=630055&view=diff
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/ 
> apache/maven/plugin/plugin/UpdatePluginRegistryMojo.java (original)
> +++ maven/plugin-tools/trunk/maven-plugin-plugin/src/main/java/org/ 
> apache/maven/plugin/plugin/UpdatePluginRegistryMojo.java Thu Feb 21  
> 16:30:17 2008
> @@ -27,6 +27,7 @@
> import org.apache.maven.plugin.registry.Plugin;
> import org.apache.maven.plugin.registry.PluginRegistry;
> import org.apache.maven.plugin.registry.PluginRegistryUtils;
> +import org.apache.maven.plugin.registry.TrackableBase;
> import  
> org.apache.maven.plugin.registry.io.xpp3.PluginRegistryXpp3Writer;
> import org.codehaus.plexus.util.IOUtil;
> import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
> @@ -42,11 +43,11 @@
>  *
>  * @goal updateRegistry
>  * @phase install
> + * @version $Id$
>  */
> public class UpdatePluginRegistryMojo
>     extends AbstractMojo
> {
> -
>     /**
>      * Indicates whether the plugin-registry.xml is used by Maven or  
> not
>      * to manage plugin versions.
> @@ -124,7 +125,7 @@
>         // if we can find the plugin, but we've gotten here, the  
> useVersion must be missing; fill it in.
>         if ( plugin != null )
>         {
> -            if  
> ( PluginRegistry.GLOBAL_LEVEL.equals( plugin.getSourceLevel() ) )
> +            if  
> ( TrackableBase.GLOBAL_LEVEL.equals( plugin.getSourceLevel() ) )
>             {
>                 // do nothing. We don't rewrite the globals, under  
> any circumstances.
>                 getLog().warn( "Cannot update registered version for  
> plugin {" + groupId + ":" + artifactId +
>
>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
jason at sonatype dot com
----------------------------------------------------------

Three people can keep a secret provided two of them are dead.

-- Unknown 




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org