You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Alex Deparvu (JIRA)" <ji...@apache.org> on 2018/09/11 08:08:00 UTC

[jira] [Created] (OAK-7746) Refactor TypePredicate location and usage

Alex Deparvu created OAK-7746:
---------------------------------

             Summary: Refactor TypePredicate location and usage
                 Key: OAK-7746
                 URL: https://issues.apache.org/jira/browse/OAK-7746
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: core, store-spi
            Reporter: Alex Deparvu
            Assignee: Alex Deparvu


In the context of modularization I would like to move the TypePredicate class to a dedicated package in store-spi (due to dependency on NodeState class). See [0] for some more reasoning.
Proposed patch [1].

I'm concerned about the Predicate (guava) and Predicate (jdk) usage. I think in a later guava release they will have Predicate extend the jdk version and advise people to start using the latter, so I think the patch is taking a step in a good direction, but would like to confirm this with others.

Re. backwards compatibility, even if some packages are not exported (like observation) I did my best to deprecate and add newer alternatives. If this is not needed I can just drop the old methods.



[0] https://issues.apache.org/jira/browse/OAK-7499?focusedCommentId=16486800&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16486800

[1] https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:type-predicate



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)