You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "William Tam (JIRA)" <ji...@apache.org> on 2010/08/31 22:20:55 UTC
[jira] Updated: (CXF-2965) WrapperClassInInterceptor should check
for null wrapperClass
[ https://issues.apache.org/jira/browse/CXF-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Tam updated CXF-2965:
-----------------------------
Description:
I'd suggest to add null pointer check.
{code}
Index: rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
===================================================================
--- rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java (revision 34)
+++ rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java (working copy)
@@ -108,7 +108,7 @@
MessagePartInfo wrapperPart = wrappedMessageInfo.getMessagePart(0);
Class<?> wrapperClass = wrapperPart.getTypeClass();
Object wrappedObject = lst.get(wrapperPart.getIndex());
- if (!wrapperClass.isInstance(wrappedObject)) {
+ if (wrapperClass != null && !wrapperClass.isInstance(wrappedObject)) {
wrappedObject = null;
wrapperPart = null;
wrapperClass = null;
{code}
was:
Index: rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
===================================================================
--- rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java (revision 34)
+++ rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java (working copy)
@@ -108,7 +108,7 @@
MessagePartInfo wrapperPart = wrappedMessageInfo.getMessagePart(0);
Class<?> wrapperClass = wrapperPart.getTypeClass();
Object wrappedObject = lst.get(wrapperPart.getIndex());
- if (!wrapperClass.isInstance(wrappedObject)) {
+ if (wrapperClass != null && !wrapperClass.isInstance(wrappedObject)) {
wrappedObject = null;
wrapperPart = null;
wrapperClass = null;
> WrapperClassInInterceptor should check for null wrapperClass
> ------------------------------------------------------------
>
> Key: CXF-2965
> URL: https://issues.apache.org/jira/browse/CXF-2965
> Project: CXF
> Issue Type: Bug
> Components: JAX-WS Runtime
> Reporter: William Tam
> Fix For: 2.3, 2.2.11
>
>
> I'd suggest to add null pointer check.
> {code}
> Index: rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java
> ===================================================================
> --- rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java (revision 34)
> +++ rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WrapperClassInInterceptor.java (working copy)
> @@ -108,7 +108,7 @@
> MessagePartInfo wrapperPart = wrappedMessageInfo.getMessagePart(0);
> Class<?> wrapperClass = wrapperPart.getTypeClass();
> Object wrappedObject = lst.get(wrapperPart.getIndex());
> - if (!wrapperClass.isInstance(wrappedObject)) {
> + if (wrapperClass != null && !wrapperClass.isInstance(wrappedObject)) {
> wrappedObject = null;
> wrapperPart = null;
> wrapperClass = null;
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.