You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/25 04:54:50 UTC
[GitHub] [airflow] rino0601 opened a new pull request, #25270: Add werkzeug limitation until flask-login will handle it
rino0601 opened a new pull request, #25270:
URL: https://github.com/apache/airflow/pull/25270
related: #25269
werkzeoug 2.2.0 breaks flask-login.
This will be problem who doesn't use `pip --constraint`
The breaks caused by https://github.com/pallets/werkzeug/pull/2433 and flask-login already knows it https://github.com/maxcountryman/flask-login/issues/686
I think we need werkzeug<2.2 limitation until flask_login are handle it
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] rino0601 commented on pull request #25270: Add werkzeug limitation until flask-login will handle it
Posted by GitBox <gi...@apache.org>.
rino0601 commented on PR #25270:
URL: https://github.com/apache/airflow/pull/25270#issuecomment-1193588948
@uranusjr thanks for fast feedback
I just added comment as you requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25270: Add werkzeug limitation until flask-login will handle it
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25270:
URL: https://github.com/apache/airflow/pull/25270#issuecomment-1193748703
Thanks @rino0601 ! - I was just looking at some early warnings from some of our PRs failing, resulting from this error !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #25270: Add werkzeug limitation until flask-login will handle it
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #25270:
URL: https://github.com/apache/airflow/pull/25270#issuecomment-1193583283
Could you add a comment above the line (just repeat the PR description would do) so we can more easily understand why the upper bound is there afterwards?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25270: Add werkzeug limitation until flask-login will handle it
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25270:
URL: https://github.com/apache/airflow/pull/25270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Kinceo1 commented on pull request #25270: Add werkzeug limitation until flask-login will handle it
Posted by GitBox <gi...@apache.org>.
Kinceo1 commented on PR #25270:
URL: https://github.com/apache/airflow/pull/25270#issuecomment-1193584600
Great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25270: Add werkzeug limitation until flask-login will handle it
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25270:
URL: https://github.com/apache/airflow/pull/25270#issuecomment-1193758570
I also commented in the issue https://github.com/maxcountryman/flask-login/issues/686#issuecomment-1193755779 - this is I thin 3rd time over 3 years that we experienced some Werkzeug + Flask Login compatibilty issues and I think it would be great if maintainers of those two project will get to cooperat a bit more to make sure they are not breaking other's code.
I'd appreciate some encouragement there, maybe we can improve the world a bit aroun us :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org