[jira] Commented: (DIRSHARED-26) Need a clone function for filters

["Emmanuel Lecharny (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DIRSHARED-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675606#action_12675606 ] 

Emmanuel Lecharny commented on DIRSHARED-26:
--------------------------------------------

Looking at the patch atm. Some remarks :

- AndNode : the public AndNode( ExprNode... childList ) method has been removed. I think it's by mistake
- Some methods don't have Javadoc
- Clone implementation should always call super.clone() instead of creating new instances of the cloned object.
- Use spaces, no tabs. (more specifcially, follow our coding convention if possible)

I will try to get the patch injected this week-end. Thanks !

> Need a clone function for filters
> ---------------------------------
>
>                 Key: DIRSHARED-26
>                 URL: https://issues.apache.org/jira/browse/DIRSHARED-26
>             Project: Directory Shared
>          Issue Type: New Feature
>    Affects Versions: 0.9.13
>            Reporter: Steve hammond
>            Assignee: Emmanuel Lecharny
>         Attachments: filterClone.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> We should have a clone function.  This will make an entire copy of a filter into a new memory space.  This clone can be altered without changing the original.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.