You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Jianbin Wei (JIRA)" <ji...@apache.org> on 2012/09/28 18:33:07 UTC

[jira] [Created] (HADOOP-8865) log warn when loading deprecated properties

Jianbin Wei created HADOOP-8865:
-----------------------------------

             Summary: log warn when loading deprecated properties
                 Key: HADOOP-8865
                 URL: https://issues.apache.org/jira/browse/HADOOP-8865
             Project: Hadoop Common
          Issue Type: Improvement
            Reporter: Jianbin Wei


We need to log warn when loading deprecated properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8865) log warn when loading deprecated properties

Posted by "Jianbin Wei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jianbin Wei updated HADOOP-8865:
--------------------------------

          Component/s: conf
    Affects Version/s: 3.0.0
        Fix Version/s: 3.0.0
    
> log warn when loading deprecated properties
> -------------------------------------------
>
>                 Key: HADOOP-8865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8865
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Jianbin Wei
>             Fix For: 3.0.0
>
>
> We need to log warn when loading deprecated properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8865) log warn when loading deprecated properties

Posted by "Jianbin Wei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jianbin Wei updated HADOOP-8865:
--------------------------------

    Attachment: HADOOP-8865.patch
    
> log warn when loading deprecated properties
> -------------------------------------------
>
>                 Key: HADOOP-8865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8865
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Jianbin Wei
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-8865.patch
>
>
> We need to log warn when loading deprecated properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8865) log warn when loading deprecated properties

Posted by "Jianbin Wei (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466423#comment-13466423 ] 

Jianbin Wei commented on HADOOP-8865:
-------------------------------------

Harsh,

Do you have any idea why the org.apache.hadoop.ha.TestZKFailoverController fails due to timeout?  I saw that the unit test also failed in HADOOP-8386 but the patch is accepted.  Should the tests be disabled?

https://issues.apache.org/jira/browse/HADOOP-8386?focusedCommentId=13466016&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13466016

Thanks.

Jianbin
                
> log warn when loading deprecated properties
> -------------------------------------------
>
>                 Key: HADOOP-8865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8865
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Jianbin Wei
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-8865.patch, HADOOP-8865.patch, HADOOP-8865.patch
>
>
> We need to log warn when loading deprecated properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8865) log warn when loading deprecated properties

Posted by "Jianbin Wei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jianbin Wei updated HADOOP-8865:
--------------------------------

    Status: Patch Available  (was: Open)
    
> log warn when loading deprecated properties
> -------------------------------------------
>
>                 Key: HADOOP-8865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8865
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Jianbin Wei
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-8865.patch, HADOOP-8865.patch
>
>
> We need to log warn when loading deprecated properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8865) log warn when loading deprecated properties

Posted by "Jianbin Wei (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465717#comment-13465717 ] 

Jianbin Wei commented on HADOOP-8865:
-------------------------------------

Such log warn can

(1) avoid potential use of deprecated properties in code (https://issues.apache.org/jira/browse/MAPREDUCE-4692)
(2) speedup the deprecation for further improvement in the future
                
> log warn when loading deprecated properties
> -------------------------------------------
>
>                 Key: HADOOP-8865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8865
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Jianbin Wei
>             Fix For: 3.0.0
>
>
> We need to log warn when loading deprecated properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8865) log warn when loading deprecated properties

Posted by "Jianbin Wei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jianbin Wei updated HADOOP-8865:
--------------------------------

    Attachment: HADOOP-8865.patch
    
> log warn when loading deprecated properties
> -------------------------------------------
>
>                 Key: HADOOP-8865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8865
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Jianbin Wei
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-8865.patch, HADOOP-8865.patch
>
>
> We need to log warn when loading deprecated properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8865) log warn when loading deprecated properties

Posted by "Harsh J (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465736#comment-13465736 ] 

Harsh J commented on HADOOP-8865:
---------------------------------

Hi Jianbin,

If am not mistaken, Configuration class already does log warnings when a deprecated property string is used. Are you talking of something else?
                
> log warn when loading deprecated properties
> -------------------------------------------
>
>                 Key: HADOOP-8865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8865
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Jianbin Wei
>             Fix For: 3.0.0
>
>
> We need to log warn when loading deprecated properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8865) log warn when loading deprecated properties

Posted by "Jianbin Wei (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465742#comment-13465742 ] 

Jianbin Wei commented on HADOOP-8865:
-------------------------------------

Yes I saw the code and it intends to do that only when the properties is being set but not being loaded.

Following is some log after my initial change

{{[ ../hadoop-3.0.0-SNAPSHOT] ⚡ sbin/start-dfs.sh
12/09/28 09:54:03 WARN (Configuration.java:warnOnceIfDeprecated(826)) conf.Configuration: io.bytes.per.checksum is deprecated. Instead, use dfs.bytes-per-checksum in core-default.xml
12/09/28 09:54:03 WARN (Configuration.java:warnOnceIfDeprecated(826)) conf.Configuration: fs.default.name is deprecated. Instead, use fs.defaultFS in core-default.xml
12/09/28 09:54:03 WARN (Configuration.java:warnOnceIfDeprecated(826)) conf.Configuration: io.bytes.per.checksum is deprecated. Instead, use dfs.bytes-per-checksum in core-default.xml
12/09/28 09:54:03 WARN (Configuration.java:warnOnceIfDeprecated(826)) conf.Configuration: fs.default.name is deprecated. Instead, use fs.defaultFS in core-default.xml
12/09/28 09:54:03 WARN (Configuration.java:warnOnceIfDeprecated(826)) conf.Configuration: io.bytes.per.checksum is deprecated. Instead, use dfs.bytes-per-checksum in core-default.xml}}
                
> log warn when loading deprecated properties
> -------------------------------------------
>
>                 Key: HADOOP-8865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8865
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Jianbin Wei
>             Fix For: 3.0.0
>
>
> We need to log warn when loading deprecated properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8865) log warn when loading deprecated properties

Posted by "Jianbin Wei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jianbin Wei updated HADOOP-8865:
--------------------------------

    Status: Open  (was: Patch Available)
    
> log warn when loading deprecated properties
> -------------------------------------------
>
>                 Key: HADOOP-8865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8865
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Jianbin Wei
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-8865.patch, HADOOP-8865.patch
>
>
> We need to log warn when loading deprecated properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8865) log warn when loading deprecated properties

Posted by "Jianbin Wei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jianbin Wei updated HADOOP-8865:
--------------------------------

    Status: Patch Available  (was: Open)
    
> log warn when loading deprecated properties
> -------------------------------------------
>
>                 Key: HADOOP-8865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8865
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Jianbin Wei
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-8865.patch
>
>
> We need to log warn when loading deprecated properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8865) log warn when loading deprecated properties

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466153#comment-13466153 ] 

Hadoop QA commented on HADOOP-8865:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12547099/HADOOP-8865.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.ha.TestZKFailoverController

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1546//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1546//console

This message is automatically generated.
                
> log warn when loading deprecated properties
> -------------------------------------------
>
>                 Key: HADOOP-8865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8865
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Jianbin Wei
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-8865.patch, HADOOP-8865.patch
>
>
> We need to log warn when loading deprecated properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8865) log warn when loading deprecated properties

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466421#comment-13466421 ] 

Hadoop QA commented on HADOOP-8865:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12547148/HADOOP-8865.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.ha.TestZKFailoverController

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1548//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1548//console

This message is automatically generated.
                
> log warn when loading deprecated properties
> -------------------------------------------
>
>                 Key: HADOOP-8865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8865
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Jianbin Wei
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-8865.patch, HADOOP-8865.patch, HADOOP-8865.patch
>
>
> We need to log warn when loading deprecated properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8865) log warn when loading deprecated properties

Posted by "Jianbin Wei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jianbin Wei updated HADOOP-8865:
--------------------------------

    Status: Open  (was: Patch Available)
    
> log warn when loading deprecated properties
> -------------------------------------------
>
>                 Key: HADOOP-8865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8865
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Jianbin Wei
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-8865.patch, HADOOP-8865.patch, HADOOP-8865.patch
>
>
> We need to log warn when loading deprecated properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8865) log warn when loading deprecated properties

Posted by "Jianbin Wei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jianbin Wei updated HADOOP-8865:
--------------------------------

    Attachment: HADOOP-8865.patch
    
> log warn when loading deprecated properties
> -------------------------------------------
>
>                 Key: HADOOP-8865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8865
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Jianbin Wei
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-8865.patch, HADOOP-8865.patch, HADOOP-8865.patch
>
>
> We need to log warn when loading deprecated properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8865) log warn when loading deprecated properties

Posted by "Jianbin Wei (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jianbin Wei updated HADOOP-8865:
--------------------------------

    Status: Patch Available  (was: Open)
    
> log warn when loading deprecated properties
> -------------------------------------------
>
>                 Key: HADOOP-8865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8865
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Jianbin Wei
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-8865.patch, HADOOP-8865.patch, HADOOP-8865.patch
>
>
> We need to log warn when loading deprecated properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8865) log warn when loading deprecated properties

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466125#comment-13466125 ] 

Hadoop QA commented on HADOOP-8865:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12547094/HADOOP-8865.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.conf.TestConfiguration

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1545//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1545//console

This message is automatically generated.
                
> log warn when loading deprecated properties
> -------------------------------------------
>
>                 Key: HADOOP-8865
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8865
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0
>            Reporter: Jianbin Wei
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-8865.patch
>
>
> We need to log warn when loading deprecated properties. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira