You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/06 12:43:31 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5426: net/local: Rename NET_LOCAL_PATH_PREFIX to NET_LOCAL_VFS_PATH
xiaoxiang781216 opened a new pull request #5426:
URL: https://github.com/apache/incubator-nuttx/pull/5426
## Summary
align with other similar config which suffix with _VFS_PATH. See: https://github.com/apache/incubator-nuttx/pull/5422
## Impact
Minor, since nobody change the default setting.
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5426: net/local: Rename NET_LOCAL_PATH_PREFIX to NET_LOCAL_VFS_PATH
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5426:
URL: https://github.com/apache/incubator-nuttx/pull/5426#issuecomment-1030853862
> > Is this a breaking change?
>
> Why? no body set CONFIG_NET_LOCAL_PATH_PREFIX in defconfig to other value, I think.
In NuttX repos I think nobody, but we do not know about all user apps. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5426: net/local: Rename NET_LOCAL_PATH_PREFIX to NET_LOCAL_VFS_PATH
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5426:
URL: https://github.com/apache/incubator-nuttx/pull/5426#issuecomment-1030844166
> Is this a breaking change?
Why? no body set CONFIG_NET_LOCAL_PATH_PREFIX in defconfig to other value, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5426: net/local: Rename NET_LOCAL_PATH_PREFIX to NET_LOCAL_VFS_PATH
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5426:
URL: https://github.com/apache/incubator-nuttx/pull/5426#issuecomment-1030834492
Is this a breaking change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5426: net/local: Rename NET_LOCAL_PATH_PREFIX to NET_LOCAL_VFS_PATH
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #5426:
URL: https://github.com/apache/incubator-nuttx/pull/5426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5426: net/local: Rename NET_LOCAL_PATH_PREFIX to NET_LOCAL_VFS_PATH
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #5426:
URL: https://github.com/apache/incubator-nuttx/pull/5426#issuecomment-1030856882
It's the implementation detail that Unix domain socket use the fifo internally. I believe that most user except the network subsystem expert don't know this fact. Also, we have discussed internally several time to remove this dependence to fix some important problem we found but is very very hard to fix in the current design.
BTW, the breaking level is same as #5422 and #5423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5426: net/local: Rename NET_LOCAL_PATH_PREFIX to NET_LOCAL_VFS_PATH
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5426:
URL: https://github.com/apache/incubator-nuttx/pull/5426#issuecomment-1030856882
It's the implementation detail that Unix domain socket use the fifo internally. I believe that most user except the network subsystem expert don't know this fact. Also, we have discussed internally several time to remove this dependence to fix some important problem we found but is very very hard to fix in the current design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5426: net/local: Rename NET_LOCAL_PATH_PREFIX to NET_LOCAL_VFS_PATH
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5426:
URL: https://github.com/apache/incubator-nuttx/pull/5426#issuecomment-1030863879
I will try to learn more about when "breaking change" label should be introduced and when not. I'm just thinking that if the config option is renamed then user defconfigs might be broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5426: net/local: Rename NET_LOCAL_PATH_PREFIX to NET_LOCAL_VFS_PATH
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5426:
URL: https://github.com/apache/incubator-nuttx/pull/5426#issuecomment-1030857719
Anyway, I mark the PR with "breaking change" label to help the documentation later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on pull request #5426: net/local: Rename NET_LOCAL_PATH_PREFIX to NET_LOCAL_VFS_PATH
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on pull request #5426:
URL: https://github.com/apache/incubator-nuttx/pull/5426#issuecomment-1030864056
Any time we rename a Kconfig that has existed in a released tarball, it is potentially a breaking change to downstream users. I don't know about this specific change but I am just commenting on the "breaking change" label. I think it's a good idea to keep that label here and make sure we mention it in the release notes for the next version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org