[GitHub] [netbeans] mbien commented on a change in pull request #3278: Build Java cluster on JDK17

[GitBox <gi...@apache.org>]

mbien commented on a change in pull request #3278:
URL: https://github.com/apache/netbeans/pull/3278#discussion_r759624899



##########
File path: harness/apisupport.harness/nbproject/project.properties
##########
@@ -16,7 +16,8 @@
 # under the License.
 
 javac.compilerargs=-Xlint -Xlint:-serial
-javac.source=1.6
+javac.source=1.8
+javac.target=1.8

Review comment:
       ok. but it doesn't hurt right? does everything use the same build xml which has this functionality? having source and target at different values can cause trouble if its missed somewhere. (ultimately we should aim to use --release in distant future)
   
   i can remove it if you prefer it gone.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists