You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/08/05 22:50:46 UTC
Review Request 24338: Flume service should be in STARTED state when no
agents configured
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24338/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi and Sid Wagle.
Bugs: AMBARI-6749
https://issues.apache.org/jira/browse/AMBARI-6749
Repository: ambari
Description
-------
When no agents are defined, the service state for FLUME should be STARTED and not INSTALLED. This value is calculated as part of the python status for each host component. Since there's only 1 component (FLUME_HANDLER), it's up to the python code to know that no agents means that the FLUME_HANDLER component should be in a STARTED state.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py c29dd93
ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py f421bf5
Diff: https://reviews.apache.org/r/24338/diff/
Testing
-------
Manually verified that no agents still leaves FLUME in a STARTED state. When FLUME is STARTED and all agents are killed, FLUME will correctly transition into INSTALLED.
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:19.307s
[INFO] Finished at: Tue Aug 05 16:48:07 EDT 2014
[INFO] Final Memory: 21M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley
Re: Review Request 24338: Flume service should be in STARTED state when no
agents configured
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24338/#review49656
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Aug. 5, 2014, 8:50 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24338/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 8:50 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Sid Wagle.
>
>
> Bugs: AMBARI-6749
> https://issues.apache.org/jira/browse/AMBARI-6749
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When no agents are defined, the service state for FLUME should be STARTED and not INSTALLED. This value is calculated as part of the python status for each host component. Since there's only 1 component (FLUME_HANDLER), it's up to the python code to know that no agents means that the FLUME_HANDLER component should be in a STARTED state.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py c29dd93
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py f421bf5
>
> Diff: https://reviews.apache.org/r/24338/diff/
>
>
> Testing
> -------
>
> Manually verified that no agents still leaves FLUME in a STARTED state. When FLUME is STARTED and all agents are killed, FLUME will correctly transition into INSTALLED.
>
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:19.307s
> [INFO] Finished at: Tue Aug 05 16:48:07 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 24338: Flume service should be in STARTED state when no
agents configured
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24338/#review49640
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Aug. 5, 2014, 4:50 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24338/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 4:50 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Sid Wagle.
>
>
> Bugs: AMBARI-6749
> https://issues.apache.org/jira/browse/AMBARI-6749
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When no agents are defined, the service state for FLUME should be STARTED and not INSTALLED. This value is calculated as part of the python status for each host component. Since there's only 1 component (FLUME_HANDLER), it's up to the python code to know that no agents means that the FLUME_HANDLER component should be in a STARTED state.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py c29dd93
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py f421bf5
>
> Diff: https://reviews.apache.org/r/24338/diff/
>
>
> Testing
> -------
>
> Manually verified that no agents still leaves FLUME in a STARTED state. When FLUME is STARTED and all agents are killed, FLUME will correctly transition into INSTALLED.
>
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:19.307s
> [INFO] Finished at: Tue Aug 05 16:48:07 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>