You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2016/02/10 19:54:22 UTC
Re: Review Request 43425: [preview] Component should support a desired
version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 8:54 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Summary (updated)
-----------------
[preview] Component should support a desired version
Bugs: AMBARI-14996
https://issues.apache.org/jira/browse/AMBARI-14996
Repository: ambari
Description (updated)
-------
When performing an upgrade, we need to specify that a component's desired version is getting changed.
Going to open additional jiras for TODOs in code
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 210fe17
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java db8c079
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java d2d1b42
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
Diff: https://reviews.apache.org/r/43425/diff/
Testing (updated)
-------
Pending E2E RU/EU upgrades/downgrades on live cluster
Did not work on unit tests yet
Thanks,
Dmitro Lisnichenko
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Feb. 11, 2016, 3:27 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java, line 145
> > <https://reviews.apache.org/r/43425/diff/2/?file=1239691#file1239691line145>
> >
> > Failed?
I was in doubt regarding removing FAILED state for host components, but decided to follow agreed component version design google doc. I tried to minimize host component version handling required, but thinking once more keeping FAILED seems to be profitable in terms of clear component state
Will add FAILED back. Let's discuss on call how/when FAILED state should be transitioned to other states
> On Feb. 11, 2016, 3:27 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, line 1174
> > <https://reviews.apache.org/r/43425/diff/2/?file=1239683#file1239683line1174>
> >
> > This should be in the isVersionAdvertised() block, and should anything not advertising its version be marked with UNKNOWN?
great catch. I was moving if out of internal loop, and accidentally left that out
> On Feb. 11, 2016, 3:27 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, lines 1167-1168
> > <https://reviews.apache.org/r/43425/diff/2/?file=1239683#file1239683line1167>
> >
> > Use an Entry<Service, Set<ServiceComponent>> iterator here.
good idea
> On Feb. 11, 2016, 3:27 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, lines 837-839
> > <https://reviews.apache.org/r/43425/diff/2/?file=1239683#file1239683line837>
> >
> > Actually, we'll determine this from the repo_version entry. We can discuss.
what do you mean?
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review118858
-----------------------------------------------------------
On Feb. 10, 2016, 8:55 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 8:55 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed.
>
> Going to open additional jiras for TODOs in code
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 210fe17
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java db8c079
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java d2d1b42
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> Pending E2E RU/EU upgrades/downgrades on live cluster
>
> Did not work on unit tests yet
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review118858
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java (line 619)
<https://reviews.apache.org/r/43425/#comment180165>
If we're in an upgrade, why not FAILED? If NOT in an upgrade, then yes, VERSION_MISMATCH.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java (lines 837 - 839)
<https://reviews.apache.org/r/43425/#comment180166>
Actually, we'll determine this from the repo_version entry. We can discuss.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java (lines 1167 - 1168)
<https://reviews.apache.org/r/43425/#comment180167>
Use an Entry<Service, Set<ServiceComponent>> iterator here.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java (line 1174)
<https://reviews.apache.org/r/43425/#comment180168>
This should be in the isVersionAdvertised() block, and should anything not advertising its version be marked with UNKNOWN?
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java (line 211)
<https://reviews.apache.org/r/43425/#comment180170>
FAILED still seems valid in RU/EU case
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java (line 145)
<https://reviews.apache.org/r/43425/#comment180171>
Failed?
- Nate Cole
On Feb. 10, 2016, 1:55 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 1:55 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed.
>
> Going to open additional jiras for TODOs in code
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 210fe17
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java db8c079
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java d2d1b42
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> Pending E2E RU/EU upgrades/downgrades on live cluster
>
> Did not work on unit tests yet
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review118870
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java (lines 791 - 794)
<https://reviews.apache.org/r/43425/#comment180184>
With only 2 lines, can we get rid of this method and just invoke the event publisher directly?
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java (line 1171)
<https://reviews.apache.org/r/43425/#comment180186>
I dislike how we have 2 enums to actually track the same thing:
UpgradeState
RepositoryVersionState
Having the RepositoryVersionState as "UPGRADING" is kind of weird since you're not upgrading the repo; you're upgrading to the repo.
But even worse is that we have this other enum, UpgradeState, with values like IN_PROGRESS.
My vote is to actually change our code to eliminate 1 enum entirely.
It seems like the values from RepositoryVersionState are the ones we want (UPGRADING, UPGRADED) but we should call the enum UpgradeState to make it clear.
Also, can we get rid of UpgradeState.PENDING since it makes zero sense.
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java (line 104)
<https://reviews.apache.org/r/43425/#comment180187>
If you're upgrading, shouldn't this be something like UPGRADED (see my earlier comment about too many enums and what we can do to make it clearer). NONE, to me, means nothing is happening, which is not the case.
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java (lines 1790 - 1794)
<https://reviews.apache.org/r/43425/#comment180188>
Let's also update the documentation to reflect that this only happens during an upgrade.
- Jonathan Hurley
On Feb. 10, 2016, 1:55 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 1:55 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed.
>
> Going to open additional jiras for TODOs in code
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 210fe17
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java db8c079
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java d2d1b42
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> Pending E2E RU/EU upgrades/downgrades on live cluster
>
> Did not work on unit tests yet
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Feb. 19, 2016, midnight, Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java, lines 208-209
> > <https://reviews.apache.org/r/43425/diff/7/?file=1254843#file1254843line208>
> >
> > If there is a version mismatch, should orchestration be trying to get them to match? Not sure why we would exclude them here.
I think VERSION_MISMATCH is similar to MM and requires manual intervention
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review119726
-----------------------------------------------------------
On Feb. 18, 2016, 8:39 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 8:39 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 8c626f5
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f8e4ee1
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e3ce96c
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 5d47c28
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 263004f
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 80feca5
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3e372f5
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d513448
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> Pending E2E RU/EU upgrades/downgrades on live cluster
>
> Did not work on unit tests yet.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Feb. 19, 2016, midnight, Nate Cole wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql, line 171
> > <https://reviews.apache.org/r/43425/diff/7/?file=1254856#file1254856line171>
> >
> > not sure if NOT NULL is appropriate here. what happens with the new Ambari and this information isn't available? Comment applies to all these .sql files.
we may choose to initialize it in upgrade catalog to current version value
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review119726
-----------------------------------------------------------
On Feb. 18, 2016, 8:39 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 8:39 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 8c626f5
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f8e4ee1
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e3ce96c
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 5d47c28
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 263004f
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 80feca5
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3e372f5
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d513448
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> Pending E2E RU/EU upgrades/downgrades on live cluster
>
> Did not work on unit tests yet.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review119726
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java (line 42)
<https://reviews.apache.org/r/43425/#comment181067>
no * imports, and statics are typically declared above the non-static imports
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java (lines 208 - 209)
<https://reviews.apache.org/r/43425/#comment181068>
If there is a version mismatch, should orchestration be trying to get them to match? Not sure why we would exclude them here.
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java (line 22)
<https://reviews.apache.org/r/43425/#comment181069>
no * imports
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java (lines 1382 - 1383)
<https://reviews.apache.org/r/43425/#comment181070>
may as well fix the log string to use {} as well while we're here :)
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java (line 35)
<https://reviews.apache.org/r/43425/#comment181071>
no *
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql (line 171)
<https://reviews.apache.org/r/43425/#comment181072>
not sure if NOT NULL is appropriate here. what happens with the new Ambari and this information isn't available? Comment applies to all these .sql files.
- Nate Cole
On Feb. 18, 2016, 1:39 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 1:39 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 8c626f5
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f8e4ee1
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e3ce96c
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 5d47c28
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 263004f
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 80feca5
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3e372f5
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d513448
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> Pending E2E RU/EU upgrades/downgrades on live cluster
>
> Did not work on unit tests yet.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Feb. 19, 2016, 1:29 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql, line 782
> > <https://reviews.apache.org/r/43425/diff/8/?file=1259342#file1259342line782>
> >
> > ambari. prefix here on both table names
Actually, I don't think that will work either since upgrades is declared lower; you'll need to place this after the "`create table upgrade`" or move the upgrade table somewhere earlier.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review119911
-----------------------------------------------------------
On Feb. 19, 2016, 12:36 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 12:36 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 33b496f
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3ec982a
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 026efea
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql fb9889d
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 3cc7516
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql a5bfdc2
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8e5b2f8
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7b26f23
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> Pending E2E RU/EU upgrades/downgrades on live cluster
>
> Did not work on unit tests yet.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review119911
-----------------------------------------------------------
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql (line 782)
<https://reviews.apache.org/r/43425/#comment181307>
ambari. prefix here on both table names
- Jonathan Hurley
On Feb. 19, 2016, 12:36 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 12:36 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 33b496f
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3ec982a
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 026efea
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql fb9889d
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 3cc7516
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql a5bfdc2
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8e5b2f8
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7b26f23
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> Pending E2E RU/EU upgrades/downgrades on live cluster
>
> Did not work on unit tests yet.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: Component should support a desired version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Feb. 22, 2016, 9 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, line 1590
> > <https://reviews.apache.org/r/43425/diff/9/?file=1264370#file1264370line1590>
> >
> > Does this now need to be transacitonal since it's affecting multiple entities? Hard to tell from ReviewBoard if a method invocation this one already has started a transaction.
I think no
> On Feb. 22, 2016, 9 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql, line 171
> > <https://reviews.apache.org/r/43425/diff/8-9/?file=1259340#file1259340line171>
> >
> > Oracle needs `DEFAULT` before `NOT NULL`
You are right, missed that
> On Feb. 22, 2016, 9 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql, line 784
> > <https://reviews.apache.org/r/43425/diff/8-9/?file=1259342#file1259342line784>
> >
> > This won't work unless the `upgrade` table is declared before this statement, which it's not.
> >
> > Also, I don't see this FK relationship in the other SQL files.
Thanks, good catch. Moved table creations higher
Regarding FK relationship - in other files, it looks like ALTER TABLE clusters ADD CONSTRAINT FK_clusters_upgrade_id FOREIGN KEY (upgrade_id) REFERENCES upgrade (upgrade_id);
> On Feb. 22, 2016, 9 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java, lines 107-109
> > <https://reviews.apache.org/r/43425/diff/9/?file=1264374#file1264374line107>
> >
> > Let's add a comment as to why this is required; since none of the entities for the request are actually persisted yet, JPA ordering could allow foreign key entities to be created after this statement.
done
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review120174
-----------------------------------------------------------
On Feb. 22, 2016, 8:46 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 8:46 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 860ba88
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 06f6ac1
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 519e4e6
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java dcb7cf6
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java eca911d
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 07addfc
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql bd7755c
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ac1c5d7
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4ed3a19
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5d7be25
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql c032b8f
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6a6b77b
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 43419c1
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 992150c
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> EU/RU seems to work
> Unit tests pass with ignored failing tests (will create a jira)
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: Component should support a desired version
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review120174
-----------------------------------------------------------
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql (line 171)
<https://reviews.apache.org/r/43425/#comment181574>
Oracle needs `DEFAULT` before `NOT NULL`
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql (line 784)
<https://reviews.apache.org/r/43425/#comment181576>
This won't work unless the `upgrade` table is declared before this statement, which it's not.
Also, I don't see this FK relationship in the other SQL files.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java (line 1590)
<https://reviews.apache.org/r/43425/#comment181570>
Does this now need to be transacitonal since it's affecting multiple entities? Hard to tell from ReviewBoard if a method invocation this one already has started a transaction.
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java (lines 107 - 109)
<https://reviews.apache.org/r/43425/#comment181571>
Let's add a comment as to why this is required; since none of the entities for the request are actually persisted yet, JPA ordering could allow foreign key entities to be created after this statement.
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java (line 92)
<https://reviews.apache.org/r/43425/#comment181573>
Can we make this `State.UNKNOWN.toString()`
- Jonathan Hurley
On Feb. 22, 2016, 1:46 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 1:46 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 860ba88
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 06f6ac1
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 519e4e6
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java dcb7cf6
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java eca911d
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 07addfc
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql bd7755c
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ac1c5d7
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4ed3a19
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5d7be25
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql c032b8f
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6a6b77b
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 43419c1
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 992150c
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> EU/RU seems to work
> Unit tests pass with ignored failing tests (will create a jira)
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: Component should support a desired version
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review120198
-----------------------------------------------------------
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql (lines 761 - 802)
<https://reviews.apache.org/r/43425/#comment181624>
OK, that works for this SQL file, but what about the other 6 that we have.
- Jonathan Hurley
On Feb. 22, 2016, 2:29 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 2:29 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 860ba88
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 06f6ac1
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 519e4e6
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java dcb7cf6
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java eca911d
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 07addfc
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql bd7755c
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ac1c5d7
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4ed3a19
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5d7be25
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql c032b8f
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6a6b77b
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 43419c1
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 992150c
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> EU/RU seems to work
> Unit tests pass with ignored failing tests (will create a jira)
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: Component should support a desired version
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review120308
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Feb. 23, 2016, 5:46 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 5:46 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 860ba88
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 06f6ac1
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 519e4e6
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java dcb7cf6
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java eca911d
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 07addfc
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql bd7755c
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ac1c5d7
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4ed3a19
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5d7be25
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql c032b8f
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6a6b77b
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 43419c1
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 992150c
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> EU/RU seems to work
> Unit tests pass with ignored failing tests (will create a jira)
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: Component should support a desired version
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review120312
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Feb. 23, 2016, 9:14 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 9:14 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 860ba88
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 06f6ac1
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 519e4e6
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java dcb7cf6
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java eca911d
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 07addfc
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql bd7755c
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ac1c5d7
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4ed3a19
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5d7be25
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql c032b8f
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6a6b77b
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 43419c1
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 992150c
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> EU/RU seems to work
> Running all unit tests
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: Component should support a desired version
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review120313
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Feb. 23, 2016, 9:14 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 9:14 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 860ba88
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 06f6ac1
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 519e4e6
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java dcb7cf6
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java eca911d
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 07addfc
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql bd7755c
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ac1c5d7
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4ed3a19
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5d7be25
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql c032b8f
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6a6b77b
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 43419c1
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 992150c
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> EU/RU seems to work
> Running all unit tests
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: Component should support a desired version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review120317
-----------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [3.118s]
[INFO] Ambari Metrics Common ............................. SUCCESS [2.049s]
[INFO] Ambari Server ..................................... SUCCESS [1:01:56.323s]
[INFO] Ambari Agent ...................................... SUCCESS [8.846s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:02:13.979s
[INFO] Finished at: Tue Feb 23 17:11:53 EET 2016
[INFO] Final Memory: 82M/1531M
[INFO] ------------------------------------------------------------------------
- Dmitro Lisnichenko
On Feb. 23, 2016, 4:14 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 4:14 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 860ba88
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 06f6ac1
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 519e4e6
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java dcb7cf6
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java eca911d
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 07addfc
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql bd7755c
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ac1c5d7
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4ed3a19
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5d7be25
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql c032b8f
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6a6b77b
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 43419c1
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 992150c
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> EU/RU seems to work
> Running all unit tests
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: Component should support a desired version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/
-----------------------------------------------------------
(Updated Feb. 23, 2016, 4:14 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
Fixed unit tests, minor fixes
Bugs: AMBARI-14996
https://issues.apache.org/jira/browse/AMBARI-14996
Repository: ambari
Description
-------
When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
Diffs (updated)
-----
.gitignore a8c4aab
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 860ba88
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 06f6ac1
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 519e4e6
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java dcb7cf6
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java eca911d
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 07addfc
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql bd7755c
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ac1c5d7
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4ed3a19
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5d7be25
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql c032b8f
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6a6b77b
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 43419c1
ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 992150c
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
Diff: https://reviews.apache.org/r/43425/diff/
Testing (updated)
-------
EU/RU seems to work
Running all unit tests
Thanks,
Dmitro Lisnichenko
Re: Review Request 43425: Component should support a desired version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/
-----------------------------------------------------------
(Updated Feb. 23, 2016, 12:46 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
Fixed other DDLs. Checked on local Postgres deployment
Bugs: AMBARI-14996
https://issues.apache.org/jira/browse/AMBARI-14996
Repository: ambari
Description
-------
When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
Diffs (updated)
-----
.gitignore a8c4aab
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 860ba88
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 06f6ac1
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 519e4e6
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java dcb7cf6
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java eca911d
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 07addfc
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql bd7755c
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ac1c5d7
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4ed3a19
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5d7be25
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql c032b8f
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6a6b77b
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 43419c1
ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 992150c
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
Diff: https://reviews.apache.org/r/43425/diff/
Testing
-------
EU/RU seems to work
Unit tests pass with ignored failing tests (will create a jira)
Thanks,
Dmitro Lisnichenko
Re: Review Request 43425: Component should support a desired version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/
-----------------------------------------------------------
(Updated Feb. 22, 2016, 9:29 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
patch with fixes
Bugs: AMBARI-14996
https://issues.apache.org/jira/browse/AMBARI-14996
Repository: ambari
Description
-------
When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
Diffs (updated)
-----
.gitignore a8c4aab
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 860ba88
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 06f6ac1
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 519e4e6
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java dcb7cf6
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java eca911d
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 07addfc
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql bd7755c
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ac1c5d7
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4ed3a19
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5d7be25
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql c032b8f
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6a6b77b
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 43419c1
ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 992150c
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
Diff: https://reviews.apache.org/r/43425/diff/
Testing
-------
EU/RU seems to work
Unit tests pass with ignored failing tests (will create a jira)
Thanks,
Dmitro Lisnichenko
Re: Review Request 43425: Component should support a desired version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/
-----------------------------------------------------------
(Updated Feb. 22, 2016, 8:46 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Summary (updated)
-----------------
Component should support a desired version
Bugs: AMBARI-14996
https://issues.apache.org/jira/browse/AMBARI-14996
Repository: ambari
Description
-------
When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
Diffs
-----
.gitignore a8c4aab
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 860ba88
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 06f6ac1
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 519e4e6
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java dcb7cf6
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java eca911d
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 07addfc
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql bd7755c
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ac1c5d7
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4ed3a19
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5d7be25
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql c032b8f
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6a6b77b
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 43419c1
ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 992150c
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
Diff: https://reviews.apache.org/r/43425/diff/
Testing (updated)
-------
EU/RU seems to work
Unit tests pass with ignored failing tests (will create a jira)
Thanks,
Dmitro Lisnichenko
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/
-----------------------------------------------------------
(Updated Feb. 22, 2016, 8:43 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
Hopely a final patch
Bugs: AMBARI-14996
https://issues.apache.org/jira/browse/AMBARI-14996
Repository: ambari
Description
-------
When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
Diffs (updated)
-----
.gitignore a8c4aab
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 860ba88
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java 06f6ac1
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 519e4e6
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java dcb7cf6
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java eca911d
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 07addfc
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql bd7755c
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ac1c5d7
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4ed3a19
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5d7be25
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql c032b8f
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6a6b77b
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 43419c1
ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 992150c
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
Diff: https://reviews.apache.org/r/43425/diff/
Testing
-------
Pending E2E RU/EU upgrades/downgrades on live cluster
Did not work on unit tests yet.
Thanks,
Dmitro Lisnichenko
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review119976
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java (lines 148 - 151)
<https://reviews.apache.org/r/43425/#comment181342>
I don't think you want insertable/updateable false here. That's really used if you have 2 fields mapping the same thing. Like this:
```
@Column(name = "upgrade_id", insertable = false, updatable = false)
private Long upgradeId;
@OneToOne
@JoinColumn(name = "upgrade_id", referencedColumnName = "upgrade_id")
/**
* {@code null} when there is no upgrade/downgrade in progress.
*/
private UpgradeEntity upgradeEntity = null;
```
- Jonathan Hurley
On Feb. 19, 2016, 12:36 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 12:36 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 33b496f
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3ec982a
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 026efea
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql fb9889d
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 3cc7516
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql a5bfdc2
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8e5b2f8
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7b26f23
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> Pending E2E RU/EU upgrades/downgrades on live cluster
>
> Did not work on unit tests yet.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review119977
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java (lines 932 - 937)
<https://reviews.apache.org/r/43425/#comment181343>
So, we have a problem here in that the RequestEntity doesn't exist yet. Yes, we're creating it first and then creating the UpgradeEntity. But the problem is that JPA is not honoring the order, so that when we go to flush this stuff out when the transaction is over, it tries to create the UpgradeEntity first.
We can do the UpgradeEntity association outside of the transaction, but then we don't benefit from a full rollback. Instead, let's just flush from the UpgradeDAO _before_ upgrade.
```
@Transactional
public void create(UpgradeEntity entity) {
EntityManager entityManager = entityManagerProvider.get();
entityManager.flush();
entityManager.persist(entity);
}
```
- Jonathan Hurley
On Feb. 19, 2016, 12:36 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 12:36 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 33b496f
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3ec982a
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 026efea
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql fb9889d
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 3cc7516
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql a5bfdc2
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8e5b2f8
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7b26f23
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> Pending E2E RU/EU upgrades/downgrades on live cluster
>
> Did not work on unit tests yet.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review119968
-----------------------------------------------------------
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql (line 180)
<https://reviews.apache.org/r/43425/#comment181340>
we need DEFAULT 'UNKNOWN' in the .sql files
- Nate Cole
On Feb. 19, 2016, 12:36 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 12:36 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 33b496f
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3ec982a
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 026efea
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql fb9889d
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 3cc7516
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql a5bfdc2
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8e5b2f8
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7b26f23
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> Pending E2E RU/EU upgrades/downgrades on live cluster
>
> Did not work on unit tests yet.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/
-----------------------------------------------------------
(Updated Feb. 19, 2016, 7:36 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
New latest patch
Bugs: AMBARI-14996
https://issues.apache.org/jira/browse/AMBARI-14996
Repository: ambari
Description
-------
When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
Diffs (updated)
-----
.gitignore a8c4aab
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 33b496f
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 360f2b8
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3ec982a
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 026efea
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql fb9889d
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 3cc7516
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql a5bfdc2
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8e5b2f8
ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7b26f23
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 62d5981
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
Diff: https://reviews.apache.org/r/43425/diff/
Testing
-------
Pending E2E RU/EU upgrades/downgrades on live cluster
Did not work on unit tests yet.
Thanks,
Dmitro Lisnichenko
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 8:39 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
restore last upgrade when ABORTED->PENDING
Bugs: AMBARI-14996
https://issues.apache.org/jira/browse/AMBARI-14996
Repository: ambari
Description
-------
When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
Diffs (updated)
-----
.gitignore a8c4aab
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 8c626f5
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f8e4ee1
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e3ce96c
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 5d47c28
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 263004f
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 80feca5
ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3e372f5
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d513448
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
Diff: https://reviews.apache.org/r/43425/diff/
Testing
-------
Pending E2E RU/EU upgrades/downgrades on live cluster
Did not work on unit tests yet.
Thanks,
Dmitro Lisnichenko
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 8:16 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
better fix
Bugs: AMBARI-14996
https://issues.apache.org/jira/browse/AMBARI-14996
Repository: ambari
Description
-------
When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
Diffs (updated)
-----
.gitignore a8c4aab
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 8c626f5
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f8e4ee1
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e3ce96c
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 5d47c28
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 263004f
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 80feca5
ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3e372f5
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d513448
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
Diff: https://reviews.apache.org/r/43425/diff/
Testing
-------
Pending E2E RU/EU upgrades/downgrades on live cluster
Did not work on unit tests yet.
Thanks,
Dmitro Lisnichenko
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 8:04 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
Few fixes. As of now, able to deploy cluster, but host/cluster versions are not bootstraped
Bugs: AMBARI-14996
https://issues.apache.org/jira/browse/AMBARI-14996
Repository: ambari
Description
-------
When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
Diffs (updated)
-----
.gitignore a8c4aab
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 8c626f5
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f8e4ee1
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e3ce96c
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 5d47c28
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 263004f
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 80feca5
ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3e372f5
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d513448
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
Diff: https://reviews.apache.org/r/43425/diff/
Testing
-------
Pending E2E RU/EU upgrades/downgrades on live cluster
Did not work on unit tests yet.
Thanks,
Dmitro Lisnichenko
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Feb. 18, 2016, 6:14 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java, lines 106-118
> > <https://reviews.apache.org/r/43425/diff/3/?file=1254418#file1254418line106>
> >
> > Is there any chance these exist in a database about to be upgraded? I'd hope not and that means we can probably not worry about them on ambari upgrade.
only if customer tries to upgrade ambari-server after non-finished stack upgrade. We may open an upgrade jira if needed
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review119626
-----------------------------------------------------------
On Feb. 18, 2016, 6:10 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 6:10 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 8c626f5
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f8e4ee1
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e3ce96c
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 5d47c28
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 263004f
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 80feca5
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3e372f5
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d513448
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> Pending E2E RU/EU upgrades/downgrades on live cluster
>
> Did not work on unit tests yet.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Feb. 18, 2016, 6:14 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java, lines 139-143
> > <https://reviews.apache.org/r/43425/diff/3/?file=1254410#file1254410line139>
> >
> > We can remove this, right? The host version state should never change b/c a version changes. It now tracks the repo state, not the state of the cluster or the component.
correct. Thanks for great catch
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review119626
-----------------------------------------------------------
On Feb. 18, 2016, 6:10 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 6:10 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 8c626f5
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f8e4ee1
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e3ce96c
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 5d47c28
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 263004f
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 80feca5
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3e372f5
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d513448
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> Pending E2E RU/EU upgrades/downgrades on live cluster
>
> Did not work on unit tests yet.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Feb. 18, 2016, 6:14 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java, lines 1153-1158
> > <https://reviews.apache.org/r/43425/diff/3/?file=1254406#file1254406line1153>
> >
> > So if there is currently no CURRENT version of the cluster, this looks for "INSTALLING" ... but "INSTALLING" doesn't mean that the upgrade is happening. It means that the repo is being distributed. If the cluster is ready to install on a cluster, I'd expect this to be INSTALLED.
We were using UPGRADING for bootstraping new version if CURRENT does not exist. Since UPGRADING was replaced by INSTALLING during bootstrap, it becomes INSTALLING here, does not it? I may be wrong of course.
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review119626
-----------------------------------------------------------
On Feb. 18, 2016, 6:10 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 6:10 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 8c626f5
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f8e4ee1
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e3ce96c
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 5d47c28
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 263004f
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 80feca5
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3e372f5
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d513448
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> Pending E2E RU/EU upgrades/downgrades on live cluster
>
> Did not work on unit tests yet.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review119626
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java (lines 1153 - 1158)
<https://reviews.apache.org/r/43425/#comment180978>
So if there is currently no CURRENT version of the cluster, this looks for "INSTALLING" ... but "INSTALLING" doesn't mean that the upgrade is happening. It means that the repo is being distributed. If the cluster is ready to install on a cluster, I'd expect this to be INSTALLED.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java (line 1648)
<https://reviews.apache.org/r/43425/#comment180977>
Correct; we need to unset this on ABORT. But what about when re-setting the aborted upgrade back to PENDING to resume it? It needs to get re-set, right?
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java (lines 139 - 143)
<https://reviews.apache.org/r/43425/#comment180980>
We can remove this, right? The host version state should never change b/c a version changes. It now tracks the repo state, not the state of the cluster or the component.
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java
<https://reviews.apache.org/r/43425/#comment180976>
Is there any chance these exist in a database about to be upgraded? I'd hope not and that means we can probably not worry about them on ambari upgrade.
- Jonathan Hurley
On Feb. 18, 2016, 11:10 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 11:10 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 8c626f5
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f8e4ee1
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e3ce96c
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 5d47c28
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 263004f
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 80feca5
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3e372f5
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d513448
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> Pending E2E RU/EU upgrades/downgrades on live cluster
>
> Did not work on unit tests yet.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On Feb. 18, 2016, 6:49 p.m., Nate Cole wrote:
> > .gitignore, lines 24-26
> > <https://reviews.apache.org/r/43425/diff/3/?file=1254404#file1254404line24>
> >
> > What is this?
just updated .gitignore
out is directory generated by IDEA when building module, rebel* are JRebel configuration files (sometimes using JRebel for java code hotswap without server restart)
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review119625
-----------------------------------------------------------
On Feb. 18, 2016, 6:10 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 6:10 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 8c626f5
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f8e4ee1
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e3ce96c
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 5d47c28
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 263004f
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 80feca5
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3e372f5
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d513448
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> Pending E2E RU/EU upgrades/downgrades on live cluster
>
> Did not work on unit tests yet.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/#review119625
-----------------------------------------------------------
.gitignore (lines 24 - 26)
<https://reviews.apache.org/r/43425/#comment180975>
What is this?
- Nate Cole
On Feb. 18, 2016, 11:10 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43425/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 11:10 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-14996
> https://issues.apache.org/jira/browse/AMBARI-14996
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
>
>
> Diffs
> -----
>
> .gitignore a8c4aab
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5
> ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
> ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 8c626f5
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f8e4ee1
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e3ce96c
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 5d47c28
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 263004f
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 80feca5
> ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3e372f5
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
> ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
> ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d513448
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
> ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
>
> Diff: https://reviews.apache.org/r/43425/diff/
>
>
> Testing
> -------
>
> Pending E2E RU/EU upgrades/downgrades on live cluster
>
> Did not work on unit tests yet.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 6:10 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
Patch with compileable tests
Bugs: AMBARI-14996
https://issues.apache.org/jira/browse/AMBARI-14996
Repository: ambari
Description
-------
When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
Diffs (updated)
-----
.gitignore a8c4aab
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 8c626f5
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f8e4ee1
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e3ce96c
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 5d47c28
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 263004f
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 80feca5
ambari-server/src/test/java/org/apache/ambari/server/StateRecoveryManagerTest.java 0e9b18d
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 2a4cec8
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 9c59cde
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3e372f5
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 9b27447
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java b0e3467
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 035c61a
ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java ad53f70
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java 772d68a
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 71b89c3
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java b57db5b
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java e8e5d20
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java 89f0ba6
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java 14137cc
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 989eba2
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java 55e7a61
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java d513448
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 847de7d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 2ffcd5d
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java 7cb7679
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java daf8d12
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java 4845d6f
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java 81399a1
ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 4248d13
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 62f2cbf
Diff: https://reviews.apache.org/r/43425/diff/
Testing (updated)
-------
Pending E2E RU/EU upgrades/downgrades on live cluster
Did not work on unit tests yet.
Thanks,
Dmitro Lisnichenko
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 5:49 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-14996
https://issues.apache.org/jira/browse/AMBARI-14996
Repository: ambari
Description (updated)
-------
When performing an upgrade, we need to specify that a component's desired version is getting changed. Also upgrade status is tracked based on component statuses (not host/cluster versions)
Diffs (updated)
-----
.gitignore a8c4aab
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 248ce4b
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java b62f4d1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 87731c4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 2c4d695
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java 65cc107
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 03d407a
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java b430525
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java 344f358
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5143bfa
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8230fe3
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2db745b
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 8c626f5
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f8e4ee1
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e3ce96c
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 5d47c28
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 263004f
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 80feca5
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java 3ad2240
Diff: https://reviews.apache.org/r/43425/diff/
Testing (updated)
-------
Pending E2E RU/EU upgrades/downgrades on live cluster
Did not work on unit tests yet. They are broken (don't compile), so I just remove them before build for now.
Thanks,
Dmitro Lisnichenko
Re: Review Request 43425: [preview] Component should support a desired
version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43425/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 8:55 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-14996
https://issues.apache.org/jira/browse/AMBARI-14996
Repository: ambari
Description
-------
When performing an upgrade, we need to specify that a component's desired version is getting changed.
Going to open additional jiras for TODOs in code
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 210fe17
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java db8c079
ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java ee65d3d
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 74d4f4b
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java 3a11f38
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java f92f645
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java d2d1b42
ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java 561350b
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 7803045
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java f1e8d62
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 4afc857
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeState.java ced1dd3
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 92828af
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 1c36143
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java ae05a6b
ambari-server/src/test/java/org/apache/ambari/server/events/publishers/VersionEventPublisherTest.java 071c6f0
Diff: https://reviews.apache.org/r/43425/diff/
Testing
-------
Pending E2E RU/EU upgrades/downgrades on live cluster
Did not work on unit tests yet
Thanks,
Dmitro Lisnichenko