You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Chase Bradford (JIRA)" <ji...@apache.org> on 2010/02/23 19:10:34 UTC
[jira] Created: (HADOOP-6593) TextRecordInputStream doesn't close
SequenceFile.Reader
TextRecordInputStream doesn't close SequenceFile.Reader
-------------------------------------------------------
Key: HADOOP-6593
URL: https://issues.apache.org/jira/browse/HADOOP-6593
Project: Hadoop Common
Issue Type: Bug
Components: fs
Affects Versions: 0.20.1
Reporter: Chase Bradford
Priority: Minor
Using hadoop fs -text on a glob with many sequence files can fail with too many open file handles.
The cause seems to be that TextRecordInputStream doesn't override close(), so printToStdout's call to close doesn't release the SequenceFile.Reader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6593) TextRecordInputStream doesn't close
SequenceFile.Reader
Posted by "Chase Bradford (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chase Bradford updated HADOOP-6593:
-----------------------------------
Status: Patch Available (was: Open)
> TextRecordInputStream doesn't close SequenceFile.Reader
> -------------------------------------------------------
>
> Key: HADOOP-6593
> URL: https://issues.apache.org/jira/browse/HADOOP-6593
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.20.1
> Reporter: Chase Bradford
> Priority: Minor
> Attachments: HADOOP-6593.patch
>
>
> Using hadoop fs -text on a glob with many sequence files can fail with too many open file handles.
> The cause seems to be that TextRecordInputStream doesn't override close(), so printToStdout's call to close doesn't release the SequenceFile.Reader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6593) TextRecordInputStream doesn't close
SequenceFile.Reader
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-6593:
------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
Assignee: Chase Bradford
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
+1 I've just committed this. Thanks Chase!
> TextRecordInputStream doesn't close SequenceFile.Reader
> -------------------------------------------------------
>
> Key: HADOOP-6593
> URL: https://issues.apache.org/jira/browse/HADOOP-6593
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.20.1
> Reporter: Chase Bradford
> Assignee: Chase Bradford
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-6593.patch
>
>
> Using hadoop fs -text on a glob with many sequence files can fail with too many open file handles.
> The cause seems to be that TextRecordInputStream doesn't override close(), so printToStdout's call to close doesn't release the SequenceFile.Reader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6593) TextRecordInputStream doesn't close
SequenceFile.Reader
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839255#action_12839255 ]
Hadoop QA commented on HADOOP-6593:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12437342/HADOOP-6593.patch
against trunk revision 916915.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/399/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/399/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/399/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/399/console
This message is automatically generated.
> TextRecordInputStream doesn't close SequenceFile.Reader
> -------------------------------------------------------
>
> Key: HADOOP-6593
> URL: https://issues.apache.org/jira/browse/HADOOP-6593
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.20.1
> Reporter: Chase Bradford
> Priority: Minor
> Attachments: HADOOP-6593.patch
>
>
> Using hadoop fs -text on a glob with many sequence files can fail with too many open file handles.
> The cause seems to be that TextRecordInputStream doesn't override close(), so printToStdout's call to close doesn't release the SequenceFile.Reader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6593) TextRecordInputStream doesn't close
SequenceFile.Reader
Posted by "Chase Bradford (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chase Bradford updated HADOOP-6593:
-----------------------------------
Attachment: HADOOP-6593.patch
Added an override for close() in FsShell.TextRecordInputStream that closes the SequenceFile.Reader instance. I didn't create new tests because I don't know the best way to force too many open file handles on the test machine. However, with this patch I can set ulimit -n 100 and still use the -text option on a path glob with 1000+ files. Without the patch, files fail to open at the 95th part.
> TextRecordInputStream doesn't close SequenceFile.Reader
> -------------------------------------------------------
>
> Key: HADOOP-6593
> URL: https://issues.apache.org/jira/browse/HADOOP-6593
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.20.1
> Reporter: Chase Bradford
> Priority: Minor
> Attachments: HADOOP-6593.patch
>
>
> Using hadoop fs -text on a glob with many sequence files can fail with too many open file handles.
> The cause seems to be that TextRecordInputStream doesn't override close(), so printToStdout's call to close doesn't release the SequenceFile.Reader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6593) TextRecordInputStream doesn't close
SequenceFile.Reader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847764#action_12847764 ]
Hudson commented on HADOOP-6593:
--------------------------------
Integrated in Hadoop-Common-trunk #282 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/282/])
. TextRecordInputStream doesn't close SequenceFile.Reader. Contributed by Chase Bradford.
> TextRecordInputStream doesn't close SequenceFile.Reader
> -------------------------------------------------------
>
> Key: HADOOP-6593
> URL: https://issues.apache.org/jira/browse/HADOOP-6593
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.20.1
> Reporter: Chase Bradford
> Assignee: Chase Bradford
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-6593.patch
>
>
> Using hadoop fs -text on a glob with many sequence files can fail with too many open file handles.
> The cause seems to be that TextRecordInputStream doesn't override close(), so printToStdout's call to close doesn't release the SequenceFile.Reader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6593) TextRecordInputStream doesn't close
SequenceFile.Reader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847662#action_12847662 ]
Hudson commented on HADOOP-6593:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #204 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/204/])
. TextRecordInputStream doesn't close SequenceFile.Reader. Contributed by Chase Bradford.
> TextRecordInputStream doesn't close SequenceFile.Reader
> -------------------------------------------------------
>
> Key: HADOOP-6593
> URL: https://issues.apache.org/jira/browse/HADOOP-6593
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.20.1
> Reporter: Chase Bradford
> Assignee: Chase Bradford
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-6593.patch
>
>
> Using hadoop fs -text on a glob with many sequence files can fail with too many open file handles.
> The cause seems to be that TextRecordInputStream doesn't override close(), so printToStdout's call to close doesn't release the SequenceFile.Reader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.