[GitHub] [lucene-solr] jpountz commented on a change in pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments

[GitBox <gi...@apache.org>]

jpountz commented on a change in pull request #769: LUCENE-8905: Better Error Handling For Illegal Arguments
URL: https://github.com/apache/lucene-solr/pull/769#discussion_r302182531
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/search/TopDocsCollector.java
 ##########
 @@ -136,12 +136,9 @@ public TopDocs topDocs(int start, int howMany) {
     // pq.size() or totalHits.
     int size = topDocsSize();
 
-    // Don't bother to throw an exception, just return an empty TopDocs in case
-    // the parameters are invalid or out of range.
-    // TODO: shouldn't we throw IAE if apps give bad params here so they dont
-    // have sneaky silent bugs?
+
     if (start < 0 || start >= size || howMany <= 0) {
-      return newTopDocs(null, start);
+      throw new IllegalArgumentException("Illegal arguments when requesting top docs");
 
 Review comment:
   can you add the value of start and howMany to the error message and what the expectation is for their values?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org