You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/04/02 07:39:32 UTC
Re: Review Request 45214: Updated protobuf to support external
storage.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/
-----------------------------------------------------------
(Updated 四月 2, 2016, 5:39 a.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-5012
https://issues.apache.org/jira/browse/MESOS-5012
Repository: mesos
Description
-------
Updated protobuf to support external storage.
Diffs (updated)
-----
include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f
include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84
Diff: https://reviews.apache.org/r/45214/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 45214: Updated protobuf to support external
storage.
Posted by Guangya Liu <gy...@gmail.com>.
> On 四月 4, 2016, 6:05 a.m., Gilbert Song wrote:
> > include/mesos/mesos.proto, line 1576
> > <https://reviews.apache.org/r/45214/diff/5/?file=1322984#file1322984line1576>
> >
> > Let's make it 0.30.
OK, I will reflect this in `message Source` section.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/#review126791
-----------------------------------------------------------
On 四月 2, 2016, 5:41 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45214/
> -----------------------------------------------------------
>
> (Updated 四月 2, 2016, 5:41 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5012
> https://issues.apache.org/jira/browse/MESOS-5012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated protobuf to support external storage.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f
> include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84
>
> Diff: https://reviews.apache.org/r/45214/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45214: Updated protobuf to support external
storage.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/#review126791
-----------------------------------------------------------
Ditto to the v1. Thanks, Guangya!
include/mesos/mesos.proto (line 1563)
<https://reviews.apache.org/r/45214/#comment189865>
+1.
include/mesos/mesos.proto (line 1576)
<https://reviews.apache.org/r/45214/#comment189866>
Let's make it 0.30.
include/mesos/mesos.proto (line 1581)
<https://reviews.apache.org/r/45214/#comment189867>
ditto.
include/mesos/mesos.proto (lines 1597 - 1600)
<https://reviews.apache.org/r/45214/#comment189871>
Would we possibly have more fields in this message? If no, I guess we may want `repeated string driver_option = 3` only below.
BTW, if we want to keep this msg, could we clarify more detail in comment (e.g., add an example in \'\')?
include/mesos/mesos.proto (line 1605)
<https://reviews.apache.org/r/45214/#comment189872>
Newline above.
include/mesos/mesos.proto (line 1607)
<https://reviews.apache.org/r/45214/#comment189873>
ditto.
- Gilbert Song
On April 1, 2016, 10:41 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45214/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 10:41 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5012
> https://issues.apache.org/jira/browse/MESOS-5012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated protobuf to support external storage.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f
> include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84
>
> Diff: https://reviews.apache.org/r/45214/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45214: Updated protobuf to support external
storage.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/#review127155
-----------------------------------------------------------
include/mesos/mesos.proto (line 1604)
<https://reviews.apache.org/r/45214/#comment190296>
How about use `repeated Parameter` as type here?
- haosdent huang
On April 4, 2016, 8:39 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45214/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 8:39 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5012
> https://issues.apache.org/jira/browse/MESOS-5012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated protobuf to support external storage.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f
> include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84
>
> Diff: https://reviews.apache.org/r/45214/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45214: Updated protobuf to support external
storage.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/#review126983
-----------------------------------------------------------
include/mesos/mesos.proto (line 1563)
<https://reviews.apache.org/r/45214/#comment190115>
We cannot simply do that change. That'll make the rollback impossible. This needs to go through a deprecation cycle.
- Jie Yu
On April 4, 2016, 8:39 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45214/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 8:39 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5012
> https://issues.apache.org/jira/browse/MESOS-5012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated protobuf to support external storage.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f
> include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84
>
> Diff: https://reviews.apache.org/r/45214/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45214: Updated protobuf to support external
storage.
Posted by Guangya Liu <gy...@gmail.com>.
> On 四月 13, 2016, 9:35 p.m., James DeFelice wrote:
> > include/mesos/mesos.proto, line 1625
> > <https://reviews.apache.org/r/45214/diff/7/?file=1342278#file1342278line1625>
> >
> > I definitely prefer this form, but there's also a Parameters message type. Which is more idiomatic in this context?
I saw that no one in protobuf is using this, and the `Parameters` is just a wrapper of `repeated Parameter parameter`, I think it is OK to use `repeated Parameter parameter` here, comments?
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/#review128751
-----------------------------------------------------------
On 四月 13, 2016, 3:09 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45214/
> -----------------------------------------------------------
>
> (Updated 四月 13, 2016, 3:09 a.m.)
>
>
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
>
>
> Bugs: MESOS-5012
> https://issues.apache.org/jira/browse/MESOS-5012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated protobuf to support external storage.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 1232bcda053db3451d18413e81e54e51774f7f22
> include/mesos/v1/mesos.proto 1048fae62733926b5e863a0c1629bba69e35e43b
>
> Diff: https://reviews.apache.org/r/45214/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45214: Updated protobuf to support external
storage.
Posted by Guangya Liu <gy...@gmail.com>.
> On 四月 13, 2016, 9:35 p.m., James DeFelice wrote:
> > include/mesos/mesos.proto, line 1625
> > <https://reviews.apache.org/r/45214/diff/7/?file=1342278#file1342278line1625>
> >
> > I definitely prefer this form, but there's also a Parameters message type. Which is more idiomatic in this context?
>
> Guangya Liu wrote:
> I saw that no one in protobuf is using this, and the `Parameters` is just a wrapper of `repeated Parameter parameter`, I think it is OK to use `repeated Parameter parameter` here, comments?
Thanks James, I did some test and found that `Parameters` is more easy to use, will update this patch soon.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/#review128751
-----------------------------------------------------------
On 四月 13, 2016, 3:09 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45214/
> -----------------------------------------------------------
>
> (Updated 四月 13, 2016, 3:09 a.m.)
>
>
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
>
>
> Bugs: MESOS-5012
> https://issues.apache.org/jira/browse/MESOS-5012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated protobuf to support external storage.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 1232bcda053db3451d18413e81e54e51774f7f22
> include/mesos/v1/mesos.proto 1048fae62733926b5e863a0c1629bba69e35e43b
>
> Diff: https://reviews.apache.org/r/45214/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45214: Updated protobuf to support external
storage.
Posted by James DeFelice <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/#review128751
-----------------------------------------------------------
include/mesos/mesos.proto (line 1625)
<https://reviews.apache.org/r/45214/#comment192212>
I definitely prefer this form, but there's also a Parameters message type. Which is more idiomatic in this context?
- James DeFelice
On April 13, 2016, 3:09 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45214/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 3:09 a.m.)
>
>
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
>
>
> Bugs: MESOS-5012
> https://issues.apache.org/jira/browse/MESOS-5012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated protobuf to support external storage.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 1232bcda053db3451d18413e81e54e51774f7f22
> include/mesos/v1/mesos.proto 1048fae62733926b5e863a0c1629bba69e35e43b
>
> Diff: https://reviews.apache.org/r/45214/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45214: Updated protobuf to support external
storage.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/#review128913
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On April 14, 2016, 4:37 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45214/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 4:37 a.m.)
>
>
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
>
>
> Bugs: MESOS-5012
> https://issues.apache.org/jira/browse/MESOS-5012
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated protobuf to support external storage.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 1232bcda053db3451d18413e81e54e51774f7f22
> include/mesos/v1/mesos.proto 1048fae62733926b5e863a0c1629bba69e35e43b
>
> Diff: https://reviews.apache.org/r/45214/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45214: Updated protobuf to support external
storage.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/
-----------------------------------------------------------
(Updated 四月 14, 2016, 4:37 a.m.)
Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
Bugs: MESOS-5012
https://issues.apache.org/jira/browse/MESOS-5012
Repository: mesos
Description
-------
Updated protobuf to support external storage.
Diffs (updated)
-----
include/mesos/mesos.proto 1232bcda053db3451d18413e81e54e51774f7f22
include/mesos/v1/mesos.proto 1048fae62733926b5e863a0c1629bba69e35e43b
Diff: https://reviews.apache.org/r/45214/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45214: Updated protobuf to support external
storage.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/
-----------------------------------------------------------
(Updated 四月 13, 2016, 3:09 a.m.)
Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
Bugs: MESOS-5012
https://issues.apache.org/jira/browse/MESOS-5012
Repository: mesos
Description
-------
Updated protobuf to support external storage.
Diffs (updated)
-----
include/mesos/mesos.proto 1232bcda053db3451d18413e81e54e51774f7f22
include/mesos/v1/mesos.proto 1048fae62733926b5e863a0c1629bba69e35e43b
Diff: https://reviews.apache.org/r/45214/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45214: Updated protobuf to support external
storage.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/
-----------------------------------------------------------
(Updated 四月 4, 2016, 8:39 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-5012
https://issues.apache.org/jira/browse/MESOS-5012
Repository: mesos
Description
-------
Updated protobuf to support external storage.
Diffs (updated)
-----
include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f
include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84
Diff: https://reviews.apache.org/r/45214/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45214: Updated protobuf to support external
storage.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/
-----------------------------------------------------------
(Updated 四月 2, 2016, 5:41 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-5012
https://issues.apache.org/jira/browse/MESOS-5012
Repository: mesos
Description
-------
Updated protobuf to support external storage.
Diffs
-----
include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f
include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84
Diff: https://reviews.apache.org/r/45214/diff/
Testing (updated)
-------
make
make check
Thanks,
Guangya Liu