You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/22 22:24:15 UTC
[GitHub] [mynewt-core] benmccrea opened a new pull request #2496: sys/console: Add syscfg to allow restoring echo state after NLIP commands
benmccrea opened a new pull request #2496:
URL: https://github.com/apache/mynewt-core/pull/2496
Currently when an NLIP command is finished processing, console echo is always turned back on.
This PR adds an optional syscfg, `CONSOLE_NLIP_RESTORE_ECHO`.
`CONSOLE_NLIP_RESTORE_ECHO: 0` (default setting) retains the existing console behavior, in which completion of an NLIP command will turn on console echo.
`CONSOLE_NLIP_RESTORE_ECHO: 1` will cause the echo on/off state to be restored to the state it was in before an NLIP command was processed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] benmccrea merged pull request #2496: sys/console: Add syscfg to allow restoring echo state after NLIP commands
Posted by GitBox <gi...@apache.org>.
benmccrea merged pull request #2496:
URL: https://github.com/apache/mynewt-core/pull/2496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2496: sys/console: Add syscfg to allow restoring echo state after NLIP commands
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2496:
URL: https://github.com/apache/mynewt-core/pull/2496#issuecomment-783720207
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### sys/console/minimal/src/console.c
<details>
```diff
@@ -336,7 +336,7 @@
ev = NULL;
console_nlip_enable_echo();
return 0;
- /* Ignore characters if there's no more buffer space */
+ /* Ignore characters if there's no more buffer space */
} else if (byte == CONSOLE_NLIP_PKT_START2) {
/* Disable echo to not flood the UART */
console_nlip_disable_echo();
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org