You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Ankit Patel (JIRA)" <ji...@apache.org> on 2011/06/06 22:10:58 UTC
[jira] [Created] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
ForceSync VM arguement not working when set to "no"
---------------------------------------------------
Key: ZOOKEEPER-1087
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
Project: ZooKeeper
Issue Type: Bug
Components: server
Affects Versions: 3.3.2, 3.3.3
Reporter: Ankit Patel
Priority: Blocker
Fix For: 3.3.3, 3.3.2
Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Nate Putnam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nate Putnam updated ZOOKEEPER-1087:
-----------------------------------
Attachment: ZOOKEEPER-1087.patch
Fix import for Assert.assertTrue/False
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1087:
------------------------------------
Fix Version/s: (was: 3.3.3)
(was: 3.3.2)
3.4.0
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Priority: Blocker
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052326#comment-13052326 ]
Mahadev konar commented on ZOOKEEPER-1087:
------------------------------------------
ben, can you commit this? should this go into 3.4 as well?
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.2.3, 3.3.4
>
> Attachments: ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Nate Putnam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nate Putnam updated ZOOKEEPER-1087:
-----------------------------------
Attachment: ZOOKEEPER-1087.patch
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-1087:
---------------------------------------
Assignee: Nate Putnam
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051307#comment-13051307 ]
Patrick Hunt commented on ZOOKEEPER-1087:
-----------------------------------------
fyi no need to delete the old patch(es), just upload a new version with the same name and jira handles it properly (incl seeing history)
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Nate Putnam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nate Putnam updated ZOOKEEPER-1087:
-----------------------------------
Attachment: (was: ZOOKEEPER-1087.patch)
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-1087:
-------------------------------------
Hadoop Flags: [Reviewed]
+1 looks good
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1087:
------------------------------------
Fix Version/s: (was: 3.2.3)
3.4.0
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051296#comment-13051296 ]
Hadoop QA commented on ZOOKEEPER-1087:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482979/ZOOKEEPER-1087.patch
against trunk revision 1136740.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause tar ant target to fail.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/327//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/327//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/327//console
This message is automatically generated.
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052474#comment-13052474 ]
Hudson commented on ZOOKEEPER-1087:
-----------------------------------
Integrated in ZooKeeper-trunk #1218 (See [https://builds.apache.org/job/ZooKeeper-trunk/1218/])
ZOOKEEPER-1087. ForceSync VM arguement not working when set to "no"
breed : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1137864
Files :
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/ZooKeeperServerTest.java
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.2.3, 3.3.4
>
> Attachments: ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Nate Putnam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051291#comment-13051291 ]
Nate Putnam commented on ZOOKEEPER-1087:
----------------------------------------
Totally. New patch attached.
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051322#comment-13051322 ]
Patrick Hunt commented on ZOOKEEPER-1087:
-----------------------------------------
looks good, a couple suggestions:
1) we should be able to make this variable final, no?
2) in testForceSyncDefaultDisabled put a try/finally that resets the forceSync back to it's original value
(you have no guarantee on the order of junit runs tests, if it runs this first your other test will fail)
3) we don't use import * (+import static org.junit.Assert.*;) eclipse can do this for you automatically (organize imports)
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051314#comment-13051314 ]
Hadoop QA commented on ZOOKEEPER-1087:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482981/ZOOKEEPER-1087.patch
against trunk revision 1136740.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/328//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/328//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/328//console
This message is automatically generated.
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051342#comment-13051342 ]
Hadoop QA commented on ZOOKEEPER-1087:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482991/ZOOKEEPER-1087.patch
against trunk revision 1136740.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause tar ant target to fail.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/329//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/329//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/329//console
This message is automatically generated.
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Nate Putnam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nate Putnam updated ZOOKEEPER-1087:
-----------------------------------
Attachment: ZOOKEEPER-1087.patch
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Priority: Blocker
> Fix For: 3.3.2, 3.3.3
>
> Attachments: ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Nate Putnam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051334#comment-13051334 ]
Nate Putnam commented on ZOOKEEPER-1087:
----------------------------------------
I'm not sure what is going on with the import of the assertion methods. The other tests in that class use assertEquals without any issue but Jenkins was complaining about assertTrue,assertFalse not being found. I don't see an explicit import for assertEquals so I'm not sure what's going on. Runs fine for me in IntelliJ and command line. Attaching the latest patch.
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051387#comment-13051387 ]
Patrick Hunt commented on ZOOKEEPER-1087:
-----------------------------------------
you want something like:
import org.junit.Assert;
....
Assert.assertTrue(tmpDir.mkdirs());
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-1087:
-------------------------------------
Component/s: (was: server)
scripts
Affects Version/s: (was: 3.3.2)
Fix Version/s: (was: 3.4.0)
3.2.3
+1 looks good
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.2.3, 3.3.4
>
> Attachments: ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051190#comment-13051190 ]
Hadoop QA commented on ZOOKEEPER-1087:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482948/ZOOKEEPER-1087.patch
against trunk revision 1136740.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/326//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/326//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/326//console
This message is automatically generated.
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Priority: Blocker
> Fix For: 3.3.2, 3.3.3
>
> Attachments: ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Nate Putnam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nate Putnam updated ZOOKEEPER-1087:
-----------------------------------
Attachment: (was: ZOOKEEPER-1087.patch)
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1087:
------------------------------------
Fix Version/s: 3.3.4
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Nate Putnam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nate Putnam updated ZOOKEEPER-1087:
-----------------------------------
Attachment: ZOOKEEPER-1087.patch
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052065#comment-13052065 ]
Hadoop QA commented on ZOOKEEPER-1087:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12483167/ZOOKEEPER-1087.patch
against trunk revision 1136740.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/331//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/331//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/331//console
This message is automatically generated.
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1087) ForceSync VM arguement not
working when set to "no"
Posted by "Nate Putnam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nate Putnam updated ZOOKEEPER-1087:
-----------------------------------
Attachment: ZOOKEEPER-1087.patch
> ForceSync VM arguement not working when set to "no"
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1087
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1087
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.3.2, 3.3.3
> Reporter: Ankit Patel
> Assignee: Nate Putnam
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1087.patch, ZOOKEEPER-1087.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Cannot use forceSync=no to asynchronously write transaction logs. This is a critical bug, please address it ASAP. More details:
> The class org.apache.zookeeper.server.persistence.FileTxnLog initializes forceSync property in a static block. However, the static variable is defined after the static block with a default value of true. Therefore, the value of the variable can never be false. Please move the declaration of the variable before the static block.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira