You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/07/07 18:03:35 UTC
[GitHub] flink pull request #4286: [FLINK-7135] [flip6] Pass in proper configuration ...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4286
[FLINK-7135] [flip6] Pass in proper configuration to Dispatcher component
This PR is based on #4259, #4260 and #4261.
The `Dispatcher` component should get passed in the proper `Configuration` instance from the `SessionClusterEntrypoint`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink passInConfigurationToDispatcher
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4286.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4286
----
commit 6c313e0ecc8ff84aee9403acbc60efa31d49f69e
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-07-04T21:15:52Z
[FLINK-7103] [dispatcher] Add skeletal structure of Dispatcher component
The Dispatcher is responsible for receiving job submissions, persisting the JobGraphs,
spawning JobManager to execute the jobs and recovering the jobs in case of a master
failure. This commit adds the basic skeleton including the RPC call for job submission.
Add cleanup logic for finished jobs
Pass BlobService to JobManagerRunner
commit 44abd04f328a60d3d25f74454ad04bd5c79fc258
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-07-05T11:38:35Z
[FLINK-7105] Make ActorSystems non daemonic
In order to not having to explicitly wait on the termination of an ActorSystem
in the main thread, we now create the ActorSystems in non-daemonic mode. That
way the process won't terminate if there is still an active actor.
commit 4a2b08645a2e7d80c7404b6af6f396178de19e33
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-07-06T15:16:18Z
[FLINK-7082] Add generic entry point for session and per-job clusters
commit cacde44d9cec26e77836c56782b620d2e6d4979d
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-07-07T17:57:10Z
[FLINK-7135] [flip6] Pass in proper configuration to Dispatcher component
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4286: [FLINK-7135] [flip6] Pass in proper configuration ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4286#discussion_r129529477
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerRunner.java ---
@@ -228,6 +228,7 @@ public JobManagerRunner(
//----------------------------------------------------------------------------------------------
public void start() throws Exception {
+ log.info("Start JobManagerRunner.");
--- End diff --
Yes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4286: [FLINK-7135] [flip6] Pass in proper configuration to Disp...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4286
FYI, i integrated the dispatcher changes while merging #4260.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4286: [FLINK-7135] [flip6] Pass in proper configuration ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4286#discussion_r126275600
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerRunner.java ---
@@ -228,6 +228,7 @@ public JobManagerRunner(
//----------------------------------------------------------------------------------------------
public void start() throws Exception {
+ log.info("Start JobManagerRunner.");
--- End diff --
intended change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4286: [FLINK-7135] [flip6] Pass in proper configuration ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4286
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4286: [FLINK-7135] [flip6] Pass in proper configuration to Disp...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4286
@zentol thanks for the review. Also thanks for merging #4260. In the future I would refrain from taking partial changes and adding them to other PRs, because this can cause merge conflicts especially if the PR depends on other PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---