[jira] [Commented] (CB-5504) Telephone events are handled by the Device plugin, but Media needs them to know to pause on incoming calls, etc

["Andrew Grieve (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-5504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835446#comment-13835446 ] 

Andrew Grieve commented on CB-5504:
-----------------------------------

Neat! Didn't know that existed!

I don't think this functionality fits well with the Device plugin. Given that it's been broken since 3.0 and is undocumented, I don't think we need to worry about breaking third-party plugins with changes here.

Ideas:
- Inline logic into Media plugin
- Make a separate plugin called "PhoneState". Install this plugin if you want this behaviour


I think I'd lean towards inlining. Any other options or considerations?

> Telephone events are handled by the Device plugin, but Media needs them to know to pause on incoming calls, etc
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-5504
>                 URL: https://issues.apache.org/jira/browse/CB-5504
>             Project: Apache Cordova
>          Issue Type: Bug
>    Affects Versions: 3.1.0
>            Reporter: Tommy-Carlos Williams
>
> There is a telephony receiver in the Device plugin that sends a message to all plugins so that they can handle incoming calls etc.
> Currently the only core plugin that listens for those messages is the Media plugin so that it can pause playback when a call comes in.
> There is no documentation for this (before the great plugin break out, there didn't need to be) so if you just add the Media plugin, audio playback does not pause on an incoming or outgoing phone call.
> I am not advocating moving this into Media as there might be third party plugins listening for this. However, I do think that at the least this needs to be documented in the docs for the Media plugin/api and possibly even have Device as a dependancy for Media.
> There's another bug that is related involving android permissions but I will lodge that separately. (See: [CB-5505|https://issues.apache.org/jira/browse/CB-5505])



--
This message was sent by Atlassian JIRA
(v6.1#6144)