You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by rw...@apache.org on 2005/10/19 10:03:22 UTC

svn commit: r326447 - in /portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/aggregator/impl: PortletAggregatorFragmentImpl.java PortletAggregatorImpl.java

Author: rwatler
Date: Wed Oct 19 01:03:18 2005
New Revision: 326447

URL: http://svn.apache.org/viewcvs?rev=326447&view=rev
Log:
convert inner class to freestanding to promote reuse

Added:
    portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletAggregatorFragmentImpl.java   (with props)
Modified:
    portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletAggregatorImpl.java

Added: portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletAggregatorFragmentImpl.java
URL: http://svn.apache.org/viewcvs/portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletAggregatorFragmentImpl.java?rev=326447&view=auto
==============================================================================
--- portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletAggregatorFragmentImpl.java (added)
+++ portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletAggregatorFragmentImpl.java Wed Oct 19 01:03:18 2005
@@ -0,0 +1,333 @@
+/*
+ * Copyright 2000-2004 The Apache Software Foundation.
+ * 
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.jetspeed.aggregator.impl;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.jetspeed.om.common.SecurityConstraints;
+import org.apache.jetspeed.om.page.Fragment;
+import org.apache.jetspeed.om.page.Property;
+
+/**
+ * PortletAggregator Fragment implementation for rendering.
+ *
+ * @author <a href="mailto:rwatler@apache.org">Randy Watler</a>
+ * @version $Id$
+ */
+public class PortletAggregatorFragmentImpl implements Fragment
+{
+    private String id;
+    private String name;
+    private String type;
+    private String decorator;
+    private String state;
+    
+    public PortletAggregatorFragmentImpl(String id)
+    {
+        this.id = id;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.common.SecuredResource#getConstraintsEnabled()
+     */
+    public boolean getConstraintsEnabled()
+    {
+        return false;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.common.SecuredResource#getSecurityConstraints()
+     */
+    public SecurityConstraints getSecurityConstraints()
+    {
+        return null;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.common.SecuredResource#setSecurityConstraints(org.apache.jetspeed.om.common.SecurityConstraints)
+     */
+    public void setSecurityConstraints(SecurityConstraints constraints)
+    {
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.common.SecuredResource#checkConstraints(java.lang.String)
+     */
+    public void checkConstraints(String actions) throws SecurityException
+    {
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.common.SecuredResource#getPermissionsEnabled()
+     */
+    public boolean getPermissionsEnabled()
+    {
+        return false;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.common.SecuredResource#checkPermissions(java.lang.String)
+     */
+    public void checkPermissions(String actions) throws SecurityException
+    {
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.common.SecuredResource#checkAccess(java.lang.String)
+     */
+    public void checkAccess(String actions) throws SecurityException
+    {
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.BaseElement#getId()
+     */
+    public String getId()
+    {
+        return id;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.BaseElement#getTitle()
+     */
+    public String getTitle()
+    {
+        return null;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.BaseElement#setTitle(java.lang.String)
+     */
+    public void setTitle(String title)
+    {
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.BaseElement#getShortTitle()
+     */
+    public String getShortTitle()
+    {
+        return null;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.BaseElement#setShortTitle(java.lang.String)
+     */
+    public void setShortTitle(String title)
+    {
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#getName()
+     */
+    public String getName()
+    {
+        return name;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#setName(java.lang.String)
+     */
+    public void setName( String name )
+    {
+        this.name = name;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#getType()
+     */
+    public String getType()
+    {
+        return type;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#setType(java.lang.String)
+     */
+    public void setType(String type)
+    {
+        this.type = type;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#getSkin()
+     */
+    public String getSkin()
+    {
+        return null;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#setSkin(java.lang.String)
+     */
+    public void setSkin(String skinName)
+    {
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#getDecorator()
+     */
+    public String getDecorator()
+    {
+        return decorator;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#setDecorator(java.lang.String)
+     */
+    public void setDecorator(String decoratorName)
+    {
+        this.decorator = decoratorName;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#getState()
+     */
+    public String getState()
+    {
+        return state;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#setState(java.lang.String)
+     */
+    public void setState(String state)
+    {
+        this.state = state;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#getFragments()
+     */
+    public List getFragments()
+    {
+        return new ArrayList(0);
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#getLayoutProperties()
+     */
+    public List getLayoutProperties()
+    {
+        return new ArrayList(0);
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#getProperties(java.lang.String)
+     */
+    public List getProperties(String layoutName)
+    {
+        return new ArrayList(0);
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#getPropertyValue(java.lang.String,java.lang.String)
+     */
+    public String getPropertyValue(String layout, String propName)
+    {
+        return null;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#getPropertyValue(java.lang.String,java.lang.String,java.lang.String)
+     */
+    public void setPropertyValue(String layout, String propName, String value)
+    {
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#addProperty(org.apache.jetspeed.om.page.Property)
+     */
+    public void addProperty(Property p)
+    {
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#removeProperty(org.apache.jetspeed.om.page.Property)
+     */
+    public void removeProperty(Property p)
+    {
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#clearProperties(java.lang.String)
+     */
+    public void clearProperties(String layoutName)
+    {
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#getLayoutWidths()
+     */
+    public int getLayoutRow()
+    {
+        return -1;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#getLayoutWidths()
+     */
+    public int getLayoutColumn()
+    {
+        return -1;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#getLayoutSizes()
+     */
+    public String getLayoutSizes()
+    {
+        return null;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#setLayoutColumn(int)
+     */
+    public void setLayoutColumn(int column)
+    {
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#setLayoutRow(int)
+     */
+    public void setLayoutRow(int row)
+    {
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#setLayoutSizes(java.lang.String)
+     */
+    public void setLayoutSizes(String sizes)
+    {
+    }
+
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#isReference()
+     */
+    public boolean isReference()
+    {
+        return false;
+    }
+    
+    /* (non-Javadoc)
+     * @see org.apache.jetspeed.om.page.Fragment#clone()
+     */
+    public Object clone() throws CloneNotSupportedException
+    {
+        return null;
+    }    
+}

Propchange: portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletAggregatorFragmentImpl.java
------------------------------------------------------------------------------
    svn:eol-style = native

Modified: portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletAggregatorImpl.java
URL: http://svn.apache.org/viewcvs/portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletAggregatorImpl.java?rev=326447&r1=326446&r2=326447&view=diff
==============================================================================
--- portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletAggregatorImpl.java (original)
+++ portals/jetspeed-2/trunk/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletAggregatorImpl.java Wed Oct 19 01:03:18 2005
@@ -16,9 +16,7 @@
 package org.apache.jetspeed.aggregator.impl;
 
 import java.io.IOException;
-import java.util.ArrayList;
 import java.util.HashMap;
-import java.util.List;
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
@@ -30,10 +28,8 @@
 import org.apache.jetspeed.exception.JetspeedException;
 import org.apache.jetspeed.headerresource.HeaderResource;
 import org.apache.jetspeed.headerresource.HeaderResourceFactory;
-import org.apache.jetspeed.om.common.SecurityConstraints;
 import org.apache.jetspeed.om.page.ContentFragment;
 import org.apache.jetspeed.om.page.Fragment;
-import org.apache.jetspeed.om.page.Property;
 import org.apache.jetspeed.om.page.ContentFragmentImpl;
 import org.apache.jetspeed.request.RequestContext;
 
@@ -55,307 +51,6 @@
     }
 
     /* (non-Javadoc)
-     * @see org.apache.jetspeed.om.page.Fragment
-     */
-    public class PortletEntityFragmentImpl implements Fragment
-    {
-        private String id;
-        private String name;
-        private String type;
-        private String decorator;
-        private String state;
-
-        public PortletEntityFragmentImpl(String id)
-        {
-            this.id = id;
-        }
-
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.common.SecuredResource#getConstraintsEnabled()
-         */
-        public boolean getConstraintsEnabled()
-        {
-            return false;
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.common.SecuredResource#getSecurityConstraints()
-         */
-        public SecurityConstraints getSecurityConstraints()
-        {
-            return null;
-        }
-    
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.common.SecuredResource#setSecurityConstraints(org.apache.jetspeed.om.common.SecurityConstraints)
-         */
-        public void setSecurityConstraints(SecurityConstraints constraints)
-        {
-        }
-
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.common.SecuredResource#checkConstraints(java.lang.String)
-         */
-        public void checkConstraints(String actions) throws SecurityException
-        {
-        }
-
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.common.SecuredResource#getPermissionsEnabled()
-         */
-        public boolean getPermissionsEnabled()
-        {
-            return false;
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.common.SecuredResource#checkPermissions(java.lang.String)
-         */
-        public void checkPermissions(String actions) throws SecurityException
-        {
-        }
-
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.common.SecuredResource#checkAccess(java.lang.String)
-         */
-        public void checkAccess(String actions) throws SecurityException
-        {
-        }
-
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.BaseElement#getId()
-         */
-        public String getId()
-        {
-            return id;
-        }
-
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.BaseElement#getTitle()
-         */
-        public String getTitle()
-        {
-            return null;
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.BaseElement#setTitle(java.lang.String)
-         */
-        public void setTitle(String title)
-        {
-        }
-
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.BaseElement#getShortTitle()
-         */
-        public String getShortTitle()
-        {
-            return null;
-        }
-
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.BaseElement#setShortTitle(java.lang.String)
-         */
-        public void setShortTitle(String title)
-        {
-        }
-
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#getName()
-         */
-        public String getName()
-        {
-            return name;
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#setName(java.lang.String)
-         */
-        public void setName( String name )
-        {
-            this.name = name;
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#getType()
-         */
-        public String getType()
-        {
-            return type;
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#setType(java.lang.String)
-         */
-        public void setType(String type)
-        {
-            this.type = type;
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#getSkin()
-         */
-        public String getSkin()
-        {
-            return null;
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#setSkin(java.lang.String)
-         */
-        public void setSkin(String skinName)
-        {
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#getDecorator()
-         */
-        public String getDecorator()
-        {
-            return decorator;
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#setDecorator(java.lang.String)
-         */
-        public void setDecorator(String decoratorName)
-        {
-            this.decorator = decoratorName;
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#getState()
-         */
-        public String getState()
-        {
-            return state;
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#setState(java.lang.String)
-         */
-        public void setState(String state)
-        {
-            this.state = state;
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#getFragments()
-         */
-        public List getFragments()
-        {
-            return new ArrayList(0);
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#getLayoutProperties()
-         */
-        public List getLayoutProperties()
-        {
-            return new ArrayList(0);
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#getProperties(java.lang.String)
-         */
-        public List getProperties(String layoutName)
-        {
-            return new ArrayList(0);
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#getPropertyValue(java.lang.String,java.lang.String)
-         */
-        public String getPropertyValue(String layout, String propName)
-        {
-            return null;
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#getPropertyValue(java.lang.String,java.lang.String,java.lang.String)
-         */
-        public void setPropertyValue(String layout, String propName, String value)
-        {
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#addProperty(org.apache.jetspeed.om.page.Property)
-         */
-        public void addProperty(Property p)
-        {
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#removeProperty(org.apache.jetspeed.om.page.Property)
-         */
-        public void removeProperty(Property p)
-        {
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#clearProperties(java.lang.String)
-         */
-        public void clearProperties(String layoutName)
-        {
-        }
-        
-        public void setLayoutRow(int row)
-        {
-            // ?
-        }
-        
-        public void setLayoutColumn(int column)
-        {
-            // ?
-        }
-        
-        public void setLayoutSizes(String sizes)
-        {
-            // ?
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#getLayoutWidths()
-         */
-        public int getLayoutRow()
-        {
-            return -1;
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#getLayoutWidths()
-         */
-        public int getLayoutColumn()
-        {
-            return -1;
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#getLayoutSizes()
-         */
-        public String getLayoutSizes()
-        {
-            return null;
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#isReference()
-         */
-        public boolean isReference()
-        {
-            return false;
-        }
-        
-        /* (non-Javadoc)
-         * @see org.apache.jetspeed.om.page.Fragment#clone()
-         */
-        public Object clone() throws CloneNotSupportedException
-        {
-            return null;
-        }    
-    }
-    
-    /* (non-Javadoc)
      * @see org.apache.jetspeed.aggregator.Aggregator#build(org.apache.jetspeed.request.RequestContext)
      */
     public void build(RequestContext context) throws JetspeedException, IOException
@@ -367,7 +62,7 @@
         {
             entity = (String)context.getAttribute(PortalReservedParameters.PORTLET_ENTITY);
         }
-        PortletEntityFragmentImpl fragment = new PortletEntityFragmentImpl(entity);
+        PortletAggregatorFragmentImpl fragment = new PortletAggregatorFragmentImpl(entity);
         fragment.setType(Fragment.PORTLET);
         fragment.setName(context.getRequestParameter(PortalReservedParameters.PORTLET));
         String decorator = fragment.getDecorator();



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org