You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Alejandro Abdelnur <tu...@cloudera.com> on 2012/07/31 05:48:57 UTC
Re: Review Request: Workflow nodes START/END/KILL/FORK/JOIN should create
rows in the action DB table
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6137/
-----------------------------------------------------------
(Updated July 31, 2012, 3:48 a.m.)
Review request for oozie.
Changes
-------
new patch addressing Virag's comments.
Description
-------
This will help better visualization of the status of a workflow and it will make easier for tools to visualize workflows correctly.
Added node handlers for the control nodes and wired them as regular action/decision nodes thus they create a WF action entry in the DB.
The transitions for FORK nodes are denoted with a '*' as the column would not hold a large concatenation of transition. Still this can be inferred from the WF XML as the FORK transitions are always static.
This addresses bug OOZIE-243.
https://issues.apache.org/jira/browse/OOZIE-243
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/action/control/ControlNodeActionExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/action/control/EndActionExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/action/control/ForkActionExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/action/control/JoinActionExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/action/control/KillActionExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/action/control/StartActionExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 1367335
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1367335
trunk/core/src/main/java/org/apache/oozie/service/ActionService.java 1367335
trunk/core/src/main/java/org/apache/oozie/service/DBLiteWorkflowStoreService.java 1367335
trunk/core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java 1367335
trunk/core/src/main/java/org/apache/oozie/workflow/lite/ControlNodeDef.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/workflow/lite/ControlNodeHandler.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java 1367335
trunk/core/src/main/java/org/apache/oozie/workflow/lite/EndNodeDef.java 1367335
trunk/core/src/main/java/org/apache/oozie/workflow/lite/ForkNodeDef.java 1367335
trunk/core/src/main/java/org/apache/oozie/workflow/lite/JoinNodeDef.java 1367335
trunk/core/src/main/java/org/apache/oozie/workflow/lite/KillNodeDef.java 1367335
trunk/core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 1367335
trunk/core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 1367335
trunk/core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowLib.java 1367335
trunk/core/src/main/java/org/apache/oozie/workflow/lite/StartNodeDef.java 1367335
trunk/core/src/test/java/org/apache/oozie/TestDagELFunctions.java 1367335
trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1367335
trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1367335
trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java 1367335
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java 1367335
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java 1367335
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1367335
trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 1367335
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1367335
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1367335
trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1367335
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java 1367335
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1367335
trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 1367335
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1367335
trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1367335
trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1367335
trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java 1367335
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1367335
trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java 1367335
trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowLib.java 1367335
Diff: https://reviews.apache.org/r/6137/diff/
Testing
-------
Modified corresponding testcases to test the new functionality.
Thanks,
Alejandro Abdelnur