You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <ch...@yahoo-inc.com> on 2012/05/03 01:02:50 UTC
Review Request: OOZIE-828 XLogStreamer has missing i/o stream close
statements
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4975/
-----------------------------------------------------------
Review request for oozie.
Summary
-------
Refer to https://issues.apache.org/jira/browse/OOZIE-828
This addresses bug OOZIE-828.
https://issues.apache.org/jira/browse/OOZIE-828
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java 1326832
Diff: https://reviews.apache.org/r/4975/diff
Testing
-------
some end-to-end tests experiencing interruption in getting log stream from multiple gz files
oozie job -log <id>
Testing with patch to see if this is the cause. In either case, these close statements are required.
Thanks,
Mona
Re: Review Request: OOZIE-828 XLogStreamer has missing i/o stream close
statements
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4975/#review7489
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java
<https://reviews.apache.org/r/4975/#comment16587>
This is not required as Xlogreader will close the underlying stream (In this case, gzipInputStrem())
trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java
<https://reviews.apache.org/r/4975/#comment16584>
logreader.close() will call ifs.close()..no need for both
- Virag
On 2012-05-02 23:02:50, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4975/
> -----------------------------------------------------------
>
> (Updated 2012-05-02 23:02:50)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Refer to https://issues.apache.org/jira/browse/OOZIE-828
>
>
> This addresses bug OOZIE-828.
> https://issues.apache.org/jira/browse/OOZIE-828
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java 1326832
>
> Diff: https://reviews.apache.org/r/4975/diff
>
>
> Testing
> -------
>
> some end-to-end tests experiencing interruption in getting log stream from multiple gz files
> oozie job -log <id>
>
> Testing with patch to see if this is the cause. In either case, these close statements are required.
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-828 XLogStreamer has missing i/o stream close
statements
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4975/#review7965
-----------------------------------------------------------
Agree with review comments that closing logReader in both cases will, in turn, close the inputstream it uses. Closing as invalid
- Mona
On 2012-05-02 23:02:50, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4975/
> -----------------------------------------------------------
>
> (Updated 2012-05-02 23:02:50)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Refer to https://issues.apache.org/jira/browse/OOZIE-828
>
>
> This addresses bug OOZIE-828.
> https://issues.apache.org/jira/browse/OOZIE-828
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java 1326832
>
> Diff: https://reviews.apache.org/r/4975/diff
>
>
> Testing
> -------
>
> some end-to-end tests experiencing interruption in getting log stream from multiple gz files
> oozie job -log <id>
>
> Testing with patch to see if this is the cause. In either case, these close statements are required.
>
>
> Thanks,
>
> Mona
>
>