You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@celeborn.apache.org by ni...@apache.org on 2026/08/03 02:38:17 UTC

(celeborn) branch branch-0.7 updated: [CELEBORN-2396][CLI] Fix CelebornCli.main discarding the configured CommandLine instance

This is an automated email from the ASF dual-hosted git repository.

SteNicholas pushed a commit to branch branch-0.7
in repository https://gitbox.apache.org/repos/asf/celeborn.git


The following commit(s) were added to refs/heads/branch-0.7 by this push:
     new 6020856b7b [CELEBORN-2396][CLI] Fix CelebornCli.main discarding the configured CommandLine instance
6020856b7b is described below

commit 6020856b7b46edabf38e89dfaaf69bf5bfa14a72
Author: yew1eb <ye...@gmail.com>
AuthorDate: Mon Aug 3 10:37:52 2026 +0800

    [CELEBORN-2396][CLI] Fix CelebornCli.main discarding the configured CommandLine instance
    
    ### What changes were proposed in this pull request?
    
    Call `execute()` on the configured `CommandLine` instance instead of creating and executing a new one.
    
    ### Why are the changes needed?
    
    `CelebornCli.main` creates a `CommandLine`, sets case-sensitivity options on it, but then executes a brand-new instance, so the configuration is silently discarded and the two setter calls are dead code.
    
    ### Does this PR introduce any user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    Closes #3773 from yew1eb/CELEBORN-2396.
    
    Authored-by: yew1eb <ye...@gmail.com>
    Signed-off-by: Nicholas Jiang <pr...@163.com>
    (cherry picked from commit fd6aaa59ba4ed796db9e4373fc31fde5dfb0b3f3)
    Signed-off-by: Nicholas Jiang <pr...@163.com>
---
 cli/src/main/scala/org/apache/celeborn/cli/CelebornCli.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cli/src/main/scala/org/apache/celeborn/cli/CelebornCli.scala b/cli/src/main/scala/org/apache/celeborn/cli/CelebornCli.scala
index e1b9444ae0..f73436095f 100644
--- a/cli/src/main/scala/org/apache/celeborn/cli/CelebornCli.scala
+++ b/cli/src/main/scala/org/apache/celeborn/cli/CelebornCli.scala
@@ -40,6 +40,6 @@ object CelebornCli {
     val cmd = new CommandLine(new CelebornCli())
     cmd.setOptionsCaseInsensitive(false)
     cmd.setSubcommandsCaseInsensitive(false)
-    new CommandLine(new CelebornCli()).execute(args: _*)
+    cmd.execute(args: _*)
   }
 }