You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/08/15 23:31:16 UTC

[GitHub] [flink] hlteoh37 opened a new pull request, #20588: [FLINK-28978][kinesis] Update AWS Regions validation to allow for fut…

hlteoh37 opened a new pull request, #20588:
URL: https://github.com/apache/flink/pull/20588

   …ure AWS regions
   
   ## What is the purpose of the change
   Make the validation for `AWS Region` string passed into the Kinesis connector more permissive (checks that the shape of the string follows the general AWS Region shape, rather than validating that the Region exists in the `Regions` enum). This allows the Kinesis connector to cover future new AWS Regions as well.
   
   ## Brief change log
   - Make the validation for `isValidRegion` more permissive
   
   
   ## Verifying this change
   This change is already covered by existing tests, such as unit tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dannycranmer commented on pull request #20588: [FLINK-28978][kinesis] Update AWS Regions validation to allow for fut…

Posted by GitBox <gi...@apache.org>.
dannycranmer commented on PR #20588:
URL: https://github.com/apache/flink/pull/20588#issuecomment-1216464056

   LGTM. Thanks @hlteoh37 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20588: [FLINK-28978][kinesis] Update AWS Regions validation to allow for fut…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20588:
URL: https://github.com/apache/flink/pull/20588#issuecomment-1215987276

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3fcafb17b3f530e7953f42aa52daa536b04a0235",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3fcafb17b3f530e7953f42aa52daa536b04a0235",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3fcafb17b3f530e7953f42aa52daa536b04a0235 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dannycranmer merged pull request #20588: [FLINK-28978][kinesis] Update AWS Regions validation to allow for fut…

Posted by GitBox <gi...@apache.org>.
dannycranmer merged PR #20588:
URL: https://github.com/apache/flink/pull/20588


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org