[GitHub] mickaelistria commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject

[GitBox <gi...@apache.org>]

mickaelistria commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject
URL: https://github.com/apache/maven/pull/197#issuecomment-450911058
 
 
   > I reworked the PR, creating 2 initial little refactoring commits that make the later modification a lot easier to understand IMHO: see MNG-6533-2 branch. With that 2 commits, I now can understand the main "Prefer passing the interim project in ProjectBuildingResult" commit...
   
   Ok, thanks.
   
   > One little thing that I feel is not good: catch(Exception) in the last commit. is catching InvalidArtifactRTException not sufficient?
   
   IIRC, there were some cases where this wasn't sufficient and some other exceptions could happen in m2e using this API; but I don't remember how much this memory is true; so I need to double-check.
   I'll give it a try with `catch (InvalidArtifactRTException)` and see how m2e likes it or not on next Monday hopefully. If it seems to work as expected for m2e, I'm fine with changing it. If it doesn't I'll try to write extra-unit tests for the potential issues that are not covered by this exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services