You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@johnzon.apache.org by GitBox <gi...@apache.org> on 2023/01/12 23:04:01 UTC
[GitHub] [johnzon] jeanouii opened a new pull request, #98: WIP Jakarta EE 10 TCK setup
jeanouii opened a new pull request, #98:
URL: https://github.com/apache/johnzon/pull/98
Signed-off-by: Jean-Louis Monteiro <jl...@tomitribe.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] jungm commented on pull request #98: WIP Jakarta EE 10 TCK setup
Posted by "jungm (via GitHub)" <gi...@apache.org>.
jungm commented on PR #98:
URL: https://github.com/apache/johnzon/pull/98#issuecomment-1520648204
From what I've seen so far both failing tests in `SpecificTypesMappingTest` (BigDecimal/BigInteger) are incredibly easy to fix - just remove the converters for those two types so they get passed as BigDecimal/BigInteger instead of as a String to jsonp
this brings me back to the good old mapper vs jsonb question: Do we break mapper "json compatibility" (json generated in mapper 1.x wouldn't be compatible with mapper 2.x) in favour of being jsonb compliant? Or Maybe sth that should be solved in jsonb only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rmannibucau commented on pull request #98: WIP Jakarta EE 10 TCK setup
Posted by "rmannibucau (via GitHub)" <gi...@apache.org>.
rmannibucau commented on PR #98:
URL: https://github.com/apache/johnzon/pull/98#issuecomment-1520671987
@jungm jsonb only while possible, that said we can also challenge the test since serializing numbers either as string or plain numbers (we cant do both with json spec and java impl) is not portable and likely considered as a bug by most consumers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] jungm commented on pull request #98: WIP Jakarta EE 10 TCK setup
Posted by "jungm (via GitHub)" <gi...@apache.org>.
jungm commented on PR #98:
URL: https://github.com/apache/johnzon/pull/98#issuecomment-1516225486
any chance we can get this merged, or at least rebased?
would improve visibility on where we are in terms of passing/failing tcks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] jeanouii commented on pull request #98: WIP Jakarta EE 10 TCK setup
Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii commented on PR #98:
URL: https://github.com/apache/johnzon/pull/98#issuecomment-1520735773
@jungm if you have some cycles and can provide some PRs, I'm happy to get them merged in so we have a working PR asap and we don't need the other PR to disable the TCK on CI/CD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP Jakarta EE 10 TCK setup [johnzon]
Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii merged PR #98:
URL: https://github.com/apache/johnzon/pull/98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP Jakarta EE 10 TCK setup [johnzon]
Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii commented on PR #98:
URL: https://github.com/apache/johnzon/pull/98#issuecomment-1747023543
I rebased the PR and moved the TCK under a profile so we can merge this PR before it gets too big and keep working on the compliancy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] jeanouii commented on pull request #98: WIP Jakarta EE 10 TCK setup
Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii commented on PR #98:
URL: https://github.com/apache/johnzon/pull/98#issuecomment-1520609233
I can rebase it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] jeanouii commented on pull request #98: WIP Jakarta EE 10 TCK setup
Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii commented on PR #98:
URL: https://github.com/apache/johnzon/pull/98#issuecomment-1520639362
For JSONB, we have so far
````
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] SerializersCustomizationCDITest.testCDISupport:110 Failed to correctly unmarshall complex type hierarchy using a serializer configured using JsonbTypeSerializer annotation and a deserializer with a CDI managed field configured using JsonbTypeDeserializer annotation.
Expected: is <ee...@672037ff>
but: was <ee...@1>
[ERROR] InstantiationCustomizationTest.testJsonbDeserializerOnCreatorParameter:221 JsonbDeserializer on the JsonbCreator parameter was not executed.
Expected: is "Test String Deserialized"
but: was "Test String"
[ERROR] NumberFormatCustomizationTest.testNumberFormatField:112 Failed to correctly customize number format during marshalling using JsonbNumberFormat annotation on field.
Expected: a string matching the pattern '\{\s*"instance"\s*:\s*"123\u00a0456,789"\s*\}'
but: was "{\"instance\":\"123 456,789\"}"
[ERROR] ClassesMappingTest.testPrivateAccessorsPublicField:302 Failed to ignore setting public value using private setter.
Expected: is "Test String"
but: was "New Test String"
[ERROR] SpecificTypesMappingTest.testBigDecimalMapping:83 [testMarshalling] - Failed to correctly marshal java.math.BigDecimal property with value 0.0
Expected: a string matching the pattern '\{\s*"instance"\s*:\s*0.0\s*\}'
but: was "{\"instance\":\"0.0\"}"
[ERROR] SpecificTypesMappingTest.testBigIntegerMapping:68 [testMarshalling] - Failed to correctly marshal java.math.BigInteger property with value 0
Expected: a string matching the pattern '\{\s*"instance"\s*:\s*0\s*\}'
but: was "{\"instance\":\"0\"}"
[ERROR] Errors:
[ERROR] AdaptersCustomizationCDITest.testCDISupport:94 » Jsonb Cannot invoke "ee.jakar...
[ERROR] OptionalCreatorParametersTest.testOptionalTypesDefaultValues:98 » Jsonb Option...
[ERROR] OptionalCreatorParametersTest.testOptionalTypesInCreator:113 » Jsonb OptionalT...
[ERROR] OptionalCreatorParametersTest.testPrimitiveTypesDefaultValues:77 » Jsonb Primi...
[ERROR] NumberFormatCustomizationTest.testNumberFormatAccessors:138 » Jsonb AccessorCu...
[ERROR] AnnotationTypeInfoTest.testCreatorDeserialization:83 » IllegalArgument Invalid...
[ERROR] JSONBSigTest.signatureTest:280 Fault JSONBSigTest.signatureTest() failed!, dif...
[INFO]
[ERROR] Tests run: 295, Failures: 6, Errors: 7, Skipped: 5
````
For JSONP, we have
````
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] ClientTests.jsonGeneratorStreamNotClosedTest:2106 The underlying stream is closed but it shouldn't because JSON object was not completed
[ERROR] ClientTests.jsonObjectBuilderBuildTest:1365 expected: <null> but was: <"value">
[ERROR] ClientTests.testDuplicateKeysFirst:3223 expected: <A> but was: <B>
[ERROR] ClientTests.testDuplicateKeysNone:3203 It is expected a JsonException
[ERROR] ClientTests.jsonProviderTest1:103 jsonProviderTest1 Failed ==> expected: <true> but was: <false>
[ERROR] ClientTests.jsonProviderTest11:343 jsonProviderTest11 Failed ==> expected: <true> but was: <false>
[ERROR] ClientTests.jsonProviderTest12:365 jsonProviderTest12 Failed ==> expected: <true> but was: <false>
[ERROR] ClientTests.jsonProviderTest13:388 jsonProviderTest13 Failed ==> expected: <true> but was: <false>
[ERROR] ClientTests.jsonProviderTest14:410 jsonProviderTest14 Failed ==> expected: <true> but was: <false>
[ERROR] ClientTests.jsonProviderTest15:433 jsonProviderTest15 Failed ==> expected: <true> but was: <false>
[ERROR] ClientTests.jsonProviderTest16:455 jsonProviderTest16 Failed ==> expected: <true> but was: <false>
[ERROR] ClientTests.jsonProviderTest17:477 jsonProviderTest17 Failed ==> expected: <true> but was: <false>
[ERROR] ClientTests.jsonProviderTest18:500 jsonProviderTest18 Failed ==> expected: <true> but was: <false>
[ERROR] ClientTests.jsonProviderTest2:132 jsonProviderTest2 Failed ==> expected: <true> but was: <false>
[ERROR] ClientTests.jsonProviderTest3:162 jsonProviderTest3 Failed ==> expected: <true> but was: <false>
[ERROR] ClientTests.jsonProviderTest4:181 jsonProviderTest4 Failed ==> expected: <true> but was: <false>
[ERROR] ClientTests.jsonProviderTest5:204 jsonProviderTest5 Failed ==> expected: <true> but was: <false>
[ERROR] ClientTests.jsonProviderTest6:227 jsonProviderTest5 Failed ==> expected: <true> but was: <false>
[ERROR] ClientTests.jsonProviderTest7:250 jsonProviderTest7 Failed ==> expected: <true> but was: <false>
[ERROR] ClientTests.jsonProviderTest8:273 jsonProviderTest8 Failed ==> expected: <true> but was: <false>
[ERROR] ClientTests.jsonProviderTest9:296 jsonProviderTest9 Failed ==> expected: <true> but was: <false>
[ERROR] Errors:
[ERROR] ClientTests.jsonParserCurrentEvent:1862 » UnsupportedOperation
[ERROR] ClientTests.jsonNumber21Test:347 » UnsupportedOperation 1 type is not known
[ERROR] JSONPSigTest.signatureTest:281 Fault JSONPSigTest.signatureTest() failed!, diffs found
[INFO]
[ERROR] Tests run: 197, Failures: 21, Errors: 3, Skipped: 0
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] jeanouii commented on pull request #98: WIP Jakarta EE 10 TCK setup
Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii commented on PR #98:
URL: https://github.com/apache/johnzon/pull/98#issuecomment-1520734663
I'd say we don't break for breaking.
If we really need to break, now is the good/best time to do it because we already have a breaking change with Jakarta and a couple of other things. Better to do it now at once and not later.
Romain, can you elaborate?
I'm happy to challenge the test if I can get some context and more precise thoughts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rmannibucau commented on pull request #98: WIP Jakarta EE 10 TCK setup
Posted by "rmannibucau (via GitHub)" <gi...@apache.org>.
rmannibucau commented on PR #98:
URL: https://github.com/apache/johnzon/pull/98#issuecomment-1516228531
While it does not break the build there is no issue, fine to merge with a property `tck.skip` (or alike) if it breaks the build by default and if it helps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] jeanouii commented on pull request #98: WIP Jakarta EE 10 TCK setup
Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii commented on PR #98:
URL: https://github.com/apache/johnzon/pull/98#issuecomment-1520612689
Running the suite locally to see how it looks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org