You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/06/29 11:24:36 UTC
[GitHub] [camel] aldettinger opened a new pull request, #7928: CAMEL-18246: Upgrade hadoop-common >= 2.10.2, 3.3.3
aldettinger opened a new pull request, #7928:
URL: https://github.com/apache/camel/pull/7928
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7928: CAMEL-18246: Upgrade hadoop-common >= 2.10.2, 3.3.3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7928:
URL: https://github.com/apache/camel/pull/7928#issuecomment-1169917218
:heavy_check_mark: Finished component verification: 0 component(s) test failed out of **1 component(s) tested**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] aldettinger commented on pull request #7928: CAMEL-18246: Upgrade hadoop-common >= 2.10.2, 3.3.3
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #7928:
URL: https://github.com/apache/camel/pull/7928#issuecomment-1169924210
The dependency review states that it's still affected: https://github.com/advisories/GHSA-gx2c-fvhc-ph4j
It may be a false positive, still I prefer to double-check that it's fixed in 2.10.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] aldettinger merged pull request #7928: CAMEL-18246: Upgrade hadoop-common >= 2.10.2, 3.3.3
Posted by GitBox <gi...@apache.org>.
aldettinger merged PR #7928:
URL: https://github.com/apache/camel/pull/7928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7928: CAMEL-18246: Upgrade hadoop-common >= 2.10.2, 3.3.3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7928:
URL: https://github.com/apache/camel/pull/7928#issuecomment-1169863233
:warning: This PR changes Camel components and will be tested automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #7928: CAMEL-18246: Upgrade hadoop-common >= 2.10.2, 3.3.3
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #7928:
URL: https://github.com/apache/camel/pull/7928#issuecomment-1170232518
I think we can merge this as its good to upgrade on main branch. Then you can follow up with new PRs for more work if needed.
Is that okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] aldettinger commented on pull request #7928: CAMEL-18246: Upgrade hadoop-common >= 2.10.2, 3.3.3
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #7928:
URL: https://github.com/apache/camel/pull/7928#issuecomment-1172018714
Ok, let's revert and I should probably have time to respin this next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #7928: CAMEL-18246: Upgrade hadoop-common >= 2.10.2, 3.3.3
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #7928:
URL: https://github.com/apache/camel/pull/7928#issuecomment-1172002864
Yeah its fine to revert and then fixes can come in patch releases in the near future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #7928: CAMEL-18246: Upgrade hadoop-common >= 2.10.2, 3.3.3
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #7928:
URL: https://github.com/apache/camel/pull/7928#issuecomment-1171375530
Ah yeah we can revert
It may be worth to check that the 2.10.2 in test-infra-hbase aligns so every dependency it uses are 2.10.2 also, as mixed versions could maybe cause this problem.
Also we can try to keep the 3.3.3 upgrade but revert the 2.10.x upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #7928: CAMEL-18246: Upgrade hadoop-common >= 2.10.2, 3.3.3
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #7928:
URL: https://github.com/apache/camel/pull/7928#issuecomment-1171990366
> Oh, you mean even upgrading to hadoop-common 2.10.2 from this pr has broken the build. Shouldn't we both revert AND investigate the fix then ?
Yeah, so per CI, it seems this one broke the hbase tests. I am fine with both approaches, although I don't really know how much time we have for 3.18.0 release (I guess we need to finish all the remaining fixes today).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #7928: CAMEL-18246: Upgrade hadoop-common >= 2.10.2, 3.3.3
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #7928:
URL: https://github.com/apache/camel/pull/7928#issuecomment-1171272158
@davsclaus @aldettinger I was talking to @aldettinger earlier today and I think this upgrade has broken the hbase component.
We probably need to decide if we want to revert the upgrade or if there's still time to investigate and fix it:
- Before: https://ci-builds.apache.org/job/Camel/job/Apache%20Camel/job/main/437/testReport/org.apache.camel.component.hbase/
- After: https://ci-builds.apache.org/job/Camel/job/Apache%20Camel/job/main/438/testReport/org.apache.camel.component.hbase/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] aldettinger commented on pull request #7928: CAMEL-18246: Upgrade hadoop-common >= 2.10.2, 3.3.3
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #7928:
URL: https://github.com/apache/camel/pull/7928#issuecomment-1170284618
Ok, let's merge then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org