You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Balázs Donát Bessenyei <be...@apache.org> on 2017/03/15 13:12:03 UTC
Re: Review Request 52279: FLUME-2917 Provide netcat UDP source as
alternative to TCP
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52279/#review168996
-----------------------------------------------------------
Fix it, then Ship it!
Other than the SourceConfiguration change, LGTM
flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java
Lines 224 (patched)
<https://reviews.apache.org/r/52279/#comment241324>
For me, this only works with
NETCATUDP("org.apache.flume.conf.source.NetcatUdpSourceConfiguration"),
- Bal�zs Don�t Bessenyei
On Feb. 22, 2017, 11:10 p.m., Tristan Stevens wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52279/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 11:10 p.m.)
>
>
> Review request for Flume and Bal�zs Don�t Bessenyei.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Implementation is heavily based on the existing SyslogUDPSource - the tests and implementation mirror that. We could consider making it a superclass of SyslogUDPSource and removing the syslog parsing, if this was felt tidier.
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java 6bd1489
> flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java 4f4073a
> flume-ng-core/src/main/java/org/apache/flume/source/NetcatUdpSource.java PRE-CREATION
> flume-ng-core/src/test/java/org/apache/flume/source/TestDefaultSourceFactory.java baa8500
> flume-ng-core/src/test/java/org/apache/flume/source/TestNetcatUdpSource.java PRE-CREATION
> flume-ng-doc/sphinx/FlumeUserGuide.rst d863068
>
>
> Diff: https://reviews.apache.org/r/52279/diff/6/
>
>
> Testing
> -------
>
> Unit tests provided.
>
>
> Thanks,
>
> Tristan Stevens
>
>