You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by denys kuzmenko via Review Board <no...@reviews.apache.org> on 2018/08/27 12:48:10 UTC
Review Request 68523: Improve
org.apache.hadoop.hive.ql.exec.FunctionTask Experience
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68523/
-----------------------------------------------------------
Review request for hive, Marta Kuczora and Peter Vary.
Bugs: HIVE-20466
https://issues.apache.org/jira/browse/HIVE-20466
Repository: hive-git
Description
-------
When a create function statement is submitted, it may fail with the following error:
Error while processing statement: FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.FunctionTask
This is not a user-friendly error message.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 44591842bb
ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java 6f8a8f5504
ql/src/test/queries/clientnegative/create_unknown_permanent_udf.q PRE-CREATION
ql/src/test/results/clientnegative/create_unknown_permanent_udf.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/68523/diff/1/
Testing
-------
added negative qtest to cover this scenario
Thanks,
denys kuzmenko
Re: Review Request 68523: Improve
org.apache.hadoop.hive.ql.exec.FunctionTask Experience
Posted by Peter Vary via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68523/#review208033
-----------------------------------------------------------
Thanks for the patch.
LGTM, just one question regarding the tests.
Thanks,
Peter
ql/src/test/queries/clientnegative/create_unknown_permanent_udf.q
Lines 1 (patched)
<https://reviews.apache.org/r/68523/#comment291769>
What is the difference between the create_function_nonexistent_class.q and this new test?
Do we need both?
- Peter Vary
On aug. 28, 2018, 1:50 du, denys kuzmenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68523/
> -----------------------------------------------------------
>
> (Updated aug. 28, 2018, 1:50 du)
>
>
> Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita.
>
>
> Bugs: HIVE-20466
> https://issues.apache.org/jira/browse/HIVE-20466
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> When a create function statement is submitted, it may fail with the following error:
>
> Error while processing statement: FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.FunctionTask
>
> This is not a user-friendly error message.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 44591842bb
> ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java 6f8a8f5504
> ql/src/test/queries/clientnegative/create_unknown_permanent_udf.q PRE-CREATION
> ql/src/test/results/clientnegative/create_function_nonexistent_class.q.out 77467f66e3
> ql/src/test/results/clientnegative/create_unknown_permanent_udf.q.out PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68523/diff/2/
>
>
> Testing
> -------
>
> added negative qtest to cover this scenario
>
>
> Thanks,
>
> denys kuzmenko
>
>
Re: Review Request 68523: Improve
org.apache.hadoop.hive.ql.exec.FunctionTask Experience
Posted by denys kuzmenko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68523/
-----------------------------------------------------------
(Updated Sept. 17, 2018, 3:24 p.m.)
Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita.
Bugs: HIVE-20466
https://issues.apache.org/jira/browse/HIVE-20466
Repository: hive-git
Description
-------
When a create function statement is submitted, it may fail with the following error:
Error while processing statement: FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.FunctionTask
This is not a user-friendly error message.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 44591842bb
ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java 6f8a8f5504
ql/src/test/results/clientnegative/create_function_nonexistent_class.q.out 77467f66e3
Diff: https://reviews.apache.org/r/68523/diff/3/
Changes: https://reviews.apache.org/r/68523/diff/2-3/
Testing
-------
added negative qtest to cover this scenario
Thanks,
denys kuzmenko
Re: Review Request 68523: Improve
org.apache.hadoop.hive.ql.exec.FunctionTask Experience
Posted by denys kuzmenko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68523/
-----------------------------------------------------------
(Updated Aug. 28, 2018, 1:50 p.m.)
Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita.
Bugs: HIVE-20466
https://issues.apache.org/jira/browse/HIVE-20466
Repository: hive-git
Description
-------
When a create function statement is submitted, it may fail with the following error:
Error while processing statement: FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.FunctionTask
This is not a user-friendly error message.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 44591842bb
ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java 6f8a8f5504
ql/src/test/queries/clientnegative/create_unknown_permanent_udf.q PRE-CREATION
ql/src/test/results/clientnegative/create_function_nonexistent_class.q.out 77467f66e3
ql/src/test/results/clientnegative/create_unknown_permanent_udf.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/68523/diff/2/
Changes: https://reviews.apache.org/r/68523/diff/1-2/
Testing
-------
added negative qtest to cover this scenario
Thanks,
denys kuzmenko