You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/12/18 01:13:07 UTC

[GitHub] [samza] kw2542 opened a new pull request #1237: SAMZA-2406: Add ConfigLoader, ConfigLoaderFactory interface and default PropertiesConfigLoader as well as PropertiesConfigLoaderFactory implementations.

kw2542 opened a new pull request #1237: SAMZA-2406: Add ConfigLoader, ConfigLoaderFactory interface and default PropertiesConfigLoader as well as PropertiesConfigLoaderFactory implementations.
URL: https://github.com/apache/samza/pull/1237
 
 
   Add ConfigLoader, ConfigLoaderFactory interface and default PropertiesConfigLoader as well as PropertiesConfigLoaderFactory implementations, which will be used on AM to fetch configs. It will also be used on LocalApplicationRunner to fetch configs as well.
   
   The existing ConfigFactory interface will be deprecated and removed as we do not fetch configs on start up script run-app.sh anymore.
   
   Design:
   https://cwiki.apache.org/confluence/display/SAMZA/SEP-23%3A+Simplify+Job+Runner
   
   Changes:
   
   1. Add ConfigLoader interface which will be used in job coordinator to retrieve config from.
   2. Add ConfigLoaderFactory interface which will be used to create an instance of ConfigLoader.
   3. Add PropertiesConfigLoader which is a default implementation of ConfigLoader that reads a local properties file given the file path.
   4. Add PropertiesConfigLoaderFactory which is a default implementation of ConfigLoaderFactory that reads properties file path from start up config and creates a PropertiesConfigLoader with the provided path.
   API Changes:
   
     N/A. This is part of a series PRs, detailed information will be provided in the last/main PR.
   Upgrade Instructions:
     N/A. This is part of a series PRs, detailed information will be provided in the last/main PR.
   Usage Instructions:
     N/A. This is part of a series PRs, detailed information will be provided in the last/main PR.
   
   Tests:
   
   Add TestPropertiesConfigLoader to unit test PropertiesConfigLoader.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services