You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2023/01/03 18:50:38 UTC
[GitHub] [iceberg] rdblue commented on a diff in pull request #6432: Consider moving to ParallelIterable in Deletes::toPositionIndex
rdblue commented on code in PR #6432:
URL: https://github.com/apache/iceberg/pull/6432#discussion_r1060863547
##########
core/src/main/java/org/apache/iceberg/util/ThreadPools.java:
##########
@@ -56,6 +56,22 @@ public static ExecutorService getWorkerPool() {
return WORKER_POOL;
}
+ /**
+ * Returns delete worker pool for Positional Deletes.
+ *
+ * <p>Size of this thread-pool is controlled by System Property {@code
+ * iceberg.delete.pos.read-worker-pool}.
+ *
+ * @return {@link ExecutorService} that is delete worker pool
+ */
+ public static ExecutorService newDeleteWorkerPool() {
Review Comment:
If this is going to behave like the worker pool, then it should also be a static, shared pool. Otherwise, this will create multiple pools that have the same name.
It should either behave like the existing `getWorkerPool` or like the existing `newWorkerPool` that requires a name.
##########
core/src/main/java/org/apache/iceberg/util/ThreadPools.java:
##########
@@ -56,6 +56,22 @@ public static ExecutorService getWorkerPool() {
return WORKER_POOL;
}
+ /**
+ * Returns delete worker pool for Positional Deletes.
+ *
+ * <p>Size of this thread-pool is controlled by System Property {@code
+ * iceberg.delete.pos.read-worker-pool}.
+ *
+ * @return {@link ExecutorService} that is delete worker pool
+ */
+ public static ExecutorService newDeleteWorkerPool() {
Review Comment:
If this is going to behave like the worker pool, then it should also be a static, shared pool. Otherwise, this will create multiple pools that have the same name.
It should either behave like the existing `getWorkerPool` or like the existing `newWorkerPool` that requires a name and a size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org