You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2016/12/02 01:36:55 UTC
[GitHub] incubator-beam pull request #1487: Stop using Maps of Transforms in the Dire...
GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/1487
Stop using Maps of Transforms in the DirectRunner
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
Instead, add a "DirectGraph" class, which adds a layer of indirection to
all lookup methods.
Remove all remaining uses of getProducingTransformInternal, and instead
use DirectGraph methods to obtain the producing transform.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam producers_consumers_as_datastructure
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1487.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1487
----
commit 4f54fa66117f8f6e73827be68dc4b7000b9d1a90
Author: Thomas Groh <tg...@google.com>
Date: 2016-12-01T23:39:30Z
Stop using Maps of Transforms in the DirectRunner
Instead, add a "DirectGraph" class, which adds a layer of indirection to
all lookup methods.
Remove all remaining uses of getProducingTransformInternal, and instead
use DirectGraph methods to obtain the producing transform.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #1487: [BEAM-646] Stop using Maps of Transforms ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/1487
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---