You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/05/04 12:37:59 UTC

[GitHub] [activemq-artemis] bhaveshkharwa opened a new pull request #3113: ARTEMIS-2445 : fix issue of large message lost on divert

bhaveshkharwa opened a new pull request #3113:
URL: https://github.com/apache/activemq-artemis/pull/3113


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] jbertram commented on pull request #3113: ARTEMIS-2445 : fix issue of large message lost on divert

Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3113:
URL: https://github.com/apache/activemq-artemis/pull/3113#issuecomment-631764626


   I'm closing this for now. Please re-open when you are able to provide a valid test in the test-suite to validate the fix and prevent future regressions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3113: ARTEMIS-2445 : fix issue of large message lost on divert

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3113:
URL: https://github.com/apache/activemq-artemis/pull/3113#discussion_r419449643



##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java
##########
@@ -81,7 +81,7 @@
    // We use properties to establish routing context on clustering.
    // However if the client resends the message after receiving, it needs to be removed, so we mark these internal
    Predicate<SimpleString> INTERNAL_PROPERTY_NAMES_PREDICATE =
-      name -> (name.startsWith(Message.HDR_ROUTE_TO_IDS) && !name.equals(Message.HDR_ROUTE_TO_IDS)) ||

Review comment:
       HDR_ROUTE_TO_IDS is used to transfer messages to a different cluster.
   
   Perhaps you had messages moving to a different cluster and thought they were lost.
   
   Without a proper test, this PR cannot be merged. If you have a real case you need to prove it at least.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] jbertram closed pull request #3113: ARTEMIS-2445 : fix issue of large message lost on divert

Posted by GitBox <gi...@apache.org>.
jbertram closed pull request #3113:
URL: https://github.com/apache/activemq-artemis/pull/3113


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org