Re: internal subset lost after using cloneNode (patch provided!)

[Jacob Kjome <ho...@visi.com>]

At 01:34 PM 8/28/2006, you wrote:
 >Jacob Kjome <ho...@visi.com> wrote on 08/24/2006 01:59:14 AM:
 >
 >>
 >> Sure enough, I looked at CoreDocumentImpl and importNode(Node,
 >> boolean, boolean, HashTable), where it deals with DOCUMENT_TYPE_NODE
 >> in the switch statement, and it doesn't copy the internal subset
 >> string from the srcdoctype to the newdoctype.  Adding the following
 >> line solves the issue...
 >>
 >> newdoctype.setInternalSubset(srcdoctype.getInternalSubset());
 >>
 >> I've reported the bug and attached a very simple patch.  I hope it
 >> can be applied for the next release!
 >
 >Thanks Jake. I've committed your patch to SVN.
 >
 >> http://issues.apache.org/jira/browse/XERCESJ-1181
 >>

Thanks Michael!

 >>
 >> I'm still curious about the Entity node that gets created as a child
 >> of the DocumentType.  Is that supposed to get created?  Is it necessary?
 >
 >Yes and yes. The entity map contains an Entity node for each of the
 >general entities declared in the DTD. The one Entity in the source
 >document is being copied into the cloned document.
 >

Ahhh...  Ok, Xerces1 didn't do that I don't think.

Jake

 >
 >Michael Glavassevich
 >XML Parser Development
 >IBM Toronto Lab
 >E-mail: mrglavas@ca.ibm.com
 >E-mail: mrglavas@apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: j-users-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-users-help@xerces.apache.org