You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/03 02:02:46 UTC

[GitHub] [beam] Abacn opened a new pull request, #23019: [Test] Decrease derby.locks.waitTimeout in jdbc unit test

Abacn opened a new pull request, #23019:
URL: https://github.com/apache/beam/pull/23019

   JdbcIO test now costs 5 min to run waiting for backoff of these two tests:
   
   ```
   testCustomFluentBackOffConfiguration	3 min 3 sec	Passed
   testWriteWithBackoff	1 min 3 sec	Passed
   ```
   
   Although in `@BeforeClass' the system property `derby.locks.waitTimeout` is set to 2, apparently it does not work when `JdbcIOExceptionHandlingParameterizedTest` is running at the same time. (Running JdbcIOTest class alone the running time is normal)
   
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on a diff in pull request #23019: [Test] Decrease derby.locks.waitTimeout in jdbc unit test

Posted by GitBox <gi...@apache.org>.
pabloem commented on code in PR #23019:
URL: https://github.com/apache/beam/pull/23019#discussion_r966150111


##########
sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOExceptionHandlingParameterizedTest.java:
##########
@@ -53,6 +54,14 @@ public class JdbcIOExceptionHandlingParameterizedTest {
           "org.apache.derby.jdbc.EmbeddedDriver", "jdbc:derby:memory:testDB;create=true");
   private static final DataSource DATA_SOURCE = DATA_SOURCE_CONFIGURATION.buildDatasource();
 
+  @BeforeClass
+  public static void beforeClass() {
+    // by default, derby uses a lock timeout of 60 seconds. In order to speed up the test
+    // and detect the lock faster, we decrease this timeout
+    System.setProperty("derby.locks.waitTimeout", "2");
+    System.setProperty("derby.stream.error.file", "build/derby.log");

Review Comment:
   huh ok thanks! lgtm!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #23019: [Test] Decrease derby.locks.waitTimeout in jdbc unit test

Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #23019:
URL: https://github.com/apache/beam/pull/23019#discussion_r966132451


##########
sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOExceptionHandlingParameterizedTest.java:
##########
@@ -53,6 +54,14 @@ public class JdbcIOExceptionHandlingParameterizedTest {
           "org.apache.derby.jdbc.EmbeddedDriver", "jdbc:derby:memory:testDB;create=true");
   private static final DataSource DATA_SOURCE = DATA_SOURCE_CONFIGURATION.buildDatasource();
 
+  @BeforeClass
+  public static void beforeClass() {
+    // by default, derby uses a lock timeout of 60 seconds. In order to speed up the test
+    // and detect the lock faster, we decrease this timeout
+    System.setProperty("derby.locks.waitTimeout", "2");
+    System.setProperty("derby.stream.error.file", "build/derby.log");

Review Comment:
   That would make JdbcIOTest stuck again. What happens is that the timeout setting set once in JdbcIOTest.beforeClass somehow gets reset if JdbcIOExceptionHandlingParameterizedTest is running, as both uses same embed derby server.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #23019: [Test] Decrease derby.locks.waitTimeout in jdbc unit test

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23019:
URL: https://github.com/apache/beam/pull/23019#issuecomment-1240918063

   lgtm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem merged pull request #23019: [Test] Decrease derby.locks.waitTimeout in jdbc unit test

Posted by GitBox <gi...@apache.org>.
pabloem merged PR #23019:
URL: https://github.com/apache/beam/pull/23019


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #23019: [Test] Decrease derby.locks.waitTimeout in jdbc unit test

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23019:
URL: https://github.com/apache/beam/pull/23019#issuecomment-1236028022

   master (https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/testReport/org.apache.beam.sdk.io.jdbc/)
   ```
   Test Result : org.apache.beam.sdk.io.jdbc
   0 failures (±0)
   63 tests (±0)
   Took 5 min 33 sec.
   
   testCustomFluentBackOffConfiguration	3 min 3 sec	Passed
   testWriteWithBackoff	1 min 3 sec	Passed
   ```
   
   This change:
   ```
   Test Result : org.apache.beam.sdk.io.jdbc
   0 failures (±0)
   63 tests (±0)
   Took 2 min 11 sec.
   
   testCustomFluentBackOffConfiguration	8.7 sec	Passed
   testWriteWithBackoff	7.5 sec	Passed
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #23019: [Test] Decrease derby.locks.waitTimeout in jdbc unit test

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23019:
URL: https://github.com/apache/beam/pull/23019#issuecomment-1240816901

   R: @pabloem  A minor jdbc test improvement


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #23019: [Test] Decrease derby.locks.waitTimeout in jdbc unit test

Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #23019:
URL: https://github.com/apache/beam/pull/23019#discussion_r966132451


##########
sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOExceptionHandlingParameterizedTest.java:
##########
@@ -53,6 +54,14 @@ public class JdbcIOExceptionHandlingParameterizedTest {
           "org.apache.derby.jdbc.EmbeddedDriver", "jdbc:derby:memory:testDB;create=true");
   private static final DataSource DATA_SOURCE = DATA_SOURCE_CONFIGURATION.buildDatasource();
 
+  @BeforeClass
+  public static void beforeClass() {
+    // by default, derby uses a lock timeout of 60 seconds. In order to speed up the test
+    // and detect the lock faster, we decrease this timeout
+    System.setProperty("derby.locks.waitTimeout", "2");
+    System.setProperty("derby.stream.error.file", "build/derby.log");

Review Comment:
   That would make JdbcIOTest stuck again. This piece of code already exists in JdbcIOTest.beforeClass. What happens is that the timeout setting set once in JdbcIOTest.beforeClass somehow gets reset if JdbcIOExceptionHandlingParameterizedTest is running, as both uses same embed derby server.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23019: [Test] Decrease derby.locks.waitTimeout in jdbc unit test

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23019:
URL: https://github.com/apache/beam/pull/23019#issuecomment-1240906464

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on a diff in pull request #23019: [Test] Decrease derby.locks.waitTimeout in jdbc unit test

Posted by GitBox <gi...@apache.org>.
pabloem commented on code in PR #23019:
URL: https://github.com/apache/beam/pull/23019#discussion_r966121811


##########
sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOExceptionHandlingParameterizedTest.java:
##########
@@ -53,6 +54,14 @@ public class JdbcIOExceptionHandlingParameterizedTest {
           "org.apache.derby.jdbc.EmbeddedDriver", "jdbc:derby:memory:testDB;create=true");
   private static final DataSource DATA_SOURCE = DATA_SOURCE_CONFIGURATION.buildDatasource();
 
+  @BeforeClass
+  public static void beforeClass() {
+    // by default, derby uses a lock timeout of 60 seconds. In order to speed up the test
+    // and detect the lock faster, we decrease this timeout
+    System.setProperty("derby.locks.waitTimeout", "2");
+    System.setProperty("derby.stream.error.file", "build/derby.log");

Review Comment:
   thanks Yi! I wonder if we should reset this value in an AfterClass method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23019: [Test] Decrease derby.locks.waitTimeout in jdbc unit test

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23019:
URL: https://github.com/apache/beam/pull/23019#issuecomment-1236033178

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @kileys for label java.
   R: @ahmedabu98 for label io.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org