You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/24 16:30:54 UTC
[GitHub] [arrow-datafusion] ovr opened a new pull request #1667: feat: Support quarter granularity in date_trunc function
ovr opened a new pull request #1667:
URL: https://github.com/apache/arrow-datafusion/pull/1667
# Which issue does this PR close?
Closes #.
# Rationale for this change
I saw PR https://github.com/apache/arrow-datafusion/pull/1381 from @PieterVanZyl-Dev , but I want to finish it.
# What changes are included in this PR?
Support for quarter granularity in `date_trunc` function.
# Are there any user-facing changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #1667: feat: Support quarter granularity in date_trunc function
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1667:
URL: https://github.com/apache/arrow-datafusion/pull/1667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #1667: feat: Support quarter granularity in date_trunc function
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1667:
URL: https://github.com/apache/arrow-datafusion/pull/1667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ovr commented on a change in pull request #1667: feat: Support quarter granularity in date_trunc function
Posted by GitBox <gi...@apache.org>.
ovr commented on a change in pull request #1667:
URL: https://github.com/apache/arrow-datafusion/pull/1667#discussion_r790932851
##########
File path: datafusion/src/physical_plan/datetime_expressions.rs
##########
@@ -186,6 +186,10 @@ pub fn make_now(
}
}
+fn quarter_month(date: &NaiveDateTime) -> u32 {
Review comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org