[GitHub] sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi…

[GitBox <gi...@apache.org>]

sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi…
URL: https://github.com/apache/drill/pull/1459#discussion_r221490803
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/RuntimeFilterVisitor.java
 ##########
 @@ -223,16 +223,16 @@ public Void visitJoin(JoinPrel prel, RFHelperHolder holder) throws RuntimeExcept
           right.accept(this, holder);
           boolean routeToForeman = holder.needToRouteToForeman();
           if (!routeToForeman) {
-            runtimeFilterDef.setSendToForeman(false);
+            runtimeFilterDef.setSendToForeman(!routeToForeman);
 
 Review comment:
   this should be `runtimeFilterDef.setSendToForeman(routeToForeman);` and correspondingly change for else condition. Also you don't need `if-else` block any more.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services