You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Steve Huston (JIRA)" <qp...@incubator.apache.org> on 2008/05/18 02:35:55 UTC

[jira] Created: (QPID-1070) Patch to allow configure options to set Boost header and lib locations

Patch to allow configure options to set Boost header and lib locations
----------------------------------------------------------------------

                 Key: QPID-1070
                 URL: https://issues.apache.org/jira/browse/QPID-1070
             Project: Qpid
          Issue Type: Bug
          Components: C++ Broker, C++ Client
    Affects Versions: M3
         Environment: RHEL 4
            Reporter: Steve Huston
            Priority: Minor


The default (at least in 1.35) Boost install locations are in /usr/local (/usr/local/include/boost-1_35/boost and /usr/local/lib). These locations are not searched by g++ without additional options. This patch allows the following options to be supplied to the configure script:

--with-boost=DIR
--with-boost-include=DIR
--with-boost-libdir=DIR

The patch also includes changes related to 1068 (the first section from line 26)
Index: configure.ac
===================================================================
--- configure.ac        (revision 657445)
+++ configure.ac        (working copy)
@@ -26,7 +26,8 @@

 # AM_MISSING_PROG([HELP2MAN], [help2man])
 AC_CHECK_PROG([HELP2MAN], [help2man], [help2man])
-test -z "$HELP2MAN" && AC_MSG_ERROR([Missing help2man installation (try "yum install help2man").])
+test -z "$HELP2MAN" && AC_MSG_WARN([Missing help2man installation. Man pages will not be generated.])
+AM_CONDITIONAL([GENERATE_MAN], [test X$HELP2MAN != X])

 AC_ARG_ENABLE(warnings,
 [  --enable-warnings   turn on lots of compiler warnings (recommended)],
@@ -132,6 +133,38 @@
 DOWNLOAD_URL=http://rhm.et.redhat.com/download
 AC_SUBST(DOWNLOAD_URL)

+# Allow Boost to be somewhere that requires compile and/or link options.
+qpid_BOOST_CPPFLAGS=""
+qpid_BOOST_LDFLAGS=""
+AC_ARG_WITH([boost],
+   AS_HELP_STRING([--with-boost@<:@=DIR@:>@],
+                 [root directory of Boost installation]),
+   [
+   qpid_boost_root="${withval}"
+   if test "${qpid_boost_root}" != yes; then
+       qpid_boost_include="${qpid_boost_root}/include"
+       qpid_boost_libdir="${qpid_boost_root}/lib"
+   fi
+   ])
+
+AC_ARG_WITH([boost-include],
+   AS_HELP_STRING([--with-boost-include=DIR],
+                  [specify exact directory for Boost headers]),
+   [qpid_boost_include="$withval"])
+
+AC_ARG_WITH([boost-libdir],
+   AS_HELP_STRING([--with-boost-libdir=DIR],
+                  [specify exact directory for Boost libraries]),
+   [qpid_boost_libdir="$withval"])
+
+if test "${qpid_boost_include}"; then
+   CPPFLAGS="$CPPFLAGS -I${qpid_boost_include}"
+fi
+
+if test "${qpid_boost_libdir}"; then
+   LDFLAGS="$LDFLAGS -L${qpid_boost_libdir}"
+fi
+
 # Check for headers from required devel kits.
 AC_CHECK_HEADERS([boost/shared_ptr.hpp uuid/uuid.h],,
   AC_MSG_ERROR([Missing required header files.]))


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (QPID-1070) Patch to allow configure options to set Boost header and lib locations

Posted by "Danushka Menikkumbura (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597774#action_12597774 ] 

Danushka Menikkumbura commented on QPID-1070:
---------------------------------------------

Hi Steve,
   I don't think this is an issue. Even in my case boost (1.35) is installed in to /usr/loca/*. Setting PKG_CONFIG_PATH sould resolve the issue you have mentioned.

Danushka

> Patch to allow configure options to set Boost header and lib locations
> ----------------------------------------------------------------------
>
>                 Key: QPID-1070
>                 URL: https://issues.apache.org/jira/browse/QPID-1070
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client
>    Affects Versions: M3
>         Environment: RHEL 4
>            Reporter: Steve Huston
>            Priority: Minor
>
> The default (at least in 1.35) Boost install locations are in /usr/local (/usr/local/include/boost-1_35/boost and /usr/local/lib). These locations are not searched by g++ without additional options. This patch allows the following options to be supplied to the configure script:
> --with-boost=DIR
> --with-boost-include=DIR
> --with-boost-libdir=DIR
> The patch also includes changes related to 1068 (the first section from line 26)
> Index: configure.ac
> ===================================================================
> --- configure.ac        (revision 657445)
> +++ configure.ac        (working copy)
> @@ -26,7 +26,8 @@
>  # AM_MISSING_PROG([HELP2MAN], [help2man])
>  AC_CHECK_PROG([HELP2MAN], [help2man], [help2man])
> -test -z "$HELP2MAN" && AC_MSG_ERROR([Missing help2man installation (try "yum install help2man").])
> +test -z "$HELP2MAN" && AC_MSG_WARN([Missing help2man installation. Man pages will not be generated.])
> +AM_CONDITIONAL([GENERATE_MAN], [test X$HELP2MAN != X])
>  AC_ARG_ENABLE(warnings,
>  [  --enable-warnings   turn on lots of compiler warnings (recommended)],
> @@ -132,6 +133,38 @@
>  DOWNLOAD_URL=http://rhm.et.redhat.com/download
>  AC_SUBST(DOWNLOAD_URL)
> +# Allow Boost to be somewhere that requires compile and/or link options.
> +qpid_BOOST_CPPFLAGS=""
> +qpid_BOOST_LDFLAGS=""
> +AC_ARG_WITH([boost],
> +   AS_HELP_STRING([--with-boost@<:@=DIR@:>@],
> +                 [root directory of Boost installation]),
> +   [
> +   qpid_boost_root="${withval}"
> +   if test "${qpid_boost_root}" != yes; then
> +       qpid_boost_include="${qpid_boost_root}/include"
> +       qpid_boost_libdir="${qpid_boost_root}/lib"
> +   fi
> +   ])
> +
> +AC_ARG_WITH([boost-include],
> +   AS_HELP_STRING([--with-boost-include=DIR],
> +                  [specify exact directory for Boost headers]),
> +   [qpid_boost_include="$withval"])
> +
> +AC_ARG_WITH([boost-libdir],
> +   AS_HELP_STRING([--with-boost-libdir=DIR],
> +                  [specify exact directory for Boost libraries]),
> +   [qpid_boost_libdir="$withval"])
> +
> +if test "${qpid_boost_include}"; then
> +   CPPFLAGS="$CPPFLAGS -I${qpid_boost_include}"
> +fi
> +
> +if test "${qpid_boost_libdir}"; then
> +   LDFLAGS="$LDFLAGS -L${qpid_boost_libdir}"
> +fi
> +
>  # Check for headers from required devel kits.
>  AC_CHECK_HEADERS([boost/shared_ptr.hpp uuid/uuid.h],,
>    AC_MSG_ERROR([Missing required header files.]))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (QPID-1070) Patch to allow configure options to set Boost header and lib locations

Posted by "Danushka Menikkumbura (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597774#action_12597774 ] 

danushka edited comment on QPID-1070 at 5/17/08 7:00 PM:
----------------------------------------------------------------------

Hi Steve,
   I don't think this is required. Even in my case boost (1.35) is installed in to /usr/loca/*. Setting PKG_CONFIG_PATH sould resolve the issue you have mentioned.

Danushka

      was (Author: danushka):
    Hi Steve,
   I don't think this is an issue. Even in my case boost (1.35) is installed in to /usr/loca/*. Setting PKG_CONFIG_PATH sould resolve the issue you have mentioned.

Danushka
  
> Patch to allow configure options to set Boost header and lib locations
> ----------------------------------------------------------------------
>
>                 Key: QPID-1070
>                 URL: https://issues.apache.org/jira/browse/QPID-1070
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client
>    Affects Versions: M3
>         Environment: RHEL 4
>            Reporter: Steve Huston
>            Priority: Minor
>
> The default (at least in 1.35) Boost install locations are in /usr/local (/usr/local/include/boost-1_35/boost and /usr/local/lib). These locations are not searched by g++ without additional options. This patch allows the following options to be supplied to the configure script:
> --with-boost=DIR
> --with-boost-include=DIR
> --with-boost-libdir=DIR
> The patch also includes changes related to 1068 (the first section from line 26)
> Index: configure.ac
> ===================================================================
> --- configure.ac        (revision 657445)
> +++ configure.ac        (working copy)
> @@ -26,7 +26,8 @@
>  # AM_MISSING_PROG([HELP2MAN], [help2man])
>  AC_CHECK_PROG([HELP2MAN], [help2man], [help2man])
> -test -z "$HELP2MAN" && AC_MSG_ERROR([Missing help2man installation (try "yum install help2man").])
> +test -z "$HELP2MAN" && AC_MSG_WARN([Missing help2man installation. Man pages will not be generated.])
> +AM_CONDITIONAL([GENERATE_MAN], [test X$HELP2MAN != X])
>  AC_ARG_ENABLE(warnings,
>  [  --enable-warnings   turn on lots of compiler warnings (recommended)],
> @@ -132,6 +133,38 @@
>  DOWNLOAD_URL=http://rhm.et.redhat.com/download
>  AC_SUBST(DOWNLOAD_URL)
> +# Allow Boost to be somewhere that requires compile and/or link options.
> +qpid_BOOST_CPPFLAGS=""
> +qpid_BOOST_LDFLAGS=""
> +AC_ARG_WITH([boost],
> +   AS_HELP_STRING([--with-boost@<:@=DIR@:>@],
> +                 [root directory of Boost installation]),
> +   [
> +   qpid_boost_root="${withval}"
> +   if test "${qpid_boost_root}" != yes; then
> +       qpid_boost_include="${qpid_boost_root}/include"
> +       qpid_boost_libdir="${qpid_boost_root}/lib"
> +   fi
> +   ])
> +
> +AC_ARG_WITH([boost-include],
> +   AS_HELP_STRING([--with-boost-include=DIR],
> +                  [specify exact directory for Boost headers]),
> +   [qpid_boost_include="$withval"])
> +
> +AC_ARG_WITH([boost-libdir],
> +   AS_HELP_STRING([--with-boost-libdir=DIR],
> +                  [specify exact directory for Boost libraries]),
> +   [qpid_boost_libdir="$withval"])
> +
> +if test "${qpid_boost_include}"; then
> +   CPPFLAGS="$CPPFLAGS -I${qpid_boost_include}"
> +fi
> +
> +if test "${qpid_boost_libdir}"; then
> +   LDFLAGS="$LDFLAGS -L${qpid_boost_libdir}"
> +fi
> +
>  # Check for headers from required devel kits.
>  AC_CHECK_HEADERS([boost/shared_ptr.hpp uuid/uuid.h],,
>    AC_MSG_ERROR([Missing required header files.]))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (QPID-1070) Patch to allow configure options to set Boost header and lib locations

Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Huston closed QPID-1070.
------------------------------

    Resolution: Invalid

Ah, ok. I should have RTFM more carefully. I'm closing this as invalid. Thank you for helping to resolve this.

> Patch to allow configure options to set Boost header and lib locations
> ----------------------------------------------------------------------
>
>                 Key: QPID-1070
>                 URL: https://issues.apache.org/jira/browse/QPID-1070
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client
>    Affects Versions: M3
>         Environment: RHEL 4
>            Reporter: Steve Huston
>            Assignee: Andrew Stitcher
>            Priority: Minor
>
> The default (at least in 1.35) Boost install locations are in /usr/local (/usr/local/include/boost-1_35/boost and /usr/local/lib). These locations are not searched by g++ without additional options. This patch allows the following options to be supplied to the configure script:
> --with-boost=DIR
> --with-boost-include=DIR
> --with-boost-libdir=DIR
> The patch also includes changes related to 1068 (the first section from line 26)
> Index: configure.ac
> ===================================================================
> --- configure.ac        (revision 657445)
> +++ configure.ac        (working copy)
> @@ -26,7 +26,8 @@
>  # AM_MISSING_PROG([HELP2MAN], [help2man])
>  AC_CHECK_PROG([HELP2MAN], [help2man], [help2man])
> -test -z "$HELP2MAN" && AC_MSG_ERROR([Missing help2man installation (try "yum install help2man").])
> +test -z "$HELP2MAN" && AC_MSG_WARN([Missing help2man installation. Man pages will not be generated.])
> +AM_CONDITIONAL([GENERATE_MAN], [test X$HELP2MAN != X])
>  AC_ARG_ENABLE(warnings,
>  [  --enable-warnings   turn on lots of compiler warnings (recommended)],
> @@ -132,6 +133,38 @@
>  DOWNLOAD_URL=http://rhm.et.redhat.com/download
>  AC_SUBST(DOWNLOAD_URL)
> +# Allow Boost to be somewhere that requires compile and/or link options.
> +qpid_BOOST_CPPFLAGS=""
> +qpid_BOOST_LDFLAGS=""
> +AC_ARG_WITH([boost],
> +   AS_HELP_STRING([--with-boost@<:@=DIR@:>@],
> +                 [root directory of Boost installation]),
> +   [
> +   qpid_boost_root="${withval}"
> +   if test "${qpid_boost_root}" != yes; then
> +       qpid_boost_include="${qpid_boost_root}/include"
> +       qpid_boost_libdir="${qpid_boost_root}/lib"
> +   fi
> +   ])
> +
> +AC_ARG_WITH([boost-include],
> +   AS_HELP_STRING([--with-boost-include=DIR],
> +                  [specify exact directory for Boost headers]),
> +   [qpid_boost_include="$withval"])
> +
> +AC_ARG_WITH([boost-libdir],
> +   AS_HELP_STRING([--with-boost-libdir=DIR],
> +                  [specify exact directory for Boost libraries]),
> +   [qpid_boost_libdir="$withval"])
> +
> +if test "${qpid_boost_include}"; then
> +   CPPFLAGS="$CPPFLAGS -I${qpid_boost_include}"
> +fi
> +
> +if test "${qpid_boost_libdir}"; then
> +   LDFLAGS="$LDFLAGS -L${qpid_boost_libdir}"
> +fi
> +
>  # Check for headers from required devel kits.
>  AC_CHECK_HEADERS([boost/shared_ptr.hpp uuid/uuid.h],,
>    AC_MSG_ERROR([Missing required header files.]))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (QPID-1070) Patch to allow configure options to set Boost header and lib locations

Posted by "Matthew Farrellee (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597773#action_12597773 ] 

Matthew Farrellee commented on QPID-1070:
-----------------------------------------

Looks good.

When someone applies this they may want to apply the help2man patch separately/first, which also looked good. Also, they should handle --without-boost with a warning/error since --without-boost won't build without boost, it'll just set qpid_boost_root to "no"


> Patch to allow configure options to set Boost header and lib locations
> ----------------------------------------------------------------------
>
>                 Key: QPID-1070
>                 URL: https://issues.apache.org/jira/browse/QPID-1070
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client
>    Affects Versions: M3
>         Environment: RHEL 4
>            Reporter: Steve Huston
>            Priority: Minor
>
> The default (at least in 1.35) Boost install locations are in /usr/local (/usr/local/include/boost-1_35/boost and /usr/local/lib). These locations are not searched by g++ without additional options. This patch allows the following options to be supplied to the configure script:
> --with-boost=DIR
> --with-boost-include=DIR
> --with-boost-libdir=DIR
> The patch also includes changes related to 1068 (the first section from line 26)
> Index: configure.ac
> ===================================================================
> --- configure.ac        (revision 657445)
> +++ configure.ac        (working copy)
> @@ -26,7 +26,8 @@
>  # AM_MISSING_PROG([HELP2MAN], [help2man])
>  AC_CHECK_PROG([HELP2MAN], [help2man], [help2man])
> -test -z "$HELP2MAN" && AC_MSG_ERROR([Missing help2man installation (try "yum install help2man").])
> +test -z "$HELP2MAN" && AC_MSG_WARN([Missing help2man installation. Man pages will not be generated.])
> +AM_CONDITIONAL([GENERATE_MAN], [test X$HELP2MAN != X])
>  AC_ARG_ENABLE(warnings,
>  [  --enable-warnings   turn on lots of compiler warnings (recommended)],
> @@ -132,6 +133,38 @@
>  DOWNLOAD_URL=http://rhm.et.redhat.com/download
>  AC_SUBST(DOWNLOAD_URL)
> +# Allow Boost to be somewhere that requires compile and/or link options.
> +qpid_BOOST_CPPFLAGS=""
> +qpid_BOOST_LDFLAGS=""
> +AC_ARG_WITH([boost],
> +   AS_HELP_STRING([--with-boost@<:@=DIR@:>@],
> +                 [root directory of Boost installation]),
> +   [
> +   qpid_boost_root="${withval}"
> +   if test "${qpid_boost_root}" != yes; then
> +       qpid_boost_include="${qpid_boost_root}/include"
> +       qpid_boost_libdir="${qpid_boost_root}/lib"
> +   fi
> +   ])
> +
> +AC_ARG_WITH([boost-include],
> +   AS_HELP_STRING([--with-boost-include=DIR],
> +                  [specify exact directory for Boost headers]),
> +   [qpid_boost_include="$withval"])
> +
> +AC_ARG_WITH([boost-libdir],
> +   AS_HELP_STRING([--with-boost-libdir=DIR],
> +                  [specify exact directory for Boost libraries]),
> +   [qpid_boost_libdir="$withval"])
> +
> +if test "${qpid_boost_include}"; then
> +   CPPFLAGS="$CPPFLAGS -I${qpid_boost_include}"
> +fi
> +
> +if test "${qpid_boost_libdir}"; then
> +   LDFLAGS="$LDFLAGS -L${qpid_boost_libdir}"
> +fi
> +
>  # Check for headers from required devel kits.
>  AC_CHECK_HEADERS([boost/shared_ptr.hpp uuid/uuid.h],,
>    AC_MSG_ERROR([Missing required header files.]))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (QPID-1070) Patch to allow configure options to set Boost header and lib locations

Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598055#action_12598055 ] 

Andrew Stitcher commented on QPID-1070:
---------------------------------------

I assume that this was from a self installed boost 1.35 as the packager versions I'm familiar with (Ubuntu and Fedora/Red Hat) install boost in places that will be found by a stock configure.

I also note that boost doesn't include a boost.pc file to be installed in $(prefix)/lib/pkgconfig so unfortunately the pkgconfig tools aren't going to help here.

> Patch to allow configure options to set Boost header and lib locations
> ----------------------------------------------------------------------
>
>                 Key: QPID-1070
>                 URL: https://issues.apache.org/jira/browse/QPID-1070
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client
>    Affects Versions: M3
>         Environment: RHEL 4
>            Reporter: Steve Huston
>            Assignee: Andrew Stitcher
>            Priority: Minor
>
> The default (at least in 1.35) Boost install locations are in /usr/local (/usr/local/include/boost-1_35/boost and /usr/local/lib). These locations are not searched by g++ without additional options. This patch allows the following options to be supplied to the configure script:
> --with-boost=DIR
> --with-boost-include=DIR
> --with-boost-libdir=DIR
> The patch also includes changes related to 1068 (the first section from line 26)
> Index: configure.ac
> ===================================================================
> --- configure.ac        (revision 657445)
> +++ configure.ac        (working copy)
> @@ -26,7 +26,8 @@
>  # AM_MISSING_PROG([HELP2MAN], [help2man])
>  AC_CHECK_PROG([HELP2MAN], [help2man], [help2man])
> -test -z "$HELP2MAN" && AC_MSG_ERROR([Missing help2man installation (try "yum install help2man").])
> +test -z "$HELP2MAN" && AC_MSG_WARN([Missing help2man installation. Man pages will not be generated.])
> +AM_CONDITIONAL([GENERATE_MAN], [test X$HELP2MAN != X])
>  AC_ARG_ENABLE(warnings,
>  [  --enable-warnings   turn on lots of compiler warnings (recommended)],
> @@ -132,6 +133,38 @@
>  DOWNLOAD_URL=http://rhm.et.redhat.com/download
>  AC_SUBST(DOWNLOAD_URL)
> +# Allow Boost to be somewhere that requires compile and/or link options.
> +qpid_BOOST_CPPFLAGS=""
> +qpid_BOOST_LDFLAGS=""
> +AC_ARG_WITH([boost],
> +   AS_HELP_STRING([--with-boost@<:@=DIR@:>@],
> +                 [root directory of Boost installation]),
> +   [
> +   qpid_boost_root="${withval}"
> +   if test "${qpid_boost_root}" != yes; then
> +       qpid_boost_include="${qpid_boost_root}/include"
> +       qpid_boost_libdir="${qpid_boost_root}/lib"
> +   fi
> +   ])
> +
> +AC_ARG_WITH([boost-include],
> +   AS_HELP_STRING([--with-boost-include=DIR],
> +                  [specify exact directory for Boost headers]),
> +   [qpid_boost_include="$withval"])
> +
> +AC_ARG_WITH([boost-libdir],
> +   AS_HELP_STRING([--with-boost-libdir=DIR],
> +                  [specify exact directory for Boost libraries]),
> +   [qpid_boost_libdir="$withval"])
> +
> +if test "${qpid_boost_include}"; then
> +   CPPFLAGS="$CPPFLAGS -I${qpid_boost_include}"
> +fi
> +
> +if test "${qpid_boost_libdir}"; then
> +   LDFLAGS="$LDFLAGS -L${qpid_boost_libdir}"
> +fi
> +
>  # Check for headers from required devel kits.
>  AC_CHECK_HEADERS([boost/shared_ptr.hpp uuid/uuid.h],,
>    AC_MSG_ERROR([Missing required header files.]))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (QPID-1070) Patch to allow configure options to set Boost header and lib locations

Posted by "Carl Trieloff (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598074#action_12598074 ] 

Carl Trieloff commented on QPID-1070:
-------------------------------------


That is funny, I just checked a RHEL4 build and it is clean. are you upto date with updates on RHEL4?

> Patch to allow configure options to set Boost header and lib locations
> ----------------------------------------------------------------------
>
>                 Key: QPID-1070
>                 URL: https://issues.apache.org/jira/browse/QPID-1070
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client
>    Affects Versions: M3
>         Environment: RHEL 4
>            Reporter: Steve Huston
>            Assignee: Andrew Stitcher
>            Priority: Minor
>
> The default (at least in 1.35) Boost install locations are in /usr/local (/usr/local/include/boost-1_35/boost and /usr/local/lib). These locations are not searched by g++ without additional options. This patch allows the following options to be supplied to the configure script:
> --with-boost=DIR
> --with-boost-include=DIR
> --with-boost-libdir=DIR
> The patch also includes changes related to 1068 (the first section from line 26)
> Index: configure.ac
> ===================================================================
> --- configure.ac        (revision 657445)
> +++ configure.ac        (working copy)
> @@ -26,7 +26,8 @@
>  # AM_MISSING_PROG([HELP2MAN], [help2man])
>  AC_CHECK_PROG([HELP2MAN], [help2man], [help2man])
> -test -z "$HELP2MAN" && AC_MSG_ERROR([Missing help2man installation (try "yum install help2man").])
> +test -z "$HELP2MAN" && AC_MSG_WARN([Missing help2man installation. Man pages will not be generated.])
> +AM_CONDITIONAL([GENERATE_MAN], [test X$HELP2MAN != X])
>  AC_ARG_ENABLE(warnings,
>  [  --enable-warnings   turn on lots of compiler warnings (recommended)],
> @@ -132,6 +133,38 @@
>  DOWNLOAD_URL=http://rhm.et.redhat.com/download
>  AC_SUBST(DOWNLOAD_URL)
> +# Allow Boost to be somewhere that requires compile and/or link options.
> +qpid_BOOST_CPPFLAGS=""
> +qpid_BOOST_LDFLAGS=""
> +AC_ARG_WITH([boost],
> +   AS_HELP_STRING([--with-boost@<:@=DIR@:>@],
> +                 [root directory of Boost installation]),
> +   [
> +   qpid_boost_root="${withval}"
> +   if test "${qpid_boost_root}" != yes; then
> +       qpid_boost_include="${qpid_boost_root}/include"
> +       qpid_boost_libdir="${qpid_boost_root}/lib"
> +   fi
> +   ])
> +
> +AC_ARG_WITH([boost-include],
> +   AS_HELP_STRING([--with-boost-include=DIR],
> +                  [specify exact directory for Boost headers]),
> +   [qpid_boost_include="$withval"])
> +
> +AC_ARG_WITH([boost-libdir],
> +   AS_HELP_STRING([--with-boost-libdir=DIR],
> +                  [specify exact directory for Boost libraries]),
> +   [qpid_boost_libdir="$withval"])
> +
> +if test "${qpid_boost_include}"; then
> +   CPPFLAGS="$CPPFLAGS -I${qpid_boost_include}"
> +fi
> +
> +if test "${qpid_boost_libdir}"; then
> +   LDFLAGS="$LDFLAGS -L${qpid_boost_libdir}"
> +fi
> +
>  # Check for headers from required devel kits.
>  AC_CHECK_HEADERS([boost/shared_ptr.hpp uuid/uuid.h],,
>    AC_MSG_ERROR([Missing required header files.]))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (QPID-1070) Patch to allow configure options to set Boost header and lib locations

Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Stitcher reassigned QPID-1070:
-------------------------------------

    Assignee: Andrew Stitcher

> Patch to allow configure options to set Boost header and lib locations
> ----------------------------------------------------------------------
>
>                 Key: QPID-1070
>                 URL: https://issues.apache.org/jira/browse/QPID-1070
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client
>    Affects Versions: M3
>         Environment: RHEL 4
>            Reporter: Steve Huston
>            Assignee: Andrew Stitcher
>            Priority: Minor
>
> The default (at least in 1.35) Boost install locations are in /usr/local (/usr/local/include/boost-1_35/boost and /usr/local/lib). These locations are not searched by g++ without additional options. This patch allows the following options to be supplied to the configure script:
> --with-boost=DIR
> --with-boost-include=DIR
> --with-boost-libdir=DIR
> The patch also includes changes related to 1068 (the first section from line 26)
> Index: configure.ac
> ===================================================================
> --- configure.ac        (revision 657445)
> +++ configure.ac        (working copy)
> @@ -26,7 +26,8 @@
>  # AM_MISSING_PROG([HELP2MAN], [help2man])
>  AC_CHECK_PROG([HELP2MAN], [help2man], [help2man])
> -test -z "$HELP2MAN" && AC_MSG_ERROR([Missing help2man installation (try "yum install help2man").])
> +test -z "$HELP2MAN" && AC_MSG_WARN([Missing help2man installation. Man pages will not be generated.])
> +AM_CONDITIONAL([GENERATE_MAN], [test X$HELP2MAN != X])
>  AC_ARG_ENABLE(warnings,
>  [  --enable-warnings   turn on lots of compiler warnings (recommended)],
> @@ -132,6 +133,38 @@
>  DOWNLOAD_URL=http://rhm.et.redhat.com/download
>  AC_SUBST(DOWNLOAD_URL)
> +# Allow Boost to be somewhere that requires compile and/or link options.
> +qpid_BOOST_CPPFLAGS=""
> +qpid_BOOST_LDFLAGS=""
> +AC_ARG_WITH([boost],
> +   AS_HELP_STRING([--with-boost@<:@=DIR@:>@],
> +                 [root directory of Boost installation]),
> +   [
> +   qpid_boost_root="${withval}"
> +   if test "${qpid_boost_root}" != yes; then
> +       qpid_boost_include="${qpid_boost_root}/include"
> +       qpid_boost_libdir="${qpid_boost_root}/lib"
> +   fi
> +   ])
> +
> +AC_ARG_WITH([boost-include],
> +   AS_HELP_STRING([--with-boost-include=DIR],
> +                  [specify exact directory for Boost headers]),
> +   [qpid_boost_include="$withval"])
> +
> +AC_ARG_WITH([boost-libdir],
> +   AS_HELP_STRING([--with-boost-libdir=DIR],
> +                  [specify exact directory for Boost libraries]),
> +   [qpid_boost_libdir="$withval"])
> +
> +if test "${qpid_boost_include}"; then
> +   CPPFLAGS="$CPPFLAGS -I${qpid_boost_include}"
> +fi
> +
> +if test "${qpid_boost_libdir}"; then
> +   LDFLAGS="$LDFLAGS -L${qpid_boost_libdir}"
> +fi
> +
>  # Check for headers from required devel kits.
>  AC_CHECK_HEADERS([boost/shared_ptr.hpp uuid/uuid.h],,
>    AC_MSG_ERROR([Missing required header files.]))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (QPID-1070) Patch to allow configure options to set Boost header and lib locations

Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598061#action_12598061 ] 

Steve Huston commented on QPID-1070:
------------------------------------

Yes, it is a self-install. It's Red Hat Enterprise Linux 4, and the boost from Red Hat for RHEL 4 wouldn't build Qpid. Rather than figure out how to use the older boost, I grabbed a new one.

I'm not a autoconf wizard, so I'm not surprised there may be a better way to do this... if more experienced autoconf people have a suggestion, I'll rework the patch to do something better.


> Patch to allow configure options to set Boost header and lib locations
> ----------------------------------------------------------------------
>
>                 Key: QPID-1070
>                 URL: https://issues.apache.org/jira/browse/QPID-1070
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client
>    Affects Versions: M3
>         Environment: RHEL 4
>            Reporter: Steve Huston
>            Assignee: Andrew Stitcher
>            Priority: Minor
>
> The default (at least in 1.35) Boost install locations are in /usr/local (/usr/local/include/boost-1_35/boost and /usr/local/lib). These locations are not searched by g++ without additional options. This patch allows the following options to be supplied to the configure script:
> --with-boost=DIR
> --with-boost-include=DIR
> --with-boost-libdir=DIR
> The patch also includes changes related to 1068 (the first section from line 26)
> Index: configure.ac
> ===================================================================
> --- configure.ac        (revision 657445)
> +++ configure.ac        (working copy)
> @@ -26,7 +26,8 @@
>  # AM_MISSING_PROG([HELP2MAN], [help2man])
>  AC_CHECK_PROG([HELP2MAN], [help2man], [help2man])
> -test -z "$HELP2MAN" && AC_MSG_ERROR([Missing help2man installation (try "yum install help2man").])
> +test -z "$HELP2MAN" && AC_MSG_WARN([Missing help2man installation. Man pages will not be generated.])
> +AM_CONDITIONAL([GENERATE_MAN], [test X$HELP2MAN != X])
>  AC_ARG_ENABLE(warnings,
>  [  --enable-warnings   turn on lots of compiler warnings (recommended)],
> @@ -132,6 +133,38 @@
>  DOWNLOAD_URL=http://rhm.et.redhat.com/download
>  AC_SUBST(DOWNLOAD_URL)
> +# Allow Boost to be somewhere that requires compile and/or link options.
> +qpid_BOOST_CPPFLAGS=""
> +qpid_BOOST_LDFLAGS=""
> +AC_ARG_WITH([boost],
> +   AS_HELP_STRING([--with-boost@<:@=DIR@:>@],
> +                 [root directory of Boost installation]),
> +   [
> +   qpid_boost_root="${withval}"
> +   if test "${qpid_boost_root}" != yes; then
> +       qpid_boost_include="${qpid_boost_root}/include"
> +       qpid_boost_libdir="${qpid_boost_root}/lib"
> +   fi
> +   ])
> +
> +AC_ARG_WITH([boost-include],
> +   AS_HELP_STRING([--with-boost-include=DIR],
> +                  [specify exact directory for Boost headers]),
> +   [qpid_boost_include="$withval"])
> +
> +AC_ARG_WITH([boost-libdir],
> +   AS_HELP_STRING([--with-boost-libdir=DIR],
> +                  [specify exact directory for Boost libraries]),
> +   [qpid_boost_libdir="$withval"])
> +
> +if test "${qpid_boost_include}"; then
> +   CPPFLAGS="$CPPFLAGS -I${qpid_boost_include}"
> +fi
> +
> +if test "${qpid_boost_libdir}"; then
> +   LDFLAGS="$LDFLAGS -L${qpid_boost_libdir}"
> +fi
> +
>  # Check for headers from required devel kits.
>  AC_CHECK_HEADERS([boost/shared_ptr.hpp uuid/uuid.h],,
>    AC_MSG_ERROR([Missing required header files.]))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (QPID-1070) Patch to allow configure options to set Boost header and lib locations

Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598058#action_12598058 ] 

Andrew Stitcher commented on QPID-1070:
---------------------------------------

Thinking a bit more I think this patch is slightly awry:

Matt is correct that --without-boost is meaningless as it is a fixed dependency of the c++ build.

So I think that what is required here is a new --with-boost-prefix argument. Certainly using the --with-boost argument as a directory isn't the usual autoconf way (as far as I know).

> Patch to allow configure options to set Boost header and lib locations
> ----------------------------------------------------------------------
>
>                 Key: QPID-1070
>                 URL: https://issues.apache.org/jira/browse/QPID-1070
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client
>    Affects Versions: M3
>         Environment: RHEL 4
>            Reporter: Steve Huston
>            Assignee: Andrew Stitcher
>            Priority: Minor
>
> The default (at least in 1.35) Boost install locations are in /usr/local (/usr/local/include/boost-1_35/boost and /usr/local/lib). These locations are not searched by g++ without additional options. This patch allows the following options to be supplied to the configure script:
> --with-boost=DIR
> --with-boost-include=DIR
> --with-boost-libdir=DIR
> The patch also includes changes related to 1068 (the first section from line 26)
> Index: configure.ac
> ===================================================================
> --- configure.ac        (revision 657445)
> +++ configure.ac        (working copy)
> @@ -26,7 +26,8 @@
>  # AM_MISSING_PROG([HELP2MAN], [help2man])
>  AC_CHECK_PROG([HELP2MAN], [help2man], [help2man])
> -test -z "$HELP2MAN" && AC_MSG_ERROR([Missing help2man installation (try "yum install help2man").])
> +test -z "$HELP2MAN" && AC_MSG_WARN([Missing help2man installation. Man pages will not be generated.])
> +AM_CONDITIONAL([GENERATE_MAN], [test X$HELP2MAN != X])
>  AC_ARG_ENABLE(warnings,
>  [  --enable-warnings   turn on lots of compiler warnings (recommended)],
> @@ -132,6 +133,38 @@
>  DOWNLOAD_URL=http://rhm.et.redhat.com/download
>  AC_SUBST(DOWNLOAD_URL)
> +# Allow Boost to be somewhere that requires compile and/or link options.
> +qpid_BOOST_CPPFLAGS=""
> +qpid_BOOST_LDFLAGS=""
> +AC_ARG_WITH([boost],
> +   AS_HELP_STRING([--with-boost@<:@=DIR@:>@],
> +                 [root directory of Boost installation]),
> +   [
> +   qpid_boost_root="${withval}"
> +   if test "${qpid_boost_root}" != yes; then
> +       qpid_boost_include="${qpid_boost_root}/include"
> +       qpid_boost_libdir="${qpid_boost_root}/lib"
> +   fi
> +   ])
> +
> +AC_ARG_WITH([boost-include],
> +   AS_HELP_STRING([--with-boost-include=DIR],
> +                  [specify exact directory for Boost headers]),
> +   [qpid_boost_include="$withval"])
> +
> +AC_ARG_WITH([boost-libdir],
> +   AS_HELP_STRING([--with-boost-libdir=DIR],
> +                  [specify exact directory for Boost libraries]),
> +   [qpid_boost_libdir="$withval"])
> +
> +if test "${qpid_boost_include}"; then
> +   CPPFLAGS="$CPPFLAGS -I${qpid_boost_include}"
> +fi
> +
> +if test "${qpid_boost_libdir}"; then
> +   LDFLAGS="$LDFLAGS -L${qpid_boost_libdir}"
> +fi
> +
>  # Check for headers from required devel kits.
>  AC_CHECK_HEADERS([boost/shared_ptr.hpp uuid/uuid.h],,
>    AC_MSG_ERROR([Missing required header files.]))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (QPID-1070) Patch to allow configure options to set Boost header and lib locations

Posted by "Danushka Menikkumbura (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598182#action_12598182 ] 

Danushka Menikkumbura commented on QPID-1070:
---------------------------------------------

Hi Steve,
   The INSTALL file mentions about this.

Danushka

> Patch to allow configure options to set Boost header and lib locations
> ----------------------------------------------------------------------
>
>                 Key: QPID-1070
>                 URL: https://issues.apache.org/jira/browse/QPID-1070
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client
>    Affects Versions: M3
>         Environment: RHEL 4
>            Reporter: Steve Huston
>            Assignee: Andrew Stitcher
>            Priority: Minor
>
> The default (at least in 1.35) Boost install locations are in /usr/local (/usr/local/include/boost-1_35/boost and /usr/local/lib). These locations are not searched by g++ without additional options. This patch allows the following options to be supplied to the configure script:
> --with-boost=DIR
> --with-boost-include=DIR
> --with-boost-libdir=DIR
> The patch also includes changes related to 1068 (the first section from line 26)
> Index: configure.ac
> ===================================================================
> --- configure.ac        (revision 657445)
> +++ configure.ac        (working copy)
> @@ -26,7 +26,8 @@
>  # AM_MISSING_PROG([HELP2MAN], [help2man])
>  AC_CHECK_PROG([HELP2MAN], [help2man], [help2man])
> -test -z "$HELP2MAN" && AC_MSG_ERROR([Missing help2man installation (try "yum install help2man").])
> +test -z "$HELP2MAN" && AC_MSG_WARN([Missing help2man installation. Man pages will not be generated.])
> +AM_CONDITIONAL([GENERATE_MAN], [test X$HELP2MAN != X])
>  AC_ARG_ENABLE(warnings,
>  [  --enable-warnings   turn on lots of compiler warnings (recommended)],
> @@ -132,6 +133,38 @@
>  DOWNLOAD_URL=http://rhm.et.redhat.com/download
>  AC_SUBST(DOWNLOAD_URL)
> +# Allow Boost to be somewhere that requires compile and/or link options.
> +qpid_BOOST_CPPFLAGS=""
> +qpid_BOOST_LDFLAGS=""
> +AC_ARG_WITH([boost],
> +   AS_HELP_STRING([--with-boost@<:@=DIR@:>@],
> +                 [root directory of Boost installation]),
> +   [
> +   qpid_boost_root="${withval}"
> +   if test "${qpid_boost_root}" != yes; then
> +       qpid_boost_include="${qpid_boost_root}/include"
> +       qpid_boost_libdir="${qpid_boost_root}/lib"
> +   fi
> +   ])
> +
> +AC_ARG_WITH([boost-include],
> +   AS_HELP_STRING([--with-boost-include=DIR],
> +                  [specify exact directory for Boost headers]),
> +   [qpid_boost_include="$withval"])
> +
> +AC_ARG_WITH([boost-libdir],
> +   AS_HELP_STRING([--with-boost-libdir=DIR],
> +                  [specify exact directory for Boost libraries]),
> +   [qpid_boost_libdir="$withval"])
> +
> +if test "${qpid_boost_include}"; then
> +   CPPFLAGS="$CPPFLAGS -I${qpid_boost_include}"
> +fi
> +
> +if test "${qpid_boost_libdir}"; then
> +   LDFLAGS="$LDFLAGS -L${qpid_boost_libdir}"
> +fi
> +
>  # Check for headers from required devel kits.
>  AC_CHECK_HEADERS([boost/shared_ptr.hpp uuid/uuid.h],,
>    AC_MSG_ERROR([Missing required header files.]))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (QPID-1070) Patch to allow configure options to set Boost header and lib locations

Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597933#action_12597933 ] 

Steve Huston commented on QPID-1070:
------------------------------------

Ok, I'll look into PKG_CONFIG_PATH - I'm not familiar with it.

My boost 1.35 headers are in /usr/local/include/boost-1_35/boost and libs are (as usual) in /usr/local/lib, but have version numbers in the so names.

> Patch to allow configure options to set Boost header and lib locations
> ----------------------------------------------------------------------
>
>                 Key: QPID-1070
>                 URL: https://issues.apache.org/jira/browse/QPID-1070
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker, C++ Client
>    Affects Versions: M3
>         Environment: RHEL 4
>            Reporter: Steve Huston
>            Priority: Minor
>
> The default (at least in 1.35) Boost install locations are in /usr/local (/usr/local/include/boost-1_35/boost and /usr/local/lib). These locations are not searched by g++ without additional options. This patch allows the following options to be supplied to the configure script:
> --with-boost=DIR
> --with-boost-include=DIR
> --with-boost-libdir=DIR
> The patch also includes changes related to 1068 (the first section from line 26)
> Index: configure.ac
> ===================================================================
> --- configure.ac        (revision 657445)
> +++ configure.ac        (working copy)
> @@ -26,7 +26,8 @@
>  # AM_MISSING_PROG([HELP2MAN], [help2man])
>  AC_CHECK_PROG([HELP2MAN], [help2man], [help2man])
> -test -z "$HELP2MAN" && AC_MSG_ERROR([Missing help2man installation (try "yum install help2man").])
> +test -z "$HELP2MAN" && AC_MSG_WARN([Missing help2man installation. Man pages will not be generated.])
> +AM_CONDITIONAL([GENERATE_MAN], [test X$HELP2MAN != X])
>  AC_ARG_ENABLE(warnings,
>  [  --enable-warnings   turn on lots of compiler warnings (recommended)],
> @@ -132,6 +133,38 @@
>  DOWNLOAD_URL=http://rhm.et.redhat.com/download
>  AC_SUBST(DOWNLOAD_URL)
> +# Allow Boost to be somewhere that requires compile and/or link options.
> +qpid_BOOST_CPPFLAGS=""
> +qpid_BOOST_LDFLAGS=""
> +AC_ARG_WITH([boost],
> +   AS_HELP_STRING([--with-boost@<:@=DIR@:>@],
> +                 [root directory of Boost installation]),
> +   [
> +   qpid_boost_root="${withval}"
> +   if test "${qpid_boost_root}" != yes; then
> +       qpid_boost_include="${qpid_boost_root}/include"
> +       qpid_boost_libdir="${qpid_boost_root}/lib"
> +   fi
> +   ])
> +
> +AC_ARG_WITH([boost-include],
> +   AS_HELP_STRING([--with-boost-include=DIR],
> +                  [specify exact directory for Boost headers]),
> +   [qpid_boost_include="$withval"])
> +
> +AC_ARG_WITH([boost-libdir],
> +   AS_HELP_STRING([--with-boost-libdir=DIR],
> +                  [specify exact directory for Boost libraries]),
> +   [qpid_boost_libdir="$withval"])
> +
> +if test "${qpid_boost_include}"; then
> +   CPPFLAGS="$CPPFLAGS -I${qpid_boost_include}"
> +fi
> +
> +if test "${qpid_boost_libdir}"; then
> +   LDFLAGS="$LDFLAGS -L${qpid_boost_libdir}"
> +fi
> +
>  # Check for headers from required devel kits.
>  AC_CHECK_HEADERS([boost/shared_ptr.hpp uuid/uuid.h],,
>    AC_MSG_ERROR([Missing required header files.]))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.