[jira] [Commented] (AMQ-5621) Unit tests cleanup

["Kevin Burton (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339679#comment-14339679 ] 

Kevin Burton commented on AMQ-5621:
-----------------------------------

Totally agreed.   

A migration to junit 4 could be done by using a module just for tests.  If you can break these into submodules which take about 20-40 minutes to run it will also be easy to resume the tests.

Further, it should be possible to parallelize the modules being tested at that point (using containers to avoid file handle and socket issues).

And maybe a grep for Thread.sleep() would be nice.  

> Unit tests cleanup
> ------------------
>
>                 Key: AMQ-5621
>                 URL: https://issues.apache.org/jira/browse/AMQ-5621
>             Project: ActiveMQ
>          Issue Type: Improvement
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>            Priority: Minor
>
> Many of the existing test cases take longer than they should and fail randomly due to BrokerService instances that are still running that have open JMX connectors etc.  We should take some time to review tests and clean up were we can.  
> Removing hard sleeps and using admin view to check statistics can dramatically shorten a test.  Also the tests can be configured not to create JMX connectors as none of them need that in the normal case.  
> Other tasks that could be done is to update tests to JUnit 4 based tests with test timeouts to help prevent CI hangs.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)